From: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> To: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, Alexandru M Stan <amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, Douglas Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Subject: [PATCH v2 3/3] ARM: dts: rockchip: correct regulator power states for suspend Date: Wed, 19 Aug 2015 15:18:41 -0700 [thread overview] Message-ID: <1440022721-73712-3-git-send-email-briannorris@chromium.org> (raw) In-Reply-To: <1440022721-73712-1-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> When getting translated from a downstream device tree that used slightly different DT bindings, these regulators got labeled with the "on-in-suspend" state, when they were actually supposed to be turned off for S3 suspend. This was harmless, but not intentional, AFAICT. Let's turn them off to get the optimal power state. Signed-off-by: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Cc: Alexandru M Stan <amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Cc: Douglas Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> --- New in v2. Tested jaq. arch/arm/boot/dts/rk3288-veyron-jerry.dts | 2 +- arch/arm/boot/dts/rk3288-veyron-pinky.dts | 2 +- arch/arm/boot/dts/rk3288-veyron-sdmmc.dtsi | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/rk3288-veyron-jerry.dts b/arch/arm/boot/dts/rk3288-veyron-jerry.dts index 42d724559915..60bd6e91e308 100644 --- a/arch/arm/boot/dts/rk3288-veyron-jerry.dts +++ b/arch/arm/boot/dts/rk3288-veyron-jerry.dts @@ -99,7 +99,7 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-state-mem { - regulator-on-in-suspend; + regulator-off-in-suspend; }; }; }; diff --git a/arch/arm/boot/dts/rk3288-veyron-pinky.dts b/arch/arm/boot/dts/rk3288-veyron-pinky.dts index 25eb4b0c1330..94b56e33d947 100644 --- a/arch/arm/boot/dts/rk3288-veyron-pinky.dts +++ b/arch/arm/boot/dts/rk3288-veyron-pinky.dts @@ -109,7 +109,7 @@ regulator-boot-on; regulator-name = "vcc18_lcd"; regulator-state-mem { - regulator-on-in-suspend; + regulator-off-in-suspend; }; }; }; diff --git a/arch/arm/boot/dts/rk3288-veyron-sdmmc.dtsi b/arch/arm/boot/dts/rk3288-veyron-sdmmc.dtsi index 788468a48163..b5334ecff13c 100644 --- a/arch/arm/boot/dts/rk3288-veyron-sdmmc.dtsi +++ b/arch/arm/boot/dts/rk3288-veyron-sdmmc.dtsi @@ -93,7 +93,7 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-state-mem { - regulator-on-in-suspend; + regulator-off-in-suspend; }; }; @@ -102,7 +102,7 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-state-mem { - regulator-on-in-suspend; + regulator-off-in-suspend; }; }; }; -- 2.5.0.276.gf5e568e -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: briannorris@chromium.org (Brian Norris) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 3/3] ARM: dts: rockchip: correct regulator power states for suspend Date: Wed, 19 Aug 2015 15:18:41 -0700 [thread overview] Message-ID: <1440022721-73712-3-git-send-email-briannorris@chromium.org> (raw) In-Reply-To: <1440022721-73712-1-git-send-email-briannorris@chromium.org> When getting translated from a downstream device tree that used slightly different DT bindings, these regulators got labeled with the "on-in-suspend" state, when they were actually supposed to be turned off for S3 suspend. This was harmless, but not intentional, AFAICT. Let's turn them off to get the optimal power state. Signed-off-by: Brian Norris <briannorris@chromium.org> Cc: Alexandru M Stan <amstan@chromium.org> Cc: Douglas Anderson <dianders@chromium.org> --- New in v2. Tested jaq. arch/arm/boot/dts/rk3288-veyron-jerry.dts | 2 +- arch/arm/boot/dts/rk3288-veyron-pinky.dts | 2 +- arch/arm/boot/dts/rk3288-veyron-sdmmc.dtsi | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/rk3288-veyron-jerry.dts b/arch/arm/boot/dts/rk3288-veyron-jerry.dts index 42d724559915..60bd6e91e308 100644 --- a/arch/arm/boot/dts/rk3288-veyron-jerry.dts +++ b/arch/arm/boot/dts/rk3288-veyron-jerry.dts @@ -99,7 +99,7 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-state-mem { - regulator-on-in-suspend; + regulator-off-in-suspend; }; }; }; diff --git a/arch/arm/boot/dts/rk3288-veyron-pinky.dts b/arch/arm/boot/dts/rk3288-veyron-pinky.dts index 25eb4b0c1330..94b56e33d947 100644 --- a/arch/arm/boot/dts/rk3288-veyron-pinky.dts +++ b/arch/arm/boot/dts/rk3288-veyron-pinky.dts @@ -109,7 +109,7 @@ regulator-boot-on; regulator-name = "vcc18_lcd"; regulator-state-mem { - regulator-on-in-suspend; + regulator-off-in-suspend; }; }; }; diff --git a/arch/arm/boot/dts/rk3288-veyron-sdmmc.dtsi b/arch/arm/boot/dts/rk3288-veyron-sdmmc.dtsi index 788468a48163..b5334ecff13c 100644 --- a/arch/arm/boot/dts/rk3288-veyron-sdmmc.dtsi +++ b/arch/arm/boot/dts/rk3288-veyron-sdmmc.dtsi @@ -93,7 +93,7 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-state-mem { - regulator-on-in-suspend; + regulator-off-in-suspend; }; }; @@ -102,7 +102,7 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-state-mem { - regulator-on-in-suspend; + regulator-off-in-suspend; }; }; }; -- 2.5.0.276.gf5e568e
next prev parent reply other threads:[~2015-08-19 22:18 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-08-19 22:18 [PATCH v2 1/3] ARM: dts: rockchip: add veyron-jaq board Brian Norris 2015-08-19 22:18 ` Brian Norris [not found] ` <CAHNYxRzWHvy=mv+G6wwO29=9smOCwKh6gBPLbT-TNq0PmP2Xiw@mail.gmail.com> [not found] ` <CAHNYxRzWHvy=mv+G6wwO29=9smOCwKh6gBPLbT-TNq0PmP2Xiw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-08-19 22:59 ` Brian Norris 2015-08-19 22:59 ` Brian Norris [not found] ` <1440022721-73712-1-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2015-08-19 22:18 ` [PATCH v2 2/3] ARM: dts: rockchip: correct regulator PM properties Brian Norris 2015-08-19 22:18 ` Brian Norris [not found] ` <1440022721-73712-2-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2015-08-19 23:35 ` Javier Martinez Canillas 2015-08-19 23:35 ` Javier Martinez Canillas 2015-08-24 17:04 ` Heiko Stuebner 2015-08-24 17:04 ` Heiko Stuebner 2015-08-19 22:18 ` Brian Norris [this message] 2015-08-19 22:18 ` [PATCH v2 3/3] ARM: dts: rockchip: correct regulator power states for suspend Brian Norris [not found] ` <1440022721-73712-3-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2015-08-19 23:36 ` Javier Martinez Canillas 2015-08-19 23:36 ` Javier Martinez Canillas 2015-08-24 17:04 ` Heiko Stuebner 2015-08-24 17:04 ` Heiko Stuebner 2015-08-19 23:29 ` [PATCH v2 1/3] ARM: dts: rockchip: add veyron-jaq board Javier Martinez Canillas 2015-08-19 23:29 ` Javier Martinez Canillas [not found] ` <CABxcv=nQAfCzj_bQ9N-XYEPCNuihyrkUOz7=ogetKzye4KKNng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-08-24 17:53 ` Brian Norris 2015-08-24 17:53 ` Brian Norris [not found] ` <20150824175315.GA81574-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> 2015-08-24 17:58 ` Heiko Stuebner 2015-08-24 17:58 ` Heiko Stuebner 2015-08-24 18:01 ` Javier Martinez Canillas 2015-08-24 18:01 ` Javier Martinez Canillas [not found] ` <CABxcv=nXwL6LV0vnjffA0JV4NB-_mCufe3-0c7fsRKW3DE+-_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-08-24 18:06 ` Brian Norris 2015-08-24 18:06 ` Brian Norris
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1440022721-73712-3-git-send-email-briannorris@chromium.org \ --to=briannorris-f7+t8e8rja9g9huczpvpmw@public.gmane.org \ --cc=amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.