From: Javier Martinez Canillas <javier@osg.samsung.com> To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas <javier@osg.samsung.com>, linux-fbdev@vger.kernel.org, Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>, Tomi Valkeinen <tomi.valkeinen@ti.com>, linux-omap@vger.kernel.org Subject: [PATCH 04/18] OMAPDSS: panel-sony-acx565akm: Export OF module alias information Date: Thu, 20 Aug 2015 09:07:17 +0200 [thread overview] Message-ID: <1440054451-1223-5-git-send-email-javier@osg.samsung.com> (raw) In-Reply-To: <1440054451-1223-1-git-send-email-javier@osg.samsung.com> The SPI core always reports the MODALIAS uevent as "spi:<modalias>" regardless of the mechanism that was used to register the device (i.e: OF or board code) and the table that is used later to match the driver with the device (i.e: SPI id table or OF match table). So drivers needs to export the SPI id table and this be built into the module or udev won't have the necessary information to autoload the needed driver module when the device is added. But this means that OF-only drivers needs to have both OF and SPI id tables that have to be kept in sync and also the dev node compatible manufacturer prefix is stripped when reporting the MODALIAS. Which can lead to issues if two vendors use the same SPI device name for example. To avoid the above, the SPI core behavior may be changed in the future to not require an SPI device table for OF-only drivers and report the OF module alias. So, it's better to also export the OF table even when is unused now to prevent breaking module loading when the core changes. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c index 90cbc4c3406c..c581231c74a5 100644 --- a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c +++ b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c @@ -898,6 +898,7 @@ static const struct of_device_id acx565akm_of_match[] = { { .compatible = "omapdss,sony,acx565akm", }, {}, }; +MODULE_DEVICE_TABLE(of, acx565akm_of_match); static struct spi_driver acx565akm_driver = { .driver = { -- 2.4.3
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier@osg.samsung.com> To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas <javier@osg.samsung.com>, linux-fbdev@vger.kernel.org, Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>, Tomi Valkeinen <tomi.valkeinen@ti.com>, linux-omap@vger.kernel.org Subject: [PATCH 04/18] OMAPDSS: panel-sony-acx565akm: Export OF module alias information Date: Thu, 20 Aug 2015 07:07:17 +0000 [thread overview] Message-ID: <1440054451-1223-5-git-send-email-javier@osg.samsung.com> (raw) In-Reply-To: <1440054451-1223-1-git-send-email-javier@osg.samsung.com> The SPI core always reports the MODALIAS uevent as "spi:<modalias>" regardless of the mechanism that was used to register the device (i.e: OF or board code) and the table that is used later to match the driver with the device (i.e: SPI id table or OF match table). So drivers needs to export the SPI id table and this be built into the module or udev won't have the necessary information to autoload the needed driver module when the device is added. But this means that OF-only drivers needs to have both OF and SPI id tables that have to be kept in sync and also the dev node compatible manufacturer prefix is stripped when reporting the MODALIAS. Which can lead to issues if two vendors use the same SPI device name for example. To avoid the above, the SPI core behavior may be changed in the future to not require an SPI device table for OF-only drivers and report the OF module alias. So, it's better to also export the OF table even when is unused now to prevent breaking module loading when the core changes. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c index 90cbc4c3406c..c581231c74a5 100644 --- a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c +++ b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c @@ -898,6 +898,7 @@ static const struct of_device_id acx565akm_of_match[] = { { .compatible = "omapdss,sony,acx565akm", }, {}, }; +MODULE_DEVICE_TABLE(of, acx565akm_of_match); static struct spi_driver acx565akm_driver = { .driver = { -- 2.4.3
next prev parent reply other threads:[~2015-08-20 7:08 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-08-20 7:07 [PATCH 00/18] Export SPI and OF module aliases in missing drivers Javier Martinez Canillas 2015-08-20 7:07 ` Javier Martinez Canillas 2015-08-20 7:07 ` Javier Martinez Canillas 2015-08-20 7:07 ` [PATCH 01/18] iio: Export SPI module alias information " Javier Martinez Canillas 2015-08-20 15:49 ` Lars-Peter Clausen 2015-08-22 18:08 ` Jonathan Cameron 2015-08-20 7:07 ` [PATCH 02/18] staging: iio: hmc5843: Export missing SPI module alias information Javier Martinez Canillas 2015-08-22 17:59 ` Jonathan Cameron 2015-08-31 23:09 ` Javier Martinez Canillas 2015-09-05 16:31 ` Jonathan Cameron 2015-09-05 23:34 ` Javier Martinez Canillas 2015-08-20 7:07 ` [PATCH 03/18] mtd: dataflash: Export OF " Javier Martinez Canillas 2015-08-20 21:54 ` Brian Norris 2015-08-20 22:13 ` Javier Martinez Canillas 2015-08-20 22:34 ` Brian Norris 2015-08-20 22:57 ` Javier Martinez Canillas 2015-08-21 22:47 ` Brian Norris 2015-08-22 0:26 ` Javier Martinez Canillas 2015-08-22 1:05 ` Brian Norris 2015-08-22 1:10 ` Javier Martinez Canillas 2015-08-20 7:07 ` Javier Martinez Canillas [this message] 2015-08-20 7:07 ` [PATCH 04/18] OMAPDSS: panel-sony-acx565akm: " Javier Martinez Canillas 2015-08-20 7:07 ` [PATCH 05/18] mmc: mmc_spi: " Javier Martinez Canillas 2015-08-20 7:07 ` [PATCH 06/18] staging: mt29f_spinand: " Javier Martinez Canillas 2015-08-20 7:07 ` [PATCH 07/18] net: ks8851: " Javier Martinez Canillas 2015-08-20 7:07 ` [PATCH 08/18] [media] s5c73m3: " Javier Martinez Canillas 2015-09-11 1:19 ` Javier Martinez Canillas 2015-09-11 9:37 ` Andrzej Hajda 2015-09-11 10:10 ` Andrzej Hajda 2015-09-11 10:33 ` Javier Martinez Canillas 2015-08-20 7:07 ` [PATCH 09/18] mfd: cros_ec: spi: Add OF match table Javier Martinez Canillas 2015-08-24 14:00 ` Lee Jones 2015-08-20 7:07 ` [PATCH 10/18] iio: dac: ad7303: " Javier Martinez Canillas 2015-08-20 15:49 ` Lars-Peter Clausen 2015-08-22 18:06 ` Jonathan Cameron 2015-08-20 7:07 ` [PATCH 11/18] iio: adc: max1027: Set struct spi_driver .of_match_table Javier Martinez Canillas 2015-08-22 18:00 ` Jonathan Cameron 2015-08-20 7:07 ` [PATCH 12/18] mfd: stmpe: Add OF match table Javier Martinez Canillas 2015-08-24 13:59 ` Lee Jones 2015-08-20 7:07 ` [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table Javier Martinez Canillas 2015-08-20 20:09 ` Michael Welling 2015-08-20 22:02 ` Javier Martinez Canillas 2015-08-20 22:29 ` Michael Welling 2015-08-20 22:48 ` Javier Martinez Canillas 2015-08-20 23:53 ` Michael Welling 2015-08-22 18:09 ` Jonathan Cameron 2015-08-22 17:48 ` Jonathan Cameron 2015-08-22 17:48 ` Jonathan Cameron 2015-08-23 22:10 ` Rob Herring 2015-08-23 22:10 ` Rob Herring 2015-08-24 7:19 ` Javier Martinez Canillas 2015-08-24 7:19 ` Javier Martinez Canillas 2015-08-20 7:07 ` [PATCH 14/18] iio: as3935: Add OF match table Javier Martinez Canillas 2015-08-22 18:02 ` Jonathan Cameron 2015-08-20 7:07 ` [PATCH 15/18] iio: adc128s052: " Javier Martinez Canillas 2015-08-22 18:03 ` Jonathan Cameron 2015-08-20 7:07 ` [PATCH 16/18] iio: frequency: adf4350: " Javier Martinez Canillas 2015-08-20 15:49 ` Lars-Peter Clausen 2015-08-22 18:04 ` Jonathan Cameron 2015-08-20 7:07 ` [PATCH 17/18] NFC: trf7970a: " Javier Martinez Canillas 2015-08-20 7:07 ` [PATCH 18/18] spi: (RFC, don't apply) report OF style modalias when probing using DT Javier Martinez Canillas 2015-08-20 18:36 ` Mark Brown 2015-08-20 18:36 ` Mark Brown 2015-08-20 21:08 ` Brian Norris 2015-08-20 21:08 ` Brian Norris 2015-08-20 21:45 ` Javier Martinez Canillas 2015-08-20 21:45 ` Javier Martinez Canillas 2015-08-20 23:25 ` Mark Brown 2015-08-20 23:25 ` Mark Brown 2015-08-20 23:47 ` Javier Martinez Canillas 2015-08-21 17:29 ` Mark Brown 2015-08-21 17:29 ` Mark Brown 2015-08-24 8:00 ` Javier Martinez Canillas 2015-08-24 8:00 ` Javier Martinez Canillas 2015-08-20 21:11 ` [PATCH 00/18] Export SPI and OF module aliases in missing drivers Brian Norris 2015-08-20 21:11 ` Brian Norris 2015-08-20 21:11 ` Brian Norris 2015-08-20 21:50 ` Javier Martinez Canillas 2015-08-20 21:50 ` Javier Martinez Canillas 2015-08-20 21:50 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1440054451-1223-5-git-send-email-javier@osg.samsung.com \ --to=javier@osg.samsung.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=plagnioj@jcrosoft.com \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.