From: Julia Lawall <Julia.Lawall@lip6.fr> To: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: kernel-janitors@vger.kernel.org, Paul Mackerras <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Russell King - ARM Linux <linux@arm.linux.org.uk>, Thomas Petazzoni <thomas.petazzoni@free-electrons.com>, Andrew Lunn <andrew@lunn.ch>, Bjorn Helgaas <bhelgaas@google.com>, Jason Cooper <jason@lakedaemon.net> Subject: [PATCH 5/6] powerpc/btext: add missing of_node_put Date: Fri, 20 Nov 2015 21:33:23 +0100 [thread overview] Message-ID: <1448051604-25256-6-git-send-email-Julia.Lawall@lip6.fr> (raw) In-Reply-To: <1448051604-25256-1-git-send-email-Julia.Lawall@lip6.fr> for_each_node_by_type performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ local idexpression n; expression e; @@ for_each_node_by_type(n,...) { ... ( of_node_put(n); | e = n | + of_node_put(n); ? break; ) ... } ... when != n // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- arch/powerpc/kernel/btext.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/btext.c b/arch/powerpc/kernel/btext.c index 41c011c..8d05ef2 100644 --- a/arch/powerpc/kernel/btext.c +++ b/arch/powerpc/kernel/btext.c @@ -257,8 +257,10 @@ int __init btext_find_display(int allow_nonstdout) rc = btext_initialize(np); printk("result: %d\n", rc); } - if (rc == 0) + if (rc == 0) { + of_node_put(np); break; + } } return rc; }
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <Julia.Lawall@lip6.fr> To: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: kernel-janitors@vger.kernel.org, Paul Mackerras <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Russell King - ARM Linux <linux@arm.linux.org.uk>, Thomas Petazzoni <thomas.petazzoni@free-electrons.com>, Andrew Lunn <andrew@lunn.ch>, Bjorn Helgaas <bhelgaas@google.com>, Jason Cooper <jason@lakedaemon.net> Subject: [PATCH 5/6] powerpc/btext: add missing of_node_put Date: Fri, 20 Nov 2015 20:33:23 +0000 [thread overview] Message-ID: <1448051604-25256-6-git-send-email-Julia.Lawall@lip6.fr> (raw) In-Reply-To: <1448051604-25256-1-git-send-email-Julia.Lawall@lip6.fr> for_each_node_by_type performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ local idexpression n; expression e; @@ for_each_node_by_type(n,...) { ... ( of_node_put(n); | e = n | + of_node_put(n); ? break; ) ... } ... when != n // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- arch/powerpc/kernel/btext.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/btext.c b/arch/powerpc/kernel/btext.c index 41c011c..8d05ef2 100644 --- a/arch/powerpc/kernel/btext.c +++ b/arch/powerpc/kernel/btext.c @@ -257,8 +257,10 @@ int __init btext_find_display(int allow_nonstdout) rc = btext_initialize(np); printk("result: %d\n", rc); } - if (rc = 0) + if (rc = 0) { + of_node_put(np); break; + } } return rc; }
next prev parent reply other threads:[~2015-11-20 20:47 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-20 20:33 [PATCH 0/6] add missing of_node_put Julia Lawall 2015-11-20 20:33 ` Julia Lawall 2015-11-20 20:33 ` [PATCH 1/6] powerpc/6xx: " Julia Lawall 2015-11-20 20:33 ` Julia Lawall 2015-11-20 20:33 ` [PATCH 2/6] powerpc/pseries: " Julia Lawall 2015-11-20 20:33 ` Julia Lawall 2015-11-20 20:33 ` [PATCH 3/6] powerpc/powernv: " Julia Lawall 2015-11-20 20:33 ` Julia Lawall 2015-11-20 20:33 ` [PATCH 4/6] powerpc/kexec: " Julia Lawall 2015-11-20 20:33 ` Julia Lawall 2015-11-20 20:33 ` Julia Lawall [this message] 2015-11-20 20:33 ` [PATCH 5/6] powerpc/btext: " Julia Lawall 2015-11-20 20:33 ` [PATCH 6/6] powerpc/cell: " Julia Lawall 2015-11-20 20:33 ` Julia Lawall 2021-11-25 9:35 ` (subset) [PATCH 0/6] " Michael Ellerman 2021-11-25 9:35 ` Michael Ellerman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1448051604-25256-6-git-send-email-Julia.Lawall@lip6.fr \ --to=julia.lawall@lip6.fr \ --cc=andrew@lunn.ch \ --cc=benh@kernel.crashing.org \ --cc=bhelgaas@google.com \ --cc=jason@lakedaemon.net \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=paulus@samba.org \ --cc=thomas.petazzoni@free-electrons.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.