All of lore.kernel.org
 help / color / mirror / Atom feed
From: Inki Dae <inki.dae@samsung.com>
To: dri-devel@lists.freedesktop.org
Cc: airlied@linux.ie, linux-samsung-soc@vger.kernel.org,
	javier@osg.samsung.com, Inki Dae <inki.dae@samsung.com>
Subject: [PATCH v2 2/2] drm/exynos: dp: fix wrong return type
Date: Wed, 02 Dec 2015 20:57:52 +0900	[thread overview]
Message-ID: <1449057472-4389-2-git-send-email-inki.dae@samsung.com> (raw)
In-Reply-To: <1449057472-4389-1-git-send-email-inki.dae@samsung.com>

This patch fixes wrong return type when dt binding of bridge device
failed.

If a board has a bridge device then of_graph_get_remote_port_parent
function shouldn't be NULL. So this patch will return a proper error
type so that the deferred probe isn't triggered.

Changelog v2:
- return -EINVAL if getting a port node failed.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_dp_core.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
index 0b53045..c77fb83 100644
--- a/drivers/gpu/drm/exynos/exynos_dp_core.c
+++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
@@ -1436,8 +1436,10 @@ static int exynos_dp_probe(struct platform_device *pdev)
 			of_node_put(bridge_node);
 			if (!dp->ptn_bridge)
 				return -EPROBE_DEFER;
-		} else
-			return -EPROBE_DEFER;
+		} else {
+			DRM_ERROR("no port node for bridge device.\n");
+			return -EINVAL;
+		}
 	}
 
 	pm_runtime_enable(dev);
-- 
1.9.1

  reply	other threads:[~2015-12-02 11:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02 11:57 [PATCH v2 1/2] drm/exynos: dp: add of_graph dt binding support for panel Inki Dae
2015-12-02 11:57 ` Inki Dae [this message]
2015-12-02 12:03   ` [PATCH v2 2/2] drm/exynos: dp: fix wrong return type Javier Martinez Canillas
2015-12-02 15:04 ` [PATCH v2 1/2] drm/exynos: dp: add of_graph dt binding support for panel Javier Martinez Canillas
2015-12-03  2:11   ` Inki Dae
2015-12-03 13:05     ` Javier Martinez Canillas
2015-12-06 16:25       ` Inki Dae
2015-12-07 12:17         ` Javier Martinez Canillas
2015-12-03  7:11 ` Inki Dae
2015-12-03 22:51 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449057472-4389-2-git-send-email-inki.dae@samsung.com \
    --to=inki.dae@samsung.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javier@osg.samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.