All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: [PATCH 5/5] drm/tda998x: Remove dummy save/restore funcs
Date: Tue,  8 Dec 2015 09:49:21 +0100	[thread overview]
Message-ID: <1449564561-3896-5-git-send-email-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <1449564561-3896-1-git-send-email-daniel.vetter@ffwll.ch>

In my quest to remove all the drm_encoder_helper_funcs->save/restore
hooks I somehow missed that this driver has a dummy set too - I
thought all the i2c drivers only set up the slave_encoder save/restore
hooks, which I've left. Remove them.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/i2c/tda998x_drv.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 896b6aaf8c4d..79cb9208530e 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -855,18 +855,6 @@ static void tda998x_encoder_dpms(struct drm_encoder *encoder, int mode)
 	priv->dpms = mode;
 }
 
-static void
-tda998x_encoder_save(struct drm_encoder *encoder)
-{
-	DBG("");
-}
-
-static void
-tda998x_encoder_restore(struct drm_encoder *encoder)
-{
-	DBG("");
-}
-
 static bool
 tda998x_encoder_mode_fixup(struct drm_encoder *encoder,
 			  const struct drm_display_mode *mode,
@@ -1351,8 +1339,6 @@ static void tda998x_encoder_commit(struct drm_encoder *encoder)
 
 static const struct drm_encoder_helper_funcs tda998x_encoder_helper_funcs = {
 	.dpms = tda998x_encoder_dpms,
-	.save = tda998x_encoder_save,
-	.restore = tda998x_encoder_restore,
 	.mode_fixup = tda998x_encoder_mode_fixup,
 	.prepare = tda998x_encoder_prepare,
 	.commit = tda998x_encoder_commit,
-- 
2.5.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2015-12-08  8:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-08  8:49 [PATCH 1/5] [RFC] drm: Documentation style guide Daniel Vetter
2015-12-08  8:49 ` [PATCH 2/5] drm/atomic-helper: Drop unneeded argument from check_pending_encoder Daniel Vetter
2015-12-14 15:58   ` Thierry Reding
2015-12-08  8:49 ` [PATCH 3/5] drm: Move more framebuffer doc from docbook to kerneldoc Daniel Vetter
2015-12-14 15:58   ` Thierry Reding
2015-12-14 17:25     ` Daniel Vetter
2015-12-08  8:49 ` [PATCH 4/5] drm/atomic-helper: Reject legacy flips on a disabled pipe Daniel Vetter
2015-12-08 12:01   ` [Intel-gfx] " Daniel Stone
2016-01-05  9:02     ` Daniel Vetter
2015-12-08 13:55   ` Ilia Mirkin
2015-12-08  8:49 ` Daniel Vetter [this message]
2015-12-08  9:30   ` [PATCH 5/5] drm/tda998x: Remove dummy save/restore funcs Emil Velikov
2015-12-08 10:11     ` Daniel Vetter
2015-12-08 10:15       ` Russell King - ARM Linux
2015-12-08 15:29         ` Rodrigo Vivi
2015-12-08  9:59 ` [PATCH 1/5] [RFC] drm: Documentation style guide Pierre Moreau
2015-12-08 10:14   ` Daniel Vetter
2015-12-08 13:49   ` Laurent Pinchart
2015-12-09 10:41     ` [PATCH] " Daniel Vetter
2015-12-09 10:44       ` Daniel Vetter
2015-12-09 11:21       ` Jani Nikula
2015-12-09 12:35         ` Laurent Pinchart
2015-12-09 14:17           ` Jani Nikula
2015-12-09 14:32             ` Laurent Pinchart
2015-12-09 13:35         ` Daniel Vetter
2015-12-09 15:19       ` Lukas Wunner
2015-12-09 16:08         ` Daniel Vetter
2015-12-14 15:39           ` Thierry Reding
2015-12-15 14:56             ` Dave Gordon
2015-12-15 16:09               ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449564561-3896-5-git-send-email-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.