From: Ming Lei <ming.lei@canonical.com>
To: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Cc: linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Sagi Grimberg <sagig@dev.mellanox.co.il>,
Ming Lei <ming.lei@canonical.com>
Subject: [PATCH 2/4] block: check virt boundary in bio_will_gap()
Date: Mon, 15 Feb 2016 15:01:25 +0800 [thread overview]
Message-ID: <1455519687-23873-3-git-send-email-ming.lei@canonical.com> (raw)
In-Reply-To: <1455519687-23873-1-git-send-email-ming.lei@canonical.com>
In the following patch, the way for figuring out
the last bvec will be changed with a bit cost introduced,
so return immediately if the queue doesn't have virt
boundary limit. Actually most of devices have not
this limit.
Cc: Sagi Grimberg <sagig@dev.mellanox.co.il>
Cc: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
---
include/linux/blkdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 4571ef1..b8ff6a3 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1388,7 +1388,7 @@ static inline bool bvec_gap_to_prev(struct request_queue *q,
static inline bool bio_will_gap(struct request_queue *q, struct bio *prev,
struct bio *next)
{
- if (!bio_has_data(prev))
+ if (!bio_has_data(prev) || !queue_virt_boundary(q))
return false;
return bvec_gap_to_prev(q, &prev->bi_io_vec[prev->bi_vcnt - 1],
--
1.9.1
next prev parent reply other threads:[~2016-02-15 7:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 7:01 [PATCH 0/4] block: fix bio_will_gap() Ming Lei
2016-02-15 7:01 ` [PATCH 1/4] block: bio: introduce helpers to get the 1st and last bvec Ming Lei
2016-02-15 8:19 ` Sagi Grimberg
2016-02-15 9:42 ` Ming Lei
2016-02-15 20:06 ` Sagi Grimberg
2016-02-16 13:03 ` Ming Lei
2016-02-17 3:08 ` Elliott, Robert (Persistent Memory)
2016-02-18 4:24 ` Kent Overstreet
2016-02-18 6:16 ` Ming Lei
2016-02-19 1:47 ` Ming Lei
2016-02-15 7:01 ` Ming Lei [this message]
2016-02-15 8:22 ` [PATCH 2/4] block: check virt boundary in bio_will_gap() Sagi Grimberg
2016-02-15 10:27 ` Ming Lei
2016-02-15 20:27 ` Sagi Grimberg
2016-02-16 13:05 ` Ming Lei
2016-02-16 13:08 ` Ming Lei
2016-02-15 8:33 ` [PATCH 0/4] block: fix bio_will_gap() Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455519687-23873-3-git-send-email-ming.lei@canonical.com \
--to=ming.lei@canonical.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sagig@dev.mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.