All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: arm@kernel.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/9] ARM: uniphier: add missing of_node_put()
Date: Tue, 16 Feb 2016 11:15:05 +0900	[thread overview]
Message-ID: <1455588911-9827-4-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1455588911-9827-1-git-send-email-yamada.masahiro@socionext.com>

This node pointer is allocated by of_find_compatible_node() in this
function.  It should be put before exitting this function.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/arm/mach-uniphier/platsmp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-uniphier/platsmp.c b/arch/arm/mach-uniphier/platsmp.c
index b53a8d9..fad568d 100644
--- a/arch/arm/mach-uniphier/platsmp.c
+++ b/arch/arm/mach-uniphier/platsmp.c
@@ -100,6 +100,7 @@ static int __init uniphier_smp_prepare_trampoline(unsigned int max_cpus)
 
 	np = of_find_compatible_node(NULL, NULL, "socionext,uniphier-smpctrl");
 	ret = of_address_to_resource(np, 0, &res);
+	of_node_put(np);
 	if (ret) {
 		pr_err("failed to get resource of uniphier-smpctrl\n");
 		return ret;
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: yamada.masahiro@socionext.com (Masahiro Yamada)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/9] ARM: uniphier: add missing of_node_put()
Date: Tue, 16 Feb 2016 11:15:05 +0900	[thread overview]
Message-ID: <1455588911-9827-4-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1455588911-9827-1-git-send-email-yamada.masahiro@socionext.com>

This node pointer is allocated by of_find_compatible_node() in this
function.  It should be put before exitting this function.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/arm/mach-uniphier/platsmp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-uniphier/platsmp.c b/arch/arm/mach-uniphier/platsmp.c
index b53a8d9..fad568d 100644
--- a/arch/arm/mach-uniphier/platsmp.c
+++ b/arch/arm/mach-uniphier/platsmp.c
@@ -100,6 +100,7 @@ static int __init uniphier_smp_prepare_trampoline(unsigned int max_cpus)
 
 	np = of_find_compatible_node(NULL, NULL, "socionext,uniphier-smpctrl");
 	ret = of_address_to_resource(np, 0, &res);
+	of_node_put(np);
 	if (ret) {
 		pr_err("failed to get resource of uniphier-smpctrl\n");
 		return ret;
-- 
1.9.1

  parent reply	other threads:[~2016-02-16  2:18 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-16  2:15 [PATCH 0/9] ARM: uniphier: UniPhier updates for Linux 4.6-rc1 Masahiro Yamada
2016-02-16  2:15 ` Masahiro Yamada
2016-02-16  2:15 ` [PATCH 1/9] ARM: dts: uniphier: factor out ranges property of support card Masahiro Yamada
2016-02-16  2:15   ` Masahiro Yamada
2016-02-16  2:15 ` [PATCH 2/9] ARM: dts: uniphier: rework UniPhier System Bus nodes Masahiro Yamada
2016-02-16  2:15   ` Masahiro Yamada
2016-02-25  0:26   ` Olof Johansson
2016-02-25  0:26     ` Olof Johansson
2016-02-25  2:22     ` Masahiro Yamada
2016-02-25  2:22       ` Masahiro Yamada
2016-02-25  7:20       ` Olof Johansson
2016-02-25  7:20         ` Olof Johansson
2016-02-26  7:21         ` Masahiro Yamada
2016-02-26  7:21           ` Masahiro Yamada
2016-02-16  2:15 ` Masahiro Yamada [this message]
2016-02-16  2:15   ` [PATCH 3/9] ARM: uniphier: add missing of_node_put() Masahiro Yamada
2016-02-16  2:15 ` [PATCH 4/9] ARM: dts: uniphier: add reference clock nodes Masahiro Yamada
2016-02-16  2:15   ` Masahiro Yamada
2016-02-16  2:15 ` [PATCH 5/9] ARM: dts: uniphier: add EEPROM node for ProXstream2 Gentil board Masahiro Yamada
2016-02-16  2:15   ` Masahiro Yamada
2016-02-16  2:15 ` [PATCH 6/9] ARM: dts: uniphier: enable I2C channel 2 of " Masahiro Yamada
2016-02-16  2:15   ` Masahiro Yamada
2016-02-16  2:15 ` [PATCH 7/9] ARM: dts: uniphier: add PH1-Pro4 Ace board support Masahiro Yamada
2016-02-16  2:15   ` Masahiro Yamada
2016-02-16  2:15 ` [PATCH 8/9] ARM: dts: uniphier: add PH1-Pro4 Sanji " Masahiro Yamada
2016-02-16  2:15   ` Masahiro Yamada
2016-02-16  2:15 ` [PATCH 9/9] ARM: dts: uniphier: add @{address} to EEPROM node Masahiro Yamada
2016-02-16  2:15   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455588911-9827-4-git-send-email-yamada.masahiro@socionext.com \
    --to=yamada.masahiro@socionext.com \
    --cc=arm@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.