All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Alexandra Yates <alexandra.yates@intel.com>,
	Dylan Baker <baker.dylan.c@gmail.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH i-g-t] scripts/run-test.sh: Piglit overwrite option.
Date: Fri, 18 Mar 2016 07:02:11 -0700	[thread overview]
Message-ID: <1458309731-3065-1-git-send-email-rodrigo.vivi@intel.com> (raw)

The following piglit commit adds one option to overwrite files:

commit ec317ece07afdf9c8a26de04bdec8a94e5d7b2db
Author: Dylan Baker <baker.dylan.c@gmail.com>
Date:   Mon Feb 1 15:08:23 2016 -0800

    framework/programs/run.py: Add option for overwriting files

So our run-script.sh test that creates the directory before executing
the tests were failing with:

"Fatal Error: Cannot overwrite existing folder w/o the -o /--overwrite option being sent"

I believe it took a while to notice that because many of us never
upgrade the piglit. But also the risk with this patch is to have an environment
with the old piglit so the result will be:
piglit: error: unrecognized arguments: --overwrite

So, let's start the discussion and also provide the patch that allows
some people with new version to get it running.

Cc: Dylan Baker <baker.dylan.c@gmail.com>
Cc: Alexandra Yates <alexandra.yates@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 scripts/run-tests.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh
index 99e6124..b1abeab 100755
--- a/scripts/run-tests.sh
+++ b/scripts/run-tests.sh
@@ -124,8 +124,7 @@ fi
 if [ "x$RESUME" != "x" ]; then
 	sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" resume "$RESULTS" $NORETRY
 else
-	mkdir -p "$RESULTS"
-	sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run igt "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER
+	sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run --overwrite igt "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER
 fi
 
 if [ "$SUMMARY" == "html" ]; then
-- 
2.4.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2016-03-18 22:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18 14:02 Rodrigo Vivi [this message]
2016-03-21 10:53 ` [PATCH i-g-t] scripts/run-test.sh: Piglit overwrite option Marius Vlad
2016-03-22  2:00   ` Vivi, Rodrigo
2016-03-22 16:34     ` Dylan Baker
2016-03-24  1:52       ` Vivi, Rodrigo
2016-03-24 15:17         ` Dylan Baker
2016-03-21 11:27 ` Gabriel Feceoru
2016-03-22  2:05   ` Vivi, Rodrigo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458309731-3065-1-git-send-email-rodrigo.vivi@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=alexandra.yates@intel.com \
    --cc=baker.dylan.c@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.