From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: <ath10k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>, <rmanohar@codeaurora.org>,
"Rajkumar Manoharan" <rmanohar@qti.qualcomm.com>
Subject: [PATCH 1/3] ath10k: fix calibration init sequence of qca99x0
Date: Wed, 30 Mar 2016 21:12:29 +0530 [thread overview]
Message-ID: <1459352551-11773-1-git-send-email-rmanohar@qti.qualcomm.com> (raw)
pre-calibration is meant for qca4019 which contains only caldata
whereas calibration file is used by ar9888 and qca99x0 that contains
both board data and caldata. So by definition both pre-cal-file and
cal-file can not coexist. Keeping them in shared memory (union), is
breaking boot sequence of qca99x0. Fix it by storing both binaries
in separate memories. This issue is reported in ipq8064 platform which
includes caldata in flash memory.
Reported-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/core.h | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
index b6c157e..a7d04bc 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -725,10 +725,8 @@ struct ath10k {
const void *firmware_data;
size_t firmware_len;
- union {
- const struct firmware *pre_cal_file;
- const struct firmware *cal_file;
- };
+ const struct firmware *pre_cal_file;
+ const struct firmware *cal_file;
struct {
const void *firmware_codeswap_data;
--
2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org,
Rajkumar Manoharan <rmanohar@qti.qualcomm.com>,
rmanohar@codeaurora.org
Subject: [PATCH 1/3] ath10k: fix calibration init sequence of qca99x0
Date: Wed, 30 Mar 2016 21:12:29 +0530 [thread overview]
Message-ID: <1459352551-11773-1-git-send-email-rmanohar@qti.qualcomm.com> (raw)
pre-calibration is meant for qca4019 which contains only caldata
whereas calibration file is used by ar9888 and qca99x0 that contains
both board data and caldata. So by definition both pre-cal-file and
cal-file can not coexist. Keeping them in shared memory (union), is
breaking boot sequence of qca99x0. Fix it by storing both binaries
in separate memories. This issue is reported in ipq8064 platform which
includes caldata in flash memory.
Reported-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/core.h | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
index b6c157e..a7d04bc 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -725,10 +725,8 @@ struct ath10k {
const void *firmware_data;
size_t firmware_len;
- union {
- const struct firmware *pre_cal_file;
- const struct firmware *cal_file;
- };
+ const struct firmware *pre_cal_file;
+ const struct firmware *cal_file;
struct {
const void *firmware_codeswap_data;
--
2.7.4
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next reply other threads:[~2016-03-30 15:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 15:42 Rajkumar Manoharan [this message]
2016-03-30 15:42 ` [PATCH 1/3] ath10k: fix calibration init sequence of qca99x0 Rajkumar Manoharan
2016-03-30 15:42 ` [PATCH 2/3] ath10k: remove unnecessary warning for probe response drops Rajkumar Manoharan
2016-03-30 15:42 ` Rajkumar Manoharan
2016-03-31 16:57 ` Ben Greear
2016-03-31 16:57 ` Ben Greear
2016-04-01 5:13 ` Rajkumar Manoharan
2016-04-01 5:13 ` Rajkumar Manoharan
2016-03-30 15:42 ` [PATCH 3/3] ath10k: fix unconditional num_mpdus_ready subtraction Rajkumar Manoharan
2016-03-30 15:42 ` Rajkumar Manoharan
2016-03-31 18:52 ` Ben Greear
2016-03-31 18:52 ` Ben Greear
2016-04-01 5:19 ` Rajkumar Manoharan
2016-04-01 5:19 ` Rajkumar Manoharan
2016-04-05 12:46 ` Valo, Kalle
2016-04-05 12:46 ` Valo, Kalle
2016-04-05 12:48 ` Valo, Kalle
2016-04-05 12:48 ` Valo, Kalle
2016-04-05 13:34 ` Rajkumar Manoharan
2016-04-05 13:34 ` Rajkumar Manoharan
2016-04-05 12:40 ` [PATCH 1/3] ath10k: fix calibration init sequence of qca99x0 Valo, Kalle
2016-04-05 12:40 ` Valo, Kalle
2016-04-05 13:32 ` Rajkumar Manoharan
2016-04-05 13:32 ` Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459352551-11773-1-git-send-email-rmanohar@qti.qualcomm.com \
--to=rmanohar@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.