All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: linux-nvdimm@lists.01.org
Subject: [ndctl PATCH 5/8] ndctl, xaction-namespace: make 'verbose' option available in all sub-commands
Date: Fri, 22 Apr 2016 12:47:28 -0700	[thread overview]
Message-ID: <146135444838.4228.16562355726281815141.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
In-Reply-To: <146135442234.4228.904225076597683142.stgit@dwillia2-desk3.amr.corp.intel.com>

Rather than limiting the -v option to create-namespace, enable it for
all xaction-namespace commands i.e. {enable, disable, create,
destroy}-namespace.

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 Documentation/ndctl-destroy-namespace.txt |    5 +++++
 Documentation/xable-namespace-options.txt |    4 ++++
 builtin-xaction-namespace.c               |    6 +++---
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/Documentation/ndctl-destroy-namespace.txt b/Documentation/ndctl-destroy-namespace.txt
index 623820533cec..ea6d2856107a 100644
--- a/Documentation/ndctl-destroy-namespace.txt
+++ b/Documentation/ndctl-destroy-namespace.txt
@@ -22,6 +22,11 @@ include::xable-namespace-options.txt[]
 	Specifying --force causes the namespace to be disabled before
 	the operation is attempted.
 
+-v::
+--verbose::
+	Emit debug messages for the namespace destruction operation
+
+
 SEE ALSO
 --------
 linkndctl:ndctl-create-namespace[1]
diff --git a/Documentation/xable-namespace-options.txt b/Documentation/xable-namespace-options.txt
index a5c876180c91..cb24c2d61328 100644
--- a/Documentation/xable-namespace-options.txt
+++ b/Documentation/xable-namespace-options.txt
@@ -6,3 +6,7 @@ the operation on every namespace in the system, optionally filtered by region
 -r::
 --region=::
 include::xable-region-options.txt[]
+
+-v::
+--verbose::
+	Emit debug messages for the namespace operation
diff --git a/builtin-xaction-namespace.c b/builtin-xaction-namespace.c
index e2e6d518c64d..23b38ad0b73b 100644
--- a/builtin-xaction-namespace.c
+++ b/builtin-xaction-namespace.c
@@ -71,7 +71,8 @@ struct parsed_parameters {
 OPT_STRING('b', "bus", &param.bus, "bus-id", \
 	"limit namespace to a bus with an id or provider of <bus-id>"), \
 OPT_STRING('r', "region", &param.region, "region-id", \
-	"limit namespace to a region with an id or name of <region-id>")
+	"limit namespace to a region with an id or name of <region-id>"), \
+OPT_BOOLEAN('v', "verbose", &verbose, "emit extra debug messages to stderr")
 
 #define CREATE_OPTIONS() \
 OPT_STRING('e', "reconfig", &param.reconfig, "reconfig namespace", \
@@ -90,8 +91,7 @@ OPT_STRING('l', "sector-size", &param.sector_size, "lba-size", \
 	"specify the logical sector size in bytes"), \
 OPT_STRING('t', "type", &param.type, "type", \
 	"specify the type of namespace to create 'pmem' or 'blk'"), \
-OPT_BOOLEAN('f', "force", &force, "reconfigure namespace even if currently active"), \
-OPT_BOOLEAN('v', "verbose", &verbose, "emit extra debug messages to stderr")
+OPT_BOOLEAN('f', "force", &force, "reconfigure namespace even if currently active")
 
 static const struct option base_options[] = {
 	BASE_OPTIONS(),

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  parent reply	other threads:[~2016-04-22 19:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22 19:47 [ndctl PATCH 0/8] create-namespace fixes, and a misc build fix Dan Williams
2016-04-22 19:47 ` [ndctl PATCH 1/8] ndctl, create-namespace: make zero_info_block() more robust Dan Williams
2016-04-22 19:47 ` [ndctl PATCH 2/8] ndctl: new 'destroy-namespace' utility Dan Williams
2016-04-22 19:47 ` [ndctl PATCH 3/8] ndctl: fix build on systems where /bin/sh is not a link to bash Dan Williams
2016-04-22 19:47 ` [ndctl PATCH 4/8] ndctl, create-namespace: report failures due to namespace being mounted Dan Williams
2016-04-22 23:00   ` Linda Knippers
2016-04-22 23:10     ` Dan Williams
2016-04-22 19:47 ` Dan Williams [this message]
2016-04-22 19:47 ` [ndctl PATCH 6/8] ndctl, create-namespace: fix memmap location reconfiguration Dan Williams
2016-04-22 19:47 ` [ndctl PATCH 7/8] ndctl, create-namespace: fix sector mode default for pmem namespaces Dan Williams
2016-04-22 23:07   ` Linda Knippers
2016-04-22 19:47 ` [ndctl PATCH 8/8] ndctl, create-namespace: check for ZONE_DEVICE=n kernels Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=146135444838.4228.16562355726281815141.stgit@dwillia2-desk3.amr.corp.intel.com \
    --to=dan.j.williams@intel.com \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.