From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: hzpeterchen@gmail.com, Ulf Hansson <ulf.hansson@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-pm@vger.kernel.or, Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: [PATCH v3 10/12] EXAMPLE CODE: usb: hub: Power sequence the ports on activation
Date: Wed, 01 Jun 2016 10:02:19 +0200 [thread overview]
Message-ID: <1464768141-25420-11-git-send-email-k.kozlowski@samsung.com> (raw)
In-Reply-To: <1464768141-25420-1-git-send-email-k.kozlowski@samsung.com>
The autodetection of attached USB device might not work on certain
boards where the power is delivered externally. These devices also might
require a hard reset. Use pwrseq for that in USB hub.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/usb/core/hub.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index c421745b84aa..46d9f9aedacc 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -26,6 +26,7 @@
#include <linux/mutex.h>
#include <linux/random.h>
#include <linux/pm_qos.h>
+#include <linux/pwrseq.h>
#include <asm/uaccess.h>
#include <asm/byteorder.h>
@@ -1663,6 +1664,15 @@ static int hub_configure(struct usb_hub *hub,
usb_hub_adjust_deviceremovable(hdev, hub->descriptor);
+ /* FIXME: When do the pre-power-on? */
+ /*
+ for (i = 0; i < maxchild; i++)
+ pwrseq_pre_power_on(hub->ports[i]->pwrseq);
+ */
+
+ for (i = 0; i < maxchild; i++)
+ pwrseq_post_power_on(hub->ports[i]->pwrseq);
+
hub_activate(hub, HUB_INIT);
return 0;
--
1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 10/12] EXAMPLE CODE: usb: hub: Power sequence the ports on activation
Date: Wed, 01 Jun 2016 10:02:19 +0200 [thread overview]
Message-ID: <1464768141-25420-11-git-send-email-k.kozlowski@samsung.com> (raw)
In-Reply-To: <1464768141-25420-1-git-send-email-k.kozlowski@samsung.com>
The autodetection of attached USB device might not work on certain
boards where the power is delivered externally. These devices also might
require a hard reset. Use pwrseq for that in USB hub.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/usb/core/hub.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index c421745b84aa..46d9f9aedacc 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -26,6 +26,7 @@
#include <linux/mutex.h>
#include <linux/random.h>
#include <linux/pm_qos.h>
+#include <linux/pwrseq.h>
#include <asm/uaccess.h>
#include <asm/byteorder.h>
@@ -1663,6 +1664,15 @@ static int hub_configure(struct usb_hub *hub,
usb_hub_adjust_deviceremovable(hdev, hub->descriptor);
+ /* FIXME: When do the pre-power-on? */
+ /*
+ for (i = 0; i < maxchild; i++)
+ pwrseq_pre_power_on(hub->ports[i]->pwrseq);
+ */
+
+ for (i = 0; i < maxchild; i++)
+ pwrseq_post_power_on(hub->ports[i]->pwrseq);
+
hub_activate(hub, HUB_INIT);
return 0;
--
1.9.1
next prev parent reply other threads:[~2016-06-01 8:10 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 8:02 [PATCH v3 00/12] usb/mmc/power: Generic power sequence (and fix USB/LAN when TFTP booting) Krzysztof Kozlowski
2016-06-01 8:02 ` Krzysztof Kozlowski
2016-06-01 8:02 ` [PATCH v3 01/12] power/mmc: Move pwrseq drivers to power/pwrseq Krzysztof Kozlowski
2016-06-01 8:02 ` Krzysztof Kozlowski
2016-06-01 8:02 ` [PATCH v3 02/12] MAINTAINERS: Retain Ulf Hansson as the same maintainer of pwrseq Krzysztof Kozlowski
2016-06-01 8:02 ` Krzysztof Kozlowski
2016-06-01 8:02 ` [PATCH v3 03/12] power: pwrseq: Enable COMPILE_TEST for drivers Krzysztof Kozlowski
2016-06-01 8:02 ` Krzysztof Kozlowski
2016-06-01 8:02 ` [PATCH v3 04/12] power: pwrseq: Remove mmc prefix from mmc_pwrseq Krzysztof Kozlowski
2016-06-01 8:02 ` Krzysztof Kozlowski
2016-06-01 8:02 ` [PATCH v3 05/12] power: pwrseq: Generalize mmc_pwrseq operations by removing mmc prefix Krzysztof Kozlowski
2016-06-01 8:02 ` Krzysztof Kozlowski
2016-06-01 8:02 ` [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator and generic property Krzysztof Kozlowski
2016-06-01 8:02 ` Krzysztof Kozlowski
2016-06-03 2:02 ` Rob Herring
2016-06-03 2:02 ` Rob Herring
2016-06-03 12:35 ` Krzysztof Kozlowski
2016-06-03 12:35 ` Krzysztof Kozlowski
2016-06-06 3:22 ` Peter Chen
2016-06-06 3:22 ` Peter Chen
2016-06-07 9:29 ` Krzysztof Kozlowski
2016-06-07 9:29 ` Krzysztof Kozlowski
2016-06-07 9:29 ` Krzysztof Kozlowski
2016-06-08 19:03 ` Rob Herring
2016-06-08 19:03 ` Rob Herring
2016-06-09 2:34 ` Chen-Yu Tsai
2016-06-09 2:34 ` Chen-Yu Tsai
2016-06-09 2:34 ` Chen-Yu Tsai
2016-06-09 5:11 ` Krzysztof Kozlowski
2016-06-09 5:11 ` Krzysztof Kozlowski
2016-06-09 5:11 ` Krzysztof Kozlowski
2016-06-01 8:02 ` [PATCH v3 07/12] power: pwrseq: Add support for USB hubs with external power Krzysztof Kozlowski
2016-06-01 8:02 ` Krzysztof Kozlowski
2016-06-01 8:02 ` [PATCH v3 08/12] usb: hub: Handle deferred probe Krzysztof Kozlowski
2016-06-01 8:02 ` Krzysztof Kozlowski
2016-06-01 8:02 ` [PATCH v3 09/12] EXAMPLE CODE: usb: port: Parse pwrseq phandle from Device Tree Krzysztof Kozlowski
2016-06-01 8:02 ` Krzysztof Kozlowski
2016-06-01 8:57 ` Stephen Boyd
2016-06-01 8:57 ` Stephen Boyd
2016-06-01 8:57 ` Stephen Boyd
2016-06-01 9:06 ` Krzysztof Kozlowski
2016-06-01 9:06 ` Krzysztof Kozlowski
2016-06-01 12:05 ` Peter Chen
2016-06-01 12:05 ` Peter Chen
2016-06-01 18:16 ` Stephen Boyd
2016-06-01 18:16 ` Stephen Boyd
2016-06-02 1:24 ` Peter Chen
2016-06-02 1:24 ` Peter Chen
2016-06-02 23:59 ` Stephen Boyd
2016-06-02 23:59 ` Stephen Boyd
2016-06-01 8:02 ` Krzysztof Kozlowski [this message]
2016-06-01 8:02 ` [PATCH v3 10/12] EXAMPLE CODE: usb: hub: Power sequence the ports on activation Krzysztof Kozlowski
2016-06-01 8:02 ` [PATCH v3 11/12] ARM: dts: exynos: Switch the buck8 to GPIO mode on Odroid U3 Krzysztof Kozlowski
2016-06-01 8:02 ` Krzysztof Kozlowski
2016-06-01 8:02 ` [PATCH v3 12/12] ARM: dts: exynos: Fix LAN and HUB after bootloader initialization " Krzysztof Kozlowski
2016-06-01 8:02 ` Krzysztof Kozlowski
2016-06-01 11:59 ` Peter Chen
2016-06-01 11:59 ` Peter Chen
2016-06-02 7:26 ` Krzysztof Kozlowski
2016-06-02 7:26 ` Krzysztof Kozlowski
2016-06-02 7:58 ` Peter Chen
2016-06-02 7:58 ` Peter Chen
2016-06-06 20:43 ` [PATCH v3 00/12] usb/mmc/power: Generic power sequence (and fix USB/LAN when TFTP booting) Heiko Stübner
2016-06-06 20:43 ` Heiko Stübner
2016-06-07 6:03 ` Krzysztof Kozlowski
2016-06-07 6:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464768141-25420-11-git-send-email-k.kozlowski@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=hzpeterchen@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@vger.kernel.or \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.