From: Damien Le Moal <damien.lemoal@hgst.com> To: Jens Axboe <axboe@kernel.dk> Cc: <linux-block@vger.kernel.org>, <linux-scsi@vger.kernel.org>, Christoph Hellwig <hch@lst.de>, "Martin K . Petersen" <martin.petersen@oracle.com>, Hannes Reinecke <hare@suse.de>, Shaun Tancheff <shaun@tancheff.com>, Damien Le Moal <damien.lemoal@hgst.com> Subject: [PATCH v3 2/7] blk-sysfs: Add 'chunk_sectors' to sysfs attributes Date: Wed, 28 Sep 2016 10:22:32 +0900 [thread overview] Message-ID: <1475025757-6340-3-git-send-email-damien.lemoal@hgst.com> (raw) In-Reply-To: <1475025757-6340-1-git-send-email-damien.lemoal@hgst.com> From: Hannes Reinecke <hare@suse.de> The queue limits already have a 'chunk_sectors' setting, so we should be presenting it via sysfs. Signed-off-by: Hannes Reinecke <hare@suse.de> Signed-off-by: Damien Le Moal <damien.lemoal@hgst.com> --- block/blk-sysfs.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c index ff9cd9c..488c2e2 100644 --- a/block/blk-sysfs.c +++ b/block/blk-sysfs.c @@ -130,6 +130,11 @@ static ssize_t queue_physical_block_size_show(struct request_queue *q, char *pag return queue_var_show(queue_physical_block_size(q), page); } +static ssize_t queue_chunk_sectors_show(struct request_queue *q, char *page) +{ + return queue_var_show(q->limits.chunk_sectors, page); +} + static ssize_t queue_io_min_show(struct request_queue *q, char *page) { return queue_var_show(queue_io_min(q), page); @@ -455,6 +460,11 @@ static struct queue_sysfs_entry queue_physical_block_size_entry = { .show = queue_physical_block_size_show, }; +static struct queue_sysfs_entry queue_chunk_sectors_entry = { + .attr = {.name = "chunk_sectors", .mode = S_IRUGO }, + .show = queue_chunk_sectors_show, +}; + static struct queue_sysfs_entry queue_io_min_entry = { .attr = {.name = "minimum_io_size", .mode = S_IRUGO }, .show = queue_io_min_show, @@ -555,6 +565,7 @@ static struct attribute *default_attrs[] = { &queue_hw_sector_size_entry.attr, &queue_logical_block_size_entry.attr, &queue_physical_block_size_entry.attr, + &queue_chunk_sectors_entry.attr, &queue_io_min_entry.attr, &queue_io_opt_entry.attr, &queue_discard_granularity_entry.attr, -- 2.7.4 Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer: This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.
WARNING: multiple messages have this Message-ID (diff)
From: Damien Le Moal <damien.lemoal@hgst.com> To: Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, Christoph Hellwig <hch@lst.de>, "Martin K . Petersen" <martin.petersen@oracle.com>, Hannes Reinecke <hare@suse.de>, Shaun Tancheff <shaun@tancheff.com>, Damien Le Moal <damien.lemoal@hgst.com> Subject: [PATCH v3 2/7] blk-sysfs: Add 'chunk_sectors' to sysfs attributes Date: Wed, 28 Sep 2016 10:22:32 +0900 [thread overview] Message-ID: <1475025757-6340-3-git-send-email-damien.lemoal@hgst.com> (raw) In-Reply-To: <1475025757-6340-1-git-send-email-damien.lemoal@hgst.com> From: Hannes Reinecke <hare@suse.de> The queue limits already have a 'chunk_sectors' setting, so we should be presenting it via sysfs. Signed-off-by: Hannes Reinecke <hare@suse.de> Signed-off-by: Damien Le Moal <damien.lemoal@hgst.com> --- block/blk-sysfs.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c index ff9cd9c..488c2e2 100644 --- a/block/blk-sysfs.c +++ b/block/blk-sysfs.c @@ -130,6 +130,11 @@ static ssize_t queue_physical_block_size_show(struct request_queue *q, char *pag return queue_var_show(queue_physical_block_size(q), page); } +static ssize_t queue_chunk_sectors_show(struct request_queue *q, char *page) +{ + return queue_var_show(q->limits.chunk_sectors, page); +} + static ssize_t queue_io_min_show(struct request_queue *q, char *page) { return queue_var_show(queue_io_min(q), page); @@ -455,6 +460,11 @@ static struct queue_sysfs_entry queue_physical_block_size_entry = { .show = queue_physical_block_size_show, }; +static struct queue_sysfs_entry queue_chunk_sectors_entry = { + .attr = {.name = "chunk_sectors", .mode = S_IRUGO }, + .show = queue_chunk_sectors_show, +}; + static struct queue_sysfs_entry queue_io_min_entry = { .attr = {.name = "minimum_io_size", .mode = S_IRUGO }, .show = queue_io_min_show, @@ -555,6 +565,7 @@ static struct attribute *default_attrs[] = { &queue_hw_sector_size_entry.attr, &queue_logical_block_size_entry.attr, &queue_physical_block_size_entry.attr, + &queue_chunk_sectors_entry.attr, &queue_io_min_entry.attr, &queue_io_opt_entry.attr, &queue_discard_granularity_entry.attr, -- 2.7.4
next prev parent reply other threads:[~2016-09-28 1:22 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-28 1:22 [PATCH v3 0/7] ZBC / Zoned block device support Damien Le Moal 2016-09-28 1:22 ` Damien Le Moal 2016-09-28 1:22 ` [PATCH v3 1/7] block: Add 'zoned' queue limit Damien Le Moal 2016-09-28 1:22 ` Damien Le Moal 2016-09-28 3:42 ` Martin K. Petersen 2016-09-28 3:42 ` Martin K. Petersen 2016-09-28 1:22 ` Damien Le Moal [this message] 2016-09-28 1:22 ` [PATCH v3 2/7] blk-sysfs: Add 'chunk_sectors' to sysfs attributes Damien Le Moal 2016-09-28 3:43 ` Martin K. Petersen 2016-09-28 3:43 ` Martin K. Petersen 2016-09-28 1:22 ` [PATCH v3 3/7] block: update chunk_sectors in blk_stack_limits() Damien Le Moal 2016-09-28 1:22 ` Damien Le Moal 2016-09-28 3:44 ` Martin K. Petersen 2016-09-28 3:44 ` Martin K. Petersen 2016-09-28 1:22 ` [PATCH v3 4/7] block: Define zoned block device operations Damien Le Moal 2016-09-28 1:22 ` Damien Le Moal 2016-09-28 3:45 ` Martin K. Petersen 2016-09-28 3:45 ` Martin K. Petersen 2016-09-28 1:22 ` [PATCH v3 5/7] block: Implement support for zoned block devices Damien Le Moal 2016-09-28 1:22 ` Damien Le Moal 2016-09-28 3:54 ` Martin K. Petersen 2016-09-28 3:54 ` Martin K. Petersen 2016-09-28 4:21 ` Damien Le Moal 2016-09-28 4:21 ` Damien Le Moal 2016-09-28 5:05 ` Martin K. Petersen 2016-09-28 5:05 ` Martin K. Petersen 2016-09-28 1:22 ` [PATCH v3 6/7] sd: Implement support for ZBC devices Damien Le Moal 2016-09-28 1:22 ` Damien Le Moal 2016-09-28 5:01 ` Martin K. Petersen 2016-09-28 5:01 ` Martin K. Petersen 2016-09-28 1:22 ` [PATCH v3 7/7] blk-zoned: implement ioctls Damien Le Moal 2016-09-28 1:22 ` Damien Le Moal 2016-09-28 5:03 ` Martin K. Petersen 2016-09-28 5:03 ` Martin K. Petersen 2016-09-28 2:04 ` [PATCH v3 0/7] ZBC / Zoned block device support Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1475025757-6340-3-git-send-email-damien.lemoal@hgst.com \ --to=damien.lemoal@hgst.com \ --cc=axboe@kernel.dk \ --cc=hare@suse.de \ --cc=hch@lst.de \ --cc=linux-block@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=shaun@tancheff.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.