All of lore.kernel.org
 help / color / mirror / Atom feed
From: Deepa Dinamani <deepa.kernel@gmail.com>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: arnd@arndb.de, tglx@linutronix.de, gregkh@linuxfoundation.org,
	akpm@linux-foundation.org, tytso@mit.edu,
	viro@zeniv.linux.org.uk, y2038@lists.linaro.org
Subject: [RFC 1/6] vfs: Add file timestamp range support
Date: Wed,  2 Nov 2016 08:04:51 -0700	[thread overview]
Message-ID: <1478099096-25637-2-git-send-email-deepa.kernel@gmail.com> (raw)
In-Reply-To: <1478099096-25637-1-git-send-email-deepa.kernel@gmail.com>

Add fields to the superblock to track the min and max
timestamps supported by filesystems.

Initially, when a superblock is allocated, initialize
it to the max and min values the fields can hold.
Individual filesystems override these to match their
actual limits.

Pseudo filesystems are assumed to always support the
min and max allowable values for the fields.

Note that the time ranges are save in type time64_t
rather than time_t.
This is required because if we save ranges in time_t
then we would not be able to save timestamp ranges
for files that support timestamps beyond y2038.

Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
---
 fs/libfs.c             | 4 ++++
 fs/super.c             | 2 ++
 include/linux/fs.h     | 3 +++
 include/linux/time64.h | 2 ++
 4 files changed, 11 insertions(+)

diff --git a/fs/libfs.c b/fs/libfs.c
index 48826d4..f03c904 100644
--- a/fs/libfs.c
+++ b/fs/libfs.c
@@ -256,6 +256,8 @@ struct dentry *mount_pseudo_xattr(struct file_system_type *fs_type, char *name,
 	s->s_op = ops ? ops : &simple_super_operations;
 	s->s_xattr = xattr;
 	s->s_time_gran = 1;
+	s->s_time_min = TIME64_MIN;
+	s->s_time_max = TIME64_MAX;
 	root = new_inode(s);
 	if (!root)
 		goto Enomem;
@@ -515,6 +517,8 @@ int simple_fill_super(struct super_block *s, unsigned long magic,
 	s->s_magic = magic;
 	s->s_op = &simple_super_operations;
 	s->s_time_gran = 1;
+	s->s_time_min = TIME64_MIN;
+	s->s_time_max = TIME64_MAX;
 
 	inode = new_inode(s);
 	if (!inode)
diff --git a/fs/super.c b/fs/super.c
index c183835..27c973e 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -248,6 +248,8 @@ static struct super_block *alloc_super(struct file_system_type *type, int flags,
 	s->s_maxbytes = MAX_NON_LFS;
 	s->s_op = &default_op;
 	s->s_time_gran = 1000000000;
+	s->s_time_min = TIME64_MIN;
+	s->s_time_max = TIME64_MAX;
 	s->cleancache_poolid = CLEANCACHE_NO_POOL;
 
 	s->s_shrink.seeks = DEFAULT_SEEKS;
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 16d2b6e..6d1346b 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1380,6 +1380,9 @@ struct super_block {
 	/* Granularity of c/m/atime in ns.
 	   Cannot be worse than a second */
 	u32		   s_time_gran;
+	/* Time limits for c/m/atime in seconds. */
+	time64_t           s_time_min;
+	time64_t           s_time_max;
 
 	/*
 	 * The next field is for VFS *only*. No filesystems have any business
diff --git a/include/linux/time64.h b/include/linux/time64.h
index 980c71b..25433b18 100644
--- a/include/linux/time64.h
+++ b/include/linux/time64.h
@@ -38,6 +38,8 @@ struct itimerspec64 {
 
 /* Located here for timespec[64]_valid_strict */
 #define TIME64_MAX			((s64)~((u64)1 << 63))
+#define TIME64_MIN			(-TIME64_MAX - 1)
+
 #define KTIME_MAX			((s64)~((u64)1 << 63))
 #define KTIME_SEC_MAX			(KTIME_MAX / NSEC_PER_SEC)
 
-- 
2.7.4

  reply	other threads:[~2016-11-02 15:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-02 15:04 [RFC 0/6] vfs: Add timestamp range check support Deepa Dinamani
2016-11-02 15:04 ` Deepa Dinamani
2016-11-02 15:04 ` Deepa Dinamani [this message]
2016-11-02 15:04 ` [RFC 2/6] vfs: Add checks for filesystem timestamp limits Deepa Dinamani
2016-11-02 15:04 ` [RFC 3/6] afs: Add time limits in the super block Deepa Dinamani
2016-11-02 15:04 ` [RFC 4/6] ext4: Initialize timestamps limits Deepa Dinamani
2016-11-02 15:04   ` Deepa Dinamani
2016-11-02 15:04 ` [RFC 5/6] vfs: Add timestamp_truncate() api Deepa Dinamani
2016-11-02 15:04 ` [RFC 6/6] utimes: Clamp the timestamps before update Deepa Dinamani
2016-11-02 22:48 ` [RFC 0/6] vfs: Add timestamp range check support Dave Chinner
2016-11-03  6:54   ` Darrick J. Wong
2016-11-03 20:43   ` Theodore Ts'o
2016-11-03 20:43     ` Theodore Ts'o
2016-11-03 23:48     ` Dave Chinner
2016-11-03 23:48       ` Dave Chinner
2016-11-04  0:27     ` Andreas Dilger
2016-11-06 17:44       ` Deepa Dinamani
2016-11-06 20:28         ` Arnd Bergmann
2016-11-06 20:28           ` Arnd Bergmann
2016-11-06 21:14           ` Deepa Dinamani
2016-11-24  0:47 Deepa Dinamani
2016-11-24  0:47 ` [RFC 1/6] vfs: Add file timestamp range support Deepa Dinamani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478099096-25637-2-git-send-email-deepa.kernel@gmail.com \
    --to=deepa.kernel@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.