All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: "Pali Rohar" <pali.rohar@gmail.com>,
	"Javier Martinez Canillas" <javier@osg.samsung.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
	"Tony Lindgren" <tony@atomide.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	linux-omap@vger.kernel.org,
	"Russell King" <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/9] ARM: dts: omap4: Add an empty chosen node to top level DTSI
Date: Mon, 19 Dec 2016 11:44:35 -0300	[thread overview]
Message-ID: <1482158681-4530-4-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1482158681-4530-1-git-send-email-javier@osg.samsung.com>

Commit da6269e7e3dd ("ARM: dts: omap4: Remove skeleton.dtsi usage")
removed the skeleton.dtsi usage since we want to get rid of it.

But this can cause issues when booting a kernel with a boot-loader
that doesn't create a chosen node if this isn't present in the DTB
since the decompressor relies on a pre-existing chosen node to be
available to insert the command line and merge other ATAGS info.

Fixes: da6269e7e3dd ("ARM: dts: omap4: Remove skeleton.dtsi usage")
Reported-by: Pali Rohar <pali.rohar@gmail.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 arch/arm/boot/dts/omap4.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index 8087456b5fbe..578c53f08309 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -15,6 +15,7 @@
 	interrupt-parent = <&wakeupgen>;
 	#address-cells = <1>;
 	#size-cells = <1>;
+	chosen { };
 
 	aliases {
 		i2c0 = &i2c1;
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, "Tony Lindgren" <tony@atomide.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Javier Martinez Canillas" <javier@osg.samsung.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Pali Rohar" <pali.rohar@gmail.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/9] ARM: dts: omap4: Add an empty chosen node to top level DTSI
Date: Mon, 19 Dec 2016 11:44:35 -0300	[thread overview]
Message-ID: <1482158681-4530-4-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1482158681-4530-1-git-send-email-javier@osg.samsung.com>

Commit da6269e7e3dd ("ARM: dts: omap4: Remove skeleton.dtsi usage")
removed the skeleton.dtsi usage since we want to get rid of it.

But this can cause issues when booting a kernel with a boot-loader
that doesn't create a chosen node if this isn't present in the DTB
since the decompressor relies on a pre-existing chosen node to be
available to insert the command line and merge other ATAGS info.

Fixes: da6269e7e3dd ("ARM: dts: omap4: Remove skeleton.dtsi usage")
Reported-by: Pali Rohar <pali.rohar@gmail.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 arch/arm/boot/dts/omap4.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index 8087456b5fbe..578c53f08309 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -15,6 +15,7 @@
 	interrupt-parent = <&wakeupgen>;
 	#address-cells = <1>;
 	#size-cells = <1>;
+	chosen { };
 
 	aliases {
 		i2c0 = &i2c1;
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: javier@osg.samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/9] ARM: dts: omap4: Add an empty chosen node to top level DTSI
Date: Mon, 19 Dec 2016 11:44:35 -0300	[thread overview]
Message-ID: <1482158681-4530-4-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1482158681-4530-1-git-send-email-javier@osg.samsung.com>

Commit da6269e7e3dd ("ARM: dts: omap4: Remove skeleton.dtsi usage")
removed the skeleton.dtsi usage since we want to get rid of it.

But this can cause issues when booting a kernel with a boot-loader
that doesn't create a chosen node if this isn't present in the DTB
since the decompressor relies on a pre-existing chosen node to be
available to insert the command line and merge other ATAGS info.

Fixes: da6269e7e3dd ("ARM: dts: omap4: Remove skeleton.dtsi usage")
Reported-by: Pali Rohar <pali.rohar@gmail.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 arch/arm/boot/dts/omap4.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index 8087456b5fbe..578c53f08309 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -15,6 +15,7 @@
 	interrupt-parent = <&wakeupgen>;
 	#address-cells = <1>;
 	#size-cells = <1>;
+	chosen { };
 
 	aliases {
 		i2c0 = &i2c1;
-- 
2.7.4

  parent reply	other threads:[~2016-12-19 14:46 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-19 14:44 [PATCH 0/9] ARM: omap: Add empty chosen node in SoCs top level DTSI Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` [PATCH 1/9] ARM: dts: omap2: Add an empty chosen node to " Javier Martinez Canillas
2016-12-19 14:44   ` Javier Martinez Canillas
2016-12-19 14:44   ` Javier Martinez Canillas
2016-12-19 14:44 ` [PATCH 2/9] ARM: dts: omap3: " Javier Martinez Canillas
2016-12-19 14:44   ` Javier Martinez Canillas
2016-12-19 14:44   ` Javier Martinez Canillas
2017-01-02 18:01   ` Pali Rohár
2017-01-02 18:01     ` Pali Rohár
2017-01-02 18:01     ` Pali Rohár
2016-12-19 14:44 ` Javier Martinez Canillas [this message]
2016-12-19 14:44   ` [PATCH 3/9] ARM: dts: omap4: " Javier Martinez Canillas
2016-12-19 14:44   ` Javier Martinez Canillas
2016-12-19 14:44 ` [PATCH 4/9] ARM: dts: omap5: " Javier Martinez Canillas
2016-12-19 14:44   ` Javier Martinez Canillas
2016-12-19 14:44   ` Javier Martinez Canillas
2016-12-19 14:44 ` [PATCH 5/9] ARM: dts: am33xx: " Javier Martinez Canillas
2016-12-19 14:44   ` Javier Martinez Canillas
2016-12-19 14:44   ` Javier Martinez Canillas
2016-12-19 14:44 ` [PATCH 6/9] ARM: dts: am4372: " Javier Martinez Canillas
2016-12-19 14:44   ` Javier Martinez Canillas
2016-12-19 14:44   ` Javier Martinez Canillas
2016-12-19 14:44 ` [PATCH 7/9] ARM: dts: dm814x: " Javier Martinez Canillas
2016-12-19 14:44   ` Javier Martinez Canillas
2016-12-19 14:44   ` Javier Martinez Canillas
2016-12-19 14:44 ` [PATCH 8/9] ARM: dts: dm816x: " Javier Martinez Canillas
2016-12-19 14:44   ` Javier Martinez Canillas
2016-12-19 14:44   ` Javier Martinez Canillas
2016-12-19 14:44 ` [PATCH 9/9] ARM: dts: dra7: " Javier Martinez Canillas
2016-12-19 14:44   ` Javier Martinez Canillas
2016-12-19 14:44   ` Javier Martinez Canillas
2016-12-27 17:30 ` [PATCH 0/9] ARM: omap: Add empty chosen node in SoCs " Tony Lindgren
2016-12-27 17:30   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1482158681-4530-4-git-send-email-javier@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pali.rohar@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.