All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xen.org
Cc: linux-kernel@vger.kernel.org, sstabellini@kernel.org,
	jgross@suse.com, boris.ostrovsky@oracle.com,
	Stefano Stabellini <stefano@aporeto.com>
Subject: [PATCH v2 04/18] xen/pvcalls: xenbus state handling
Date: Fri, 19 May 2017 16:22:45 -0700	[thread overview]
Message-ID: <1495236179-27776-4-git-send-email-sstabellini@kernel.org> (raw)
In-Reply-To: <1495236179-27776-1-git-send-email-sstabellini@kernel.org>

Introduce the code to handle xenbus state changes.

Implement the probe function for the pvcalls backend. Write the
supported versions, max-page-order and function-calls nodes to xenstore,
as required by the protocol.

Introduce stub functions for disconnecting/connecting to a frontend.

Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
CC: boris.ostrovsky@oracle.com
CC: jgross@suse.com
---
 drivers/xen/pvcalls-back.c | 135 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 135 insertions(+)

diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index 9044cf2..b4da138 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -25,20 +25,155 @@
 #include <xen/xenbus.h>
 #include <xen/interface/io/pvcalls.h>
 
+#define PVCALLS_VERSIONS "1"
+#define MAX_RING_ORDER XENBUS_MAX_RING_GRANT_ORDER
+
 struct pvcalls_back_global {
 	struct list_head frontends;
 	struct semaphore frontends_lock;
 } pvcalls_back_global;
 
+static int backend_connect(struct xenbus_device *dev)
+{
+	return 0;
+}
+
+static int backend_disconnect(struct xenbus_device *dev)
+{
+	return 0;
+}
+
 static int pvcalls_back_probe(struct xenbus_device *dev,
 			      const struct xenbus_device_id *id)
 {
+	int err;
+
+	err = xenbus_printf(XBT_NIL, dev->nodename, "versions", "%s",
+			    PVCALLS_VERSIONS);
+	if (err) {
+		pr_warn("%s write out 'version' failed\n", __func__);
+		return -EINVAL;
+	}
+
+	err = xenbus_printf(XBT_NIL, dev->nodename, "max-page-order", "%u",
+			    MAX_RING_ORDER);
+	if (err) {
+		pr_warn("%s write out 'max-page-order' failed\n", __func__);
+		return err;
+	}
+
+	/* "1" means socket, connect, release, bind, listen, accept and poll*/
+	err = xenbus_printf(XBT_NIL, dev->nodename, "function-calls",
+			    XENBUS_FUNCTIONS_CALLS);
+	if (err) {
+		pr_warn("%s write out 'function-calls' failed\n", __func__);
+		return err;
+	}
+
+	err = xenbus_switch_state(dev, XenbusStateInitWait);
+	if (err)
+		return err;
+
 	return 0;
 }
 
+static void set_backend_state(struct xenbus_device *dev,
+			      enum xenbus_state state)
+{
+	while (dev->state != state) {
+		switch (dev->state) {
+		case XenbusStateClosed:
+			switch (state) {
+			case XenbusStateInitWait:
+			case XenbusStateConnected:
+				xenbus_switch_state(dev, XenbusStateInitWait);
+				break;
+			case XenbusStateClosing:
+				xenbus_switch_state(dev, XenbusStateClosing);
+				break;
+			default:
+				__WARN();
+			}
+			break;
+		case XenbusStateInitWait:
+		case XenbusStateInitialised:
+			switch (state) {
+			case XenbusStateConnected:
+				backend_connect(dev);
+				xenbus_switch_state(dev, XenbusStateConnected);
+				break;
+			case XenbusStateClosing:
+			case XenbusStateClosed:
+				xenbus_switch_state(dev, XenbusStateClosing);
+				break;
+			default:
+				__WARN();
+			}
+			break;
+		case XenbusStateConnected:
+			switch (state) {
+			case XenbusStateInitWait:
+			case XenbusStateClosing:
+			case XenbusStateClosed:
+				down(&pvcalls_back_global.frontends_lock);
+				backend_disconnect(dev);
+				up(&pvcalls_back_global.frontends_lock);
+				xenbus_switch_state(dev, XenbusStateClosing);
+				break;
+			default:
+				__WARN();
+			}
+			break;
+		case XenbusStateClosing:
+			switch (state) {
+			case XenbusStateInitWait:
+			case XenbusStateConnected:
+			case XenbusStateClosed:
+				xenbus_switch_state(dev, XenbusStateClosed);
+				break;
+			default:
+				__WARN();
+			}
+			break;
+		default:
+			__WARN();
+		}
+	}
+}
+
 static void pvcalls_back_changed(struct xenbus_device *dev,
 				 enum xenbus_state frontend_state)
 {
+	switch (frontend_state) {
+	case XenbusStateInitialising:
+		set_backend_state(dev, XenbusStateInitWait);
+		break;
+
+	case XenbusStateInitialised:
+	case XenbusStateConnected:
+		set_backend_state(dev, XenbusStateConnected);
+		break;
+
+	case XenbusStateClosing:
+		set_backend_state(dev, XenbusStateClosing);
+		break;
+
+	case XenbusStateClosed:
+		set_backend_state(dev, XenbusStateClosed);
+		if (xenbus_dev_is_online(dev))
+			break;
+		device_unregister(&dev->dev);
+		break;
+	case XenbusStateUnknown:
+		set_backend_state(dev, XenbusStateClosed);
+		device_unregister(&dev->dev);
+		break;
+
+	default:
+		xenbus_dev_fatal(dev, -EINVAL, "saw state %d at frontend",
+				 frontend_state);
+		break;
+	}
 }
 
 static int pvcalls_back_remove(struct xenbus_device *dev)
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xen.org
Cc: jgross@suse.com, Stefano Stabellini <stefano@aporeto.com>,
	boris.ostrovsky@oracle.com, sstabellini@kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 04/18] xen/pvcalls: xenbus state handling
Date: Fri, 19 May 2017 16:22:45 -0700	[thread overview]
Message-ID: <1495236179-27776-4-git-send-email-sstabellini@kernel.org> (raw)
In-Reply-To: <1495236179-27776-1-git-send-email-sstabellini@kernel.org>

Introduce the code to handle xenbus state changes.

Implement the probe function for the pvcalls backend. Write the
supported versions, max-page-order and function-calls nodes to xenstore,
as required by the protocol.

Introduce stub functions for disconnecting/connecting to a frontend.

Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
CC: boris.ostrovsky@oracle.com
CC: jgross@suse.com
---
 drivers/xen/pvcalls-back.c | 135 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 135 insertions(+)

diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index 9044cf2..b4da138 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -25,20 +25,155 @@
 #include <xen/xenbus.h>
 #include <xen/interface/io/pvcalls.h>
 
+#define PVCALLS_VERSIONS "1"
+#define MAX_RING_ORDER XENBUS_MAX_RING_GRANT_ORDER
+
 struct pvcalls_back_global {
 	struct list_head frontends;
 	struct semaphore frontends_lock;
 } pvcalls_back_global;
 
+static int backend_connect(struct xenbus_device *dev)
+{
+	return 0;
+}
+
+static int backend_disconnect(struct xenbus_device *dev)
+{
+	return 0;
+}
+
 static int pvcalls_back_probe(struct xenbus_device *dev,
 			      const struct xenbus_device_id *id)
 {
+	int err;
+
+	err = xenbus_printf(XBT_NIL, dev->nodename, "versions", "%s",
+			    PVCALLS_VERSIONS);
+	if (err) {
+		pr_warn("%s write out 'version' failed\n", __func__);
+		return -EINVAL;
+	}
+
+	err = xenbus_printf(XBT_NIL, dev->nodename, "max-page-order", "%u",
+			    MAX_RING_ORDER);
+	if (err) {
+		pr_warn("%s write out 'max-page-order' failed\n", __func__);
+		return err;
+	}
+
+	/* "1" means socket, connect, release, bind, listen, accept and poll*/
+	err = xenbus_printf(XBT_NIL, dev->nodename, "function-calls",
+			    XENBUS_FUNCTIONS_CALLS);
+	if (err) {
+		pr_warn("%s write out 'function-calls' failed\n", __func__);
+		return err;
+	}
+
+	err = xenbus_switch_state(dev, XenbusStateInitWait);
+	if (err)
+		return err;
+
 	return 0;
 }
 
+static void set_backend_state(struct xenbus_device *dev,
+			      enum xenbus_state state)
+{
+	while (dev->state != state) {
+		switch (dev->state) {
+		case XenbusStateClosed:
+			switch (state) {
+			case XenbusStateInitWait:
+			case XenbusStateConnected:
+				xenbus_switch_state(dev, XenbusStateInitWait);
+				break;
+			case XenbusStateClosing:
+				xenbus_switch_state(dev, XenbusStateClosing);
+				break;
+			default:
+				__WARN();
+			}
+			break;
+		case XenbusStateInitWait:
+		case XenbusStateInitialised:
+			switch (state) {
+			case XenbusStateConnected:
+				backend_connect(dev);
+				xenbus_switch_state(dev, XenbusStateConnected);
+				break;
+			case XenbusStateClosing:
+			case XenbusStateClosed:
+				xenbus_switch_state(dev, XenbusStateClosing);
+				break;
+			default:
+				__WARN();
+			}
+			break;
+		case XenbusStateConnected:
+			switch (state) {
+			case XenbusStateInitWait:
+			case XenbusStateClosing:
+			case XenbusStateClosed:
+				down(&pvcalls_back_global.frontends_lock);
+				backend_disconnect(dev);
+				up(&pvcalls_back_global.frontends_lock);
+				xenbus_switch_state(dev, XenbusStateClosing);
+				break;
+			default:
+				__WARN();
+			}
+			break;
+		case XenbusStateClosing:
+			switch (state) {
+			case XenbusStateInitWait:
+			case XenbusStateConnected:
+			case XenbusStateClosed:
+				xenbus_switch_state(dev, XenbusStateClosed);
+				break;
+			default:
+				__WARN();
+			}
+			break;
+		default:
+			__WARN();
+		}
+	}
+}
+
 static void pvcalls_back_changed(struct xenbus_device *dev,
 				 enum xenbus_state frontend_state)
 {
+	switch (frontend_state) {
+	case XenbusStateInitialising:
+		set_backend_state(dev, XenbusStateInitWait);
+		break;
+
+	case XenbusStateInitialised:
+	case XenbusStateConnected:
+		set_backend_state(dev, XenbusStateConnected);
+		break;
+
+	case XenbusStateClosing:
+		set_backend_state(dev, XenbusStateClosing);
+		break;
+
+	case XenbusStateClosed:
+		set_backend_state(dev, XenbusStateClosed);
+		if (xenbus_dev_is_online(dev))
+			break;
+		device_unregister(&dev->dev);
+		break;
+	case XenbusStateUnknown:
+		set_backend_state(dev, XenbusStateClosed);
+		device_unregister(&dev->dev);
+		break;
+
+	default:
+		xenbus_dev_fatal(dev, -EINVAL, "saw state %d at frontend",
+				 frontend_state);
+		break;
+	}
 }
 
 static int pvcalls_back_remove(struct xenbus_device *dev)
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-05-19 23:26 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-19 23:17 [PATCH v2 00/18] introduce the Xen PV Calls backend Stefano Stabellini
2017-05-19 23:22 ` [PATCH v2 01/18] xen: introduce the pvcalls interface header Stefano Stabellini
2017-05-19 23:22   ` Stefano Stabellini
2017-05-19 23:22   ` [PATCH v2 02/18] xen/pvcalls: introduce the pvcalls xenbus backend Stefano Stabellini
2017-05-25 22:04     ` Boris Ostrovsky
2017-05-25 22:04     ` Boris Ostrovsky
2017-05-19 23:22   ` Stefano Stabellini
2017-05-19 23:22   ` [PATCH v2 03/18] xen/pvcalls: initialize the module and register the " Stefano Stabellini
2017-05-19 23:22   ` Stefano Stabellini
2017-05-25 22:12     ` Boris Ostrovsky
2017-05-25 22:12       ` Boris Ostrovsky
2017-05-19 23:22   ` Stefano Stabellini [this message]
2017-05-19 23:22     ` [PATCH v2 04/18] xen/pvcalls: xenbus state handling Stefano Stabellini
2017-05-26  0:12     ` Boris Ostrovsky
2017-05-26  0:12       ` Boris Ostrovsky
2017-06-01 20:54       ` Stefano Stabellini
2017-06-01 20:54       ` Stefano Stabellini
2017-05-19 23:22   ` [PATCH v2 05/18] xen/pvcalls: connect to a frontend Stefano Stabellini
2017-05-19 23:22     ` Stefano Stabellini
2017-05-26 15:23     ` Boris Ostrovsky
2017-05-26 15:23     ` Boris Ostrovsky
2017-06-01 21:06       ` Stefano Stabellini
2017-06-01 21:06       ` Stefano Stabellini
2017-05-19 23:22   ` [PATCH v2 06/18] xen/pvcalls: handle commands from the frontend Stefano Stabellini
2017-05-19 23:22     ` Stefano Stabellini
2017-05-26 15:32     ` Boris Ostrovsky
2017-05-26 15:32     ` Boris Ostrovsky
2017-06-02 18:21       ` Stefano Stabellini
2017-06-02 18:21       ` Stefano Stabellini
2017-05-19 23:22   ` [PATCH v2 07/18] xen/pvcalls: implement socket command Stefano Stabellini
2017-05-19 23:22     ` Stefano Stabellini
2017-05-26 15:53     ` Boris Ostrovsky
2017-05-26 15:53     ` Boris Ostrovsky
2017-06-02 18:35       ` Stefano Stabellini
2017-06-02 18:35       ` Stefano Stabellini
2017-05-26 18:58     ` Boris Ostrovsky
2017-05-26 18:58     ` Boris Ostrovsky
2017-06-02 18:41       ` Stefano Stabellini
2017-06-02 18:41       ` Stefano Stabellini
2017-05-19 23:22   ` [PATCH v2 08/18] xen/pvcalls: implement connect command Stefano Stabellini
2017-05-19 23:22     ` Stefano Stabellini
2017-05-19 23:22   ` [PATCH v2 09/18] xen/pvcalls: implement bind command Stefano Stabellini
2017-05-19 23:22     ` Stefano Stabellini
2017-05-19 23:22   ` [PATCH v2 10/18] xen/pvcalls: implement listen command Stefano Stabellini
2017-05-19 23:22     ` Stefano Stabellini
2017-05-19 23:22   ` [PATCH v2 11/18] xen/pvcalls: implement accept command Stefano Stabellini
2017-05-19 23:22     ` Stefano Stabellini
2017-05-26 18:18     ` Boris Ostrovsky
2017-05-26 18:18     ` Boris Ostrovsky
2017-06-02 19:19       ` Stefano Stabellini
2017-06-02 19:19       ` Stefano Stabellini
2017-05-19 23:22   ` [PATCH v2 12/18] xen/pvcalls: implement poll command Stefano Stabellini
2017-05-19 23:22     ` Stefano Stabellini
2017-05-19 23:22   ` [PATCH v2 13/18] xen/pvcalls: implement release command Stefano Stabellini
2017-05-19 23:22   ` Stefano Stabellini
2017-05-19 23:22   ` [PATCH v2 14/18] xen/pvcalls: disconnect and module_exit Stefano Stabellini
2017-05-19 23:22   ` Stefano Stabellini
2017-05-19 23:22   ` [PATCH v2 15/18] xen/pvcalls: implement the ioworker functions Stefano Stabellini
2017-05-19 23:22     ` Stefano Stabellini
2017-05-19 23:22   ` [PATCH v2 16/18] xen/pvcalls: implement read Stefano Stabellini
2017-05-19 23:22   ` Stefano Stabellini
2017-05-19 23:22   ` [PATCH v2 17/18] xen/pvcalls: implement write Stefano Stabellini
2017-05-19 23:22   ` Stefano Stabellini
2017-05-19 23:22   ` [PATCH v2 18/18] xen: introduce a Kconfig option to enable the pvcalls backend Stefano Stabellini
2017-05-19 23:22     ` Stefano Stabellini
2017-05-25 22:02   ` [PATCH v2 01/18] xen: introduce the pvcalls interface header Boris Ostrovsky
2017-06-01 20:54     ` Stefano Stabellini
2017-06-01 20:54     ` Stefano Stabellini
2017-05-25 22:02   ` Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495236179-27776-4-git-send-email-sstabellini@kernel.org \
    --to=sstabellini@kernel.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefano@aporeto.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.