All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <Julia.Lawall@lip6.fr>
To: Michael Turquette <mturquette@baylibre.com>
Cc: keescook@chromium.org, kernel-janitors@vger.kernel.org,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 02/11] clk: moxart: Drop unnecessary static
Date: Sat, 15 Jul 2017 22:07:37 +0200	[thread overview]
Message-ID: <1500149266-32357-3-git-send-email-Julia.Lawall@lip6.fr> (raw)
In-Reply-To: <1500149266-32357-1-git-send-email-Julia.Lawall@lip6.fr>

Drop static on a local variable, when the variable is initialized before
any possible use.  Thus, the static has no benefit.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@
static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@
-static
 T x@p;
 ... when != x
     when strict
?x = e;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
These patches are all independent of each other.

 drivers/clk/clk-moxart.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff -u -p a/drivers/clk/clk-moxart.c b/drivers/clk/clk-moxart.c
--- a/drivers/clk/clk-moxart.c
+++ b/drivers/clk/clk-moxart.c
@@ -18,7 +18,7 @@
 
 static void __init moxart_of_pll_clk_init(struct device_node *node)
 {
-	static void __iomem *base;
+	void __iomem *base;
 	struct clk_hw *hw;
 	struct clk *ref_clk;
 	unsigned int mul;
@@ -57,7 +57,7 @@ CLK_OF_DECLARE(moxart_pll_clock, "moxa,m
 
 static void __init moxart_of_apb_clk_init(struct device_node *node)
 {
-	static void __iomem *base;
+	void __iomem *base;
 	struct clk_hw *hw;
 	struct clk *pll_clk;
 	unsigned int div, val;

WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <Julia.Lawall@lip6.fr>
To: Michael Turquette <mturquette@baylibre.com>
Cc: keescook@chromium.org, kernel-janitors@vger.kernel.org,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 02/11] clk: moxart: Drop unnecessary static
Date: Sat, 15 Jul 2017 20:07:37 +0000	[thread overview]
Message-ID: <1500149266-32357-3-git-send-email-Julia.Lawall@lip6.fr> (raw)
In-Reply-To: <1500149266-32357-1-git-send-email-Julia.Lawall@lip6.fr>

Drop static on a local variable, when the variable is initialized before
any possible use.  Thus, the static has no benefit.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@
static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@
-static
 T x@p;
 ... when != x
     when strict
?x = e;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
These patches are all independent of each other.

 drivers/clk/clk-moxart.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff -u -p a/drivers/clk/clk-moxart.c b/drivers/clk/clk-moxart.c
--- a/drivers/clk/clk-moxart.c
+++ b/drivers/clk/clk-moxart.c
@@ -18,7 +18,7 @@
 
 static void __init moxart_of_pll_clk_init(struct device_node *node)
 {
-	static void __iomem *base;
+	void __iomem *base;
 	struct clk_hw *hw;
 	struct clk *ref_clk;
 	unsigned int mul;
@@ -57,7 +57,7 @@ CLK_OF_DECLARE(moxart_pll_clock, "moxa,m
 
 static void __init moxart_of_apb_clk_init(struct device_node *node)
 {
-	static void __iomem *base;
+	void __iomem *base;
 	struct clk_hw *hw;
 	struct clk *pll_clk;
 	unsigned int div, val;


  parent reply	other threads:[~2017-07-15 20:32 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-15 20:07 [PATCH 00/11] Drop unnecessary static Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-15 20:07 ` Julia Lawall
2017-07-15 20:07 ` [PATCH 01/11] clk: mmp: " Julia Lawall
2017-07-15 20:07   ` Julia Lawall
2017-07-18  1:31   ` Stephen Boyd
2017-07-18  1:31     ` Stephen Boyd
2017-07-15 20:07 ` Julia Lawall [this message]
2017-07-15 20:07   ` [PATCH 02/11] clk: moxart: " Julia Lawall
2017-07-18  1:31   ` Stephen Boyd
2017-07-18  1:31     ` Stephen Boyd
2017-07-15 20:07 ` [PATCH 03/11] mtd: physmap_of: " Julia Lawall
2017-07-15 20:07   ` Julia Lawall
2017-07-17 19:58   ` Boris Brezillon
2017-07-17 19:58     ` Boris Brezillon
2017-08-17 12:58   ` Boris Brezillon
2017-08-17 12:58     ` Boris Brezillon
2017-07-15 20:07 ` [PATCH 04/11] fbdev: da8xx-fb: " Julia Lawall
2017-07-15 20:07   ` Julia Lawall
2017-08-01 13:09   ` Bartlomiej Zolnierkiewicz
2017-08-01 13:09     ` Bartlomiej Zolnierkiewicz
2017-07-15 20:07 ` [PATCH 05/11] irqchip/gic/realview: " Julia Lawall
2017-07-15 20:07   ` Julia Lawall
2017-07-18 20:06   ` [tip:irq/urgent] " tip-bot for Julia Lawall
2017-07-15 20:07 ` [PATCH 06/11] irqchip: mips-cpu: " Julia Lawall
2017-07-15 20:07   ` Julia Lawall
2017-07-15 20:52   ` Mark D Rustad
2017-07-15 20:52     ` Mark D Rustad
2017-07-15 20:59     ` Julia Lawall
2017-07-15 20:59       ` Julia Lawall
2017-07-16  6:04       ` Mark D Rustad
2017-07-16  6:04         ` Mark D Rustad
2017-07-18 20:07   ` [tip:irq/urgent] irqchip/mips-cpu: " tip-bot for Julia Lawall
2017-07-15 20:07 ` [PATCH 07/11] mfd: " Julia Lawall
2017-07-15 20:07   ` Julia Lawall
2017-07-15 20:49   ` Mark D Rustad
2017-07-15 20:49     ` Mark D Rustad
2017-07-15 20:56     ` Julia Lawall
2017-07-15 20:56       ` Julia Lawall
2017-07-24 19:20       ` Pavel Machek
2017-07-24 19:20         ` Pavel Machek
2017-07-24 22:27         ` Kees Cook
2017-07-24 22:27           ` Kees Cook
2017-07-25  8:00   ` Lee Jones
2017-07-25  8:00     ` Lee Jones
2017-07-15 20:07 ` [PATCH 08/11] ata: " Julia Lawall
2017-07-15 20:07   ` Julia Lawall
2017-08-02  8:23   ` Linus Walleij
2017-08-02  8:23     ` Linus Walleij
2017-08-02 15:12   ` Tejun Heo
2017-08-02 15:12     ` Tejun Heo
2017-07-15 20:07 ` [PATCH 09/11] iio: orientation: hid-sensor-rotation: " Julia Lawall
2017-07-15 20:07   ` Julia Lawall
2017-07-17 20:45   ` Jonathan Cameron
2017-07-17 20:45     ` Jonathan Cameron
2017-07-15 20:07 ` [PATCH 10/11] irqchip: digicolor: " Julia Lawall
2017-07-15 20:07   ` Julia Lawall
2017-07-15 20:07   ` Julia Lawall
2017-07-16  4:49   ` Baruch Siach
2017-07-16  4:49     ` Baruch Siach
2017-07-16  4:49     ` Baruch Siach
2017-07-18 20:07   ` [tip:irq/urgent] irqchip/digicolor: " tip-bot for Julia Lawall
2017-07-15 20:07 ` [PATCH 11/11] mfd: max8925-i2c: " Julia Lawall
2017-07-15 20:07   ` Julia Lawall
2017-07-18  7:23   ` Lee Jones
2017-07-18  7:23     ` Lee Jones
2017-07-15 20:37 ` [PATCH 00/11] " Joe Perches
2017-07-15 20:37   ` Joe Perches
2017-07-15 20:37   ` Joe Perches
2017-07-15 21:00   ` Julia Lawall
2017-07-15 21:00     ` Julia Lawall
2017-07-15 21:00     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500149266-32357-3-git-send-email-Julia.Lawall@lip6.fr \
    --to=julia.lawall@lip6.fr \
    --cc=keescook@chromium.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.