All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Javier González" <jg@lightnvm.io>
To: mb@lightnvm.io, axboe@fb.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Javier González" <javier@cnexlabs.com>,
	"Matias Bjørling" <matias@cnexlabs.com>
Subject: [PATCH 1/6] lightnvm: pblk: check for failed mempool alloc.
Date: Wed,  6 Sep 2017 17:01:01 +0200	[thread overview]
Message-ID: <1504710066-4699-2-git-send-email-javier@cnexlabs.com> (raw)
In-Reply-To: <1504710066-4699-1-git-send-email-javier@cnexlabs.com>

Check for failed mempool allocations and act accordingly.

Signed-off-by: Javier González <javier@cnexlabs.com>
Signed-off-by: Matias Bjørling <matias@cnexlabs.com>
---
 drivers/lightnvm/pblk-core.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index 81501644fb15..acb07bbcb416 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -165,6 +165,8 @@ struct nvm_rq *pblk_alloc_rqd(struct pblk *pblk, int rw)
 	}
 
 	rqd = mempool_alloc(pool, GFP_KERNEL);
+	if (!rqd)
+		return NULL;
 	memset(rqd, 0, rq_size);
 
 	return rqd;
@@ -1478,6 +1480,8 @@ int pblk_blk_erase_async(struct pblk *pblk, struct ppa_addr ppa)
 	int err;
 
 	rqd = mempool_alloc(pblk->g_rq_pool, GFP_KERNEL);
+	if (!rqd)
+		return -ENOMEM;
 	memset(rqd, 0, pblk_g_rq_size);
 
 	pblk_setup_e_rq(pblk, rqd, ppa);
-- 
2.7.4

  reply	other threads:[~2017-09-06 15:01 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-06 15:01 [PATCH 0/6] lightnvm: pblk bug fixes for 4.14 Javier González
2017-09-06 15:01 ` Javier González [this message]
2017-09-06 15:08   ` [PATCH 1/6] lightnvm: pblk: check for failed mempool alloc Johannes Thumshirn
2017-09-06 15:08     ` Johannes Thumshirn
2017-09-06 15:09     ` Jens Axboe
2017-09-06 15:12       ` Javier González
2017-09-06 15:13         ` Jens Axboe
2017-09-06 15:14           ` Javier González
2017-09-06 15:20           ` Jens Axboe
2017-09-06 18:28             ` Javier González
2017-09-06 15:12       ` Johannes Thumshirn
2017-09-06 15:12         ` Johannes Thumshirn
2017-09-06 15:01 ` [PATCH 2/6] lightnvm: pblk: initialize debug stat counter Javier González
2017-09-06 15:15   ` Johannes Thumshirn
2017-09-06 15:15     ` Johannes Thumshirn
2017-09-06 15:01 ` [PATCH 3/6] lightnvm: pblk: use right flag for GC allocation Javier González
2017-09-06 15:19   ` Johannes Thumshirn
2017-09-06 15:19     ` Johannes Thumshirn
2017-09-06 15:01 ` [PATCH 4/6] lightnvm: pblk: free padded entries in write buffer Javier González
2017-09-06 15:22   ` Johannes Thumshirn
2017-09-06 15:22     ` Johannes Thumshirn
2017-09-06 15:01 ` [PATCH 5/6] lightnvm: pblk: fix write I/O sync stat Javier González
2017-09-06 15:23   ` Johannes Thumshirn
2017-09-06 15:23     ` Johannes Thumshirn
2017-09-06 15:01 ` [PATCH 6/6] lightnvm: pblk: avoid deadlock on low LUN config Javier González

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504710066-4699-2-git-send-email-javier@cnexlabs.com \
    --to=jg@lightnvm.io \
    --cc=axboe@fb.com \
    --cc=javier@cnexlabs.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matias@cnexlabs.com \
    --cc=mb@lightnvm.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.