From: <yintang@qti.qualcomm.com> To: <ath10k@lists.infradead.org> Cc: <linux-wireless@vger.kernel.org> Subject: [PATCH V6 4/5] ath10k: Avoid to set WEP key for TDLS peer Date: Mon, 16 Oct 2017 14:00:32 +0800 [thread overview] Message-ID: <1508133633-23214-5-git-send-email-yintang@qti.qualcomm.com> (raw) In-Reply-To: <1508133633-23214-1-git-send-email-yintang@qti.qualcomm.com> From: Yingying Tang <yintang@qti.qualcomm.com> TDLS peer do not need WEP key. Setting WEP key will lead to TDLS setup failure. Add fix to avoid setting WEP key for TDLS peer. Signed-off-by: Yingying Tang <yintang@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 1672043..a984a72 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -2966,7 +2966,7 @@ static int ath10k_station_assoc(struct ath10k *ar, } /* Plumb cached keys only for static WEP */ - if (arvif->def_wep_key_idx != -1) { + if ((arvif->def_wep_key_idx != -1) && (!sta->tdls)) { ret = ath10k_install_peer_wep_keys(arvif, sta->addr); if (ret) { ath10k_warn(ar, "failed to install peer wep keys for vdev %i: %d\n", -- 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: <yintang@qti.qualcomm.com> To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Subject: [PATCH V6 4/5] ath10k: Avoid to set WEP key for TDLS peer Date: Mon, 16 Oct 2017 14:00:32 +0800 [thread overview] Message-ID: <1508133633-23214-5-git-send-email-yintang@qti.qualcomm.com> (raw) In-Reply-To: <1508133633-23214-1-git-send-email-yintang@qti.qualcomm.com> From: Yingying Tang <yintang@qti.qualcomm.com> TDLS peer do not need WEP key. Setting WEP key will lead to TDLS setup failure. Add fix to avoid setting WEP key for TDLS peer. Signed-off-by: Yingying Tang <yintang@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 1672043..a984a72 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -2966,7 +2966,7 @@ static int ath10k_station_assoc(struct ath10k *ar, } /* Plumb cached keys only for static WEP */ - if (arvif->def_wep_key_idx != -1) { + if ((arvif->def_wep_key_idx != -1) && (!sta->tdls)) { ret = ath10k_install_peer_wep_keys(arvif, sta->addr); if (ret) { ath10k_warn(ar, "failed to install peer wep keys for vdev %i: %d\n", -- 1.7.9.5 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2017-10-16 5:58 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <TDLS for ath10k patches V6> 2017-10-16 6:00 ` [PATCH V6 0/5] Add TDLS feature for ath10k yintang 2017-10-16 6:00 ` yintang 2017-10-16 6:00 ` [PATCH V6 1/5] mac80211: Enable TDLS peer buffer STA feature yintang 2017-10-16 6:00 ` yintang 2017-10-18 10:35 ` Johannes Berg 2017-10-18 10:35 ` Johannes Berg 2017-10-20 3:34 ` Yingying Tang 2017-10-20 3:34 ` Yingying Tang 2017-10-23 6:29 ` Johannes Berg 2017-10-23 6:29 ` Johannes Berg 2017-10-16 6:00 ` [PATCH V6 2/5] ath10k: " yintang 2017-10-16 6:00 ` yintang 2017-10-16 6:00 ` [PATCH V6 3/5] ath10k: Enable TDLS peer inactivity detection yintang 2017-10-16 6:00 ` yintang 2017-10-16 6:00 ` yintang [this message] 2017-10-16 6:00 ` [PATCH V6 4/5] ath10k: Avoid to set WEP key for TDLS peer yintang 2017-10-18 23:37 ` [PATCH V6 0/5] Add TDLS feature for ath10k Peter Oh 2017-10-18 23:37 ` Peter Oh 2017-10-16 6:01 ` [PATCH V6 5/5] ath10k: Fix TDLS peer TX data failure issue on encryped AP yintang 2017-10-16 6:01 ` yintang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1508133633-23214-5-git-send-email-yintang@qti.qualcomm.com \ --to=yintang@qti.qualcomm.com \ --cc=ath10k@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.