From: Dan Williams <dan.j.williams@intel.com> To: akpm@linux-foundation.org Cc: jack@suse.cz, linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@lst.de Subject: [PATCH v4 08/18] tools/testing/nvdimm: add 'bio_delay' mechanism Date: Sat, 23 Dec 2017 16:56:43 -0800 [thread overview] Message-ID: <151407700353.38751.17609507477918854876.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) In-Reply-To: <151407695916.38751.2866053440557472361.stgit@dwillia2-desk3.amr.corp.intel.com> In support of testing truncate colliding with dma add a mechanism that delays the completion of block I/O requests by a programmable number of seconds. This allows a truncate operation to be issued while page references are held for direct-I/O. Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- tools/testing/nvdimm/Kbuild | 1 + tools/testing/nvdimm/test/iomap.c | 62 +++++++++++++++++++++++++++++++++ tools/testing/nvdimm/test/nfit.c | 34 ++++++++++++++++++ tools/testing/nvdimm/test/nfit_test.h | 1 + 4 files changed, 98 insertions(+) diff --git a/tools/testing/nvdimm/Kbuild b/tools/testing/nvdimm/Kbuild index db33b28c5ef3..afc070c961cd 100644 --- a/tools/testing/nvdimm/Kbuild +++ b/tools/testing/nvdimm/Kbuild @@ -16,6 +16,7 @@ ldflags-y += --wrap=insert_resource ldflags-y += --wrap=remove_resource ldflags-y += --wrap=acpi_evaluate_object ldflags-y += --wrap=acpi_evaluate_dsm +ldflags-y += --wrap=bio_endio DRIVERS := ../../../drivers NVDIMM_SRC := $(DRIVERS)/nvdimm diff --git a/tools/testing/nvdimm/test/iomap.c b/tools/testing/nvdimm/test/iomap.c index ff9d3a5825e1..dd90060c0004 100644 --- a/tools/testing/nvdimm/test/iomap.c +++ b/tools/testing/nvdimm/test/iomap.c @@ -10,6 +10,7 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. */ +#include <linux/workqueue.h> #include <linux/memremap.h> #include <linux/rculist.h> #include <linux/export.h> @@ -18,6 +19,7 @@ #include <linux/types.h> #include <linux/pfn_t.h> #include <linux/acpi.h> +#include <linux/bio.h> #include <linux/io.h> #include <linux/mm.h> #include "nfit_test.h" @@ -387,4 +389,64 @@ union acpi_object * __wrap_acpi_evaluate_dsm(acpi_handle handle, const guid_t *g } EXPORT_SYMBOL(__wrap_acpi_evaluate_dsm); +static DEFINE_SPINLOCK(bio_lock); +static struct bio *biolist; +int bio_do_queue; + +static void run_bio(struct work_struct *work) +{ + struct delayed_work *dw = container_of(work, typeof(*dw), work); + struct bio *bio, *next; + + pr_info("%s\n", __func__); + spin_lock(&bio_lock); + bio_do_queue = 0; + bio = biolist; + biolist = NULL; + spin_unlock(&bio_lock); + + while (bio) { + next = bio->bi_next; + bio->bi_next = NULL; + bio_endio(bio); + bio = next; + } + kfree(dw); +} + +void nfit_test_inject_bio_delay(int sec) +{ + struct delayed_work *dw = kzalloc(sizeof(*dw), GFP_KERNEL); + + spin_lock(&bio_lock); + if (!bio_do_queue) { + pr_info("%s: %d seconds\n", __func__, sec); + INIT_DELAYED_WORK(dw, run_bio); + bio_do_queue = 1; + schedule_delayed_work(dw, sec * HZ); + dw = NULL; + } + spin_unlock(&bio_lock); +} +EXPORT_SYMBOL_GPL(nfit_test_inject_bio_delay); + +void __wrap_bio_endio(struct bio *bio) +{ + int did_q = 0; + + spin_lock(&bio_lock); + if (bio_do_queue) { + bio->bi_next = biolist; + biolist = bio; + did_q = 1; + } + spin_unlock(&bio_lock); + + if (did_q) + return; + + bio_endio(bio); +} +EXPORT_SYMBOL_GPL(__wrap_bio_endio); + MODULE_LICENSE("GPL v2"); diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c index 7217b2b953b5..9362b01e9a8f 100644 --- a/tools/testing/nvdimm/test/nfit.c +++ b/tools/testing/nvdimm/test/nfit.c @@ -872,6 +872,39 @@ static const struct attribute_group *nfit_test_dimm_attribute_groups[] = { NULL, }; +static ssize_t bio_delay_show(struct device_driver *drv, char *buf) +{ + return sprintf(buf, "0\n"); +} + +static ssize_t bio_delay_store(struct device_driver *drv, const char *buf, + size_t count) +{ + unsigned long delay; + int rc = kstrtoul(buf, 0, &delay); + + if (rc < 0) + return rc; + + nfit_test_inject_bio_delay(delay); + return count; +} +DRIVER_ATTR_RW(bio_delay); + +static struct attribute *nfit_test_driver_attributes[] = { + &driver_attr_bio_delay.attr, + NULL, +}; + +static struct attribute_group nfit_test_driver_attribute_group = { + .attrs = nfit_test_driver_attributes, +}; + +static const struct attribute_group *nfit_test_driver_attribute_groups[] = { + &nfit_test_driver_attribute_group, + NULL, +}; + static int nfit_test0_alloc(struct nfit_test *t) { size_t nfit_size = sizeof(struct acpi_nfit_system_address) * NUM_SPA @@ -2151,6 +2184,7 @@ static struct platform_driver nfit_test_driver = { .remove = nfit_test_remove, .driver = { .name = KBUILD_MODNAME, + .groups = nfit_test_driver_attribute_groups, }, .id_table = nfit_test_id, }; diff --git a/tools/testing/nvdimm/test/nfit_test.h b/tools/testing/nvdimm/test/nfit_test.h index 113b44675a71..744740a76dee 100644 --- a/tools/testing/nvdimm/test/nfit_test.h +++ b/tools/testing/nvdimm/test/nfit_test.h @@ -98,4 +98,5 @@ void nfit_test_setup(nfit_test_lookup_fn lookup, nfit_test_evaluate_dsm_fn evaluate); void nfit_test_teardown(void); struct nfit_test_resource *get_nfit_res(resource_size_t resource); +void nfit_test_inject_bio_delay(int sec); #endif _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com> To: akpm@linux-foundation.org Cc: jack@suse.cz, linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, ross.zwisler@linux.intel.com, hch@lst.de Subject: [PATCH v4 08/18] tools/testing/nvdimm: add 'bio_delay' mechanism Date: Sat, 23 Dec 2017 16:56:43 -0800 [thread overview] Message-ID: <151407700353.38751.17609507477918854876.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) In-Reply-To: <151407695916.38751.2866053440557472361.stgit@dwillia2-desk3.amr.corp.intel.com> In support of testing truncate colliding with dma add a mechanism that delays the completion of block I/O requests by a programmable number of seconds. This allows a truncate operation to be issued while page references are held for direct-I/O. Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- tools/testing/nvdimm/Kbuild | 1 + tools/testing/nvdimm/test/iomap.c | 62 +++++++++++++++++++++++++++++++++ tools/testing/nvdimm/test/nfit.c | 34 ++++++++++++++++++ tools/testing/nvdimm/test/nfit_test.h | 1 + 4 files changed, 98 insertions(+) diff --git a/tools/testing/nvdimm/Kbuild b/tools/testing/nvdimm/Kbuild index db33b28c5ef3..afc070c961cd 100644 --- a/tools/testing/nvdimm/Kbuild +++ b/tools/testing/nvdimm/Kbuild @@ -16,6 +16,7 @@ ldflags-y += --wrap=insert_resource ldflags-y += --wrap=remove_resource ldflags-y += --wrap=acpi_evaluate_object ldflags-y += --wrap=acpi_evaluate_dsm +ldflags-y += --wrap=bio_endio DRIVERS := ../../../drivers NVDIMM_SRC := $(DRIVERS)/nvdimm diff --git a/tools/testing/nvdimm/test/iomap.c b/tools/testing/nvdimm/test/iomap.c index ff9d3a5825e1..dd90060c0004 100644 --- a/tools/testing/nvdimm/test/iomap.c +++ b/tools/testing/nvdimm/test/iomap.c @@ -10,6 +10,7 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. */ +#include <linux/workqueue.h> #include <linux/memremap.h> #include <linux/rculist.h> #include <linux/export.h> @@ -18,6 +19,7 @@ #include <linux/types.h> #include <linux/pfn_t.h> #include <linux/acpi.h> +#include <linux/bio.h> #include <linux/io.h> #include <linux/mm.h> #include "nfit_test.h" @@ -387,4 +389,64 @@ union acpi_object * __wrap_acpi_evaluate_dsm(acpi_handle handle, const guid_t *g } EXPORT_SYMBOL(__wrap_acpi_evaluate_dsm); +static DEFINE_SPINLOCK(bio_lock); +static struct bio *biolist; +int bio_do_queue; + +static void run_bio(struct work_struct *work) +{ + struct delayed_work *dw = container_of(work, typeof(*dw), work); + struct bio *bio, *next; + + pr_info("%s\n", __func__); + spin_lock(&bio_lock); + bio_do_queue = 0; + bio = biolist; + biolist = NULL; + spin_unlock(&bio_lock); + + while (bio) { + next = bio->bi_next; + bio->bi_next = NULL; + bio_endio(bio); + bio = next; + } + kfree(dw); +} + +void nfit_test_inject_bio_delay(int sec) +{ + struct delayed_work *dw = kzalloc(sizeof(*dw), GFP_KERNEL); + + spin_lock(&bio_lock); + if (!bio_do_queue) { + pr_info("%s: %d seconds\n", __func__, sec); + INIT_DELAYED_WORK(dw, run_bio); + bio_do_queue = 1; + schedule_delayed_work(dw, sec * HZ); + dw = NULL; + } + spin_unlock(&bio_lock); +} +EXPORT_SYMBOL_GPL(nfit_test_inject_bio_delay); + +void __wrap_bio_endio(struct bio *bio) +{ + int did_q = 0; + + spin_lock(&bio_lock); + if (bio_do_queue) { + bio->bi_next = biolist; + biolist = bio; + did_q = 1; + } + spin_unlock(&bio_lock); + + if (did_q) + return; + + bio_endio(bio); +} +EXPORT_SYMBOL_GPL(__wrap_bio_endio); + MODULE_LICENSE("GPL v2"); diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c index 7217b2b953b5..9362b01e9a8f 100644 --- a/tools/testing/nvdimm/test/nfit.c +++ b/tools/testing/nvdimm/test/nfit.c @@ -872,6 +872,39 @@ static const struct attribute_group *nfit_test_dimm_attribute_groups[] = { NULL, }; +static ssize_t bio_delay_show(struct device_driver *drv, char *buf) +{ + return sprintf(buf, "0\n"); +} + +static ssize_t bio_delay_store(struct device_driver *drv, const char *buf, + size_t count) +{ + unsigned long delay; + int rc = kstrtoul(buf, 0, &delay); + + if (rc < 0) + return rc; + + nfit_test_inject_bio_delay(delay); + return count; +} +DRIVER_ATTR_RW(bio_delay); + +static struct attribute *nfit_test_driver_attributes[] = { + &driver_attr_bio_delay.attr, + NULL, +}; + +static struct attribute_group nfit_test_driver_attribute_group = { + .attrs = nfit_test_driver_attributes, +}; + +static const struct attribute_group *nfit_test_driver_attribute_groups[] = { + &nfit_test_driver_attribute_group, + NULL, +}; + static int nfit_test0_alloc(struct nfit_test *t) { size_t nfit_size = sizeof(struct acpi_nfit_system_address) * NUM_SPA @@ -2151,6 +2184,7 @@ static struct platform_driver nfit_test_driver = { .remove = nfit_test_remove, .driver = { .name = KBUILD_MODNAME, + .groups = nfit_test_driver_attribute_groups, }, .id_table = nfit_test_id, }; diff --git a/tools/testing/nvdimm/test/nfit_test.h b/tools/testing/nvdimm/test/nfit_test.h index 113b44675a71..744740a76dee 100644 --- a/tools/testing/nvdimm/test/nfit_test.h +++ b/tools/testing/nvdimm/test/nfit_test.h @@ -98,4 +98,5 @@ void nfit_test_setup(nfit_test_lookup_fn lookup, nfit_test_evaluate_dsm_fn evaluate); void nfit_test_teardown(void); struct nfit_test_resource *get_nfit_res(resource_size_t resource); +void nfit_test_inject_bio_delay(int sec); #endif
next prev parent reply other threads:[~2017-12-24 1:00 UTC|newest] Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-24 0:56 [PATCH v4 00/18] dax: fix dma vs truncate/hole-punch Dan Williams 2017-12-24 0:56 ` Dan Williams 2017-12-24 0:56 ` Dan Williams 2017-12-24 0:56 ` [PATCH v4 01/18] mm, dax: introduce pfn_t_special() Dan Williams 2017-12-24 0:56 ` Dan Williams 2018-01-04 8:16 ` Christoph Hellwig 2018-01-04 8:16 ` Christoph Hellwig 2017-12-24 0:56 ` [PATCH v4 02/18] ext4: auto disable dax instead of failing mount Dan Williams 2017-12-24 0:56 ` Dan Williams 2018-01-03 14:20 ` Jan Kara 2018-01-03 14:20 ` Jan Kara 2017-12-24 0:56 ` [PATCH v4 03/18] ext2: " Dan Williams 2017-12-24 0:56 ` Dan Williams 2018-01-03 14:21 ` Jan Kara 2018-01-03 14:21 ` Jan Kara 2017-12-24 0:56 ` [PATCH v4 04/18] dax: require 'struct page' by default for filesystem dax Dan Williams 2017-12-24 0:56 ` Dan Williams 2018-01-03 15:29 ` Jan Kara 2018-01-03 15:29 ` Jan Kara 2018-01-04 8:16 ` Christoph Hellwig 2018-01-04 8:16 ` Christoph Hellwig 2018-01-08 11:58 ` Gerald Schaefer 2018-01-08 11:58 ` Gerald Schaefer 2017-12-24 0:56 ` [PATCH v4 05/18] dax: stop using VM_MIXEDMAP for dax Dan Williams 2017-12-24 0:56 ` Dan Williams 2018-01-03 15:27 ` Jan Kara 2018-01-03 15:27 ` Jan Kara 2017-12-24 0:56 ` [PATCH v4 06/18] dax: stop using VM_HUGEPAGE " Dan Williams 2017-12-24 0:56 ` Dan Williams 2017-12-24 0:56 ` [PATCH v4 07/18] dax: store pfns in the radix Dan Williams 2017-12-24 0:56 ` Dan Williams 2017-12-27 0:17 ` Ross Zwisler 2017-12-27 0:17 ` Ross Zwisler 2018-01-02 20:15 ` Dan Williams 2018-01-02 20:15 ` Dan Williams 2018-01-03 15:39 ` Jan Kara 2018-01-03 15:39 ` Jan Kara 2017-12-24 0:56 ` Dan Williams [this message] 2017-12-24 0:56 ` [PATCH v4 08/18] tools/testing/nvdimm: add 'bio_delay' mechanism Dan Williams 2017-12-27 18:08 ` Ross Zwisler 2017-12-27 18:08 ` Ross Zwisler 2018-01-02 20:35 ` Dan Williams 2018-01-02 20:35 ` Dan Williams 2018-01-02 21:44 ` Dave Chinner 2018-01-02 21:44 ` Dave Chinner 2018-01-02 21:51 ` Dan Williams 2018-01-02 21:51 ` Dan Williams 2018-01-03 15:46 ` Jan Kara 2018-01-03 15:46 ` Jan Kara 2018-01-03 20:37 ` Jeff Moyer 2018-01-03 20:37 ` Jeff Moyer 2017-12-24 0:56 ` [PATCH v4 09/18] mm, dax: enable filesystems to trigger dev_pagemap ->page_free callbacks Dan Williams 2017-12-24 0:56 ` Dan Williams 2018-01-04 8:20 ` Christoph Hellwig 2018-01-04 8:20 ` Christoph Hellwig 2017-12-24 0:56 ` [PATCH v4 10/18] mm, dev_pagemap: introduce CONFIG_DEV_PAGEMAP_OPS Dan Williams 2017-12-24 0:56 ` Dan Williams 2018-01-04 8:25 ` Christoph Hellwig 2018-01-04 8:25 ` Christoph Hellwig 2017-12-24 0:56 ` [PATCH v4 11/18] fs, dax: introduce DEFINE_FSDAX_AOPS Dan Williams 2017-12-24 0:56 ` Dan Williams 2017-12-27 5:29 ` Matthew Wilcox 2017-12-27 5:29 ` Matthew Wilcox 2018-01-02 20:21 ` Dan Williams 2018-01-02 20:21 ` Dan Williams 2018-01-03 16:05 ` Jan Kara 2018-01-03 16:05 ` Jan Kara 2018-01-04 8:27 ` Christoph Hellwig 2018-01-04 8:27 ` Christoph Hellwig 2018-01-02 21:41 ` Dave Chinner 2018-01-02 21:41 ` Dave Chinner 2017-12-24 0:57 ` [PATCH v4 12/18] xfs: use DEFINE_FSDAX_AOPS Dan Williams 2017-12-24 0:57 ` Dan Williams 2018-01-02 21:15 ` Darrick J. Wong 2018-01-02 21:15 ` Darrick J. Wong 2018-01-02 21:40 ` Dan Williams 2018-01-02 21:40 ` Dan Williams 2018-01-03 16:09 ` Jan Kara 2018-01-03 16:09 ` Jan Kara 2018-01-04 8:28 ` Christoph Hellwig 2018-01-04 8:28 ` Christoph Hellwig 2017-12-24 0:57 ` [PATCH v4 13/18] ext4: " Dan Williams 2017-12-24 0:57 ` Dan Williams 2017-12-24 0:57 ` Dan Williams 2018-01-04 8:29 ` Christoph Hellwig 2018-01-04 8:29 ` Christoph Hellwig 2018-01-04 8:29 ` Christoph Hellwig 2017-12-24 0:57 ` [PATCH v4 14/18] ext2: " Dan Williams 2017-12-24 0:57 ` Dan Williams 2018-01-04 8:29 ` Christoph Hellwig 2018-01-04 8:29 ` Christoph Hellwig 2017-12-24 0:57 ` [PATCH v4 15/18] mm, fs, dax: use page->mapping to warn if dma collides with truncate Dan Williams 2017-12-24 0:57 ` Dan Williams 2018-01-04 8:30 ` Christoph Hellwig 2018-01-04 8:30 ` Christoph Hellwig 2018-01-04 9:39 ` Jan Kara 2018-01-04 9:39 ` Jan Kara 2017-12-24 0:57 ` [PATCH v4 16/18] wait_bit: introduce {wait_on,wake_up}_atomic_one Dan Williams 2017-12-24 0:57 ` Dan Williams 2018-01-04 8:30 ` Christoph Hellwig 2018-01-04 8:30 ` Christoph Hellwig 2017-12-24 0:57 ` [PATCH v4 17/18] mm, fs, dax: dax_flush_dma, handle dma vs block-map-change collisions Dan Williams 2017-12-24 0:57 ` Dan Williams 2018-01-04 8:31 ` Christoph Hellwig 2018-01-04 8:31 ` Christoph Hellwig 2018-01-04 11:12 ` Jan Kara 2018-01-04 11:12 ` Jan Kara 2018-01-07 21:58 ` Dan Williams 2018-01-07 21:58 ` Dan Williams 2018-01-08 13:50 ` Jan Kara 2018-01-08 13:50 ` Jan Kara 2018-03-08 17:02 ` Dan Williams 2018-03-08 17:02 ` Dan Williams 2018-03-09 12:56 ` Jan Kara 2018-03-09 12:56 ` Jan Kara 2018-03-09 16:15 ` Dan Williams 2018-03-09 16:15 ` Dan Williams 2018-03-09 17:26 ` Dan Williams 2018-03-09 17:26 ` Dan Williams 2017-12-24 0:57 ` [PATCH v4 18/18] xfs, dax: wire up dax_flush_dma support via a new xfs_sync_dma helper Dan Williams 2017-12-24 0:57 ` Dan Williams 2018-01-02 21:07 ` Darrick J. Wong 2018-01-02 21:07 ` Darrick J. Wong 2018-01-02 23:00 ` Dave Chinner 2018-01-02 23:00 ` Dave Chinner 2018-01-03 2:21 ` Dan Williams 2018-01-03 2:21 ` Dan Williams 2018-01-03 7:51 ` Dave Chinner 2018-01-03 7:51 ` Dave Chinner 2018-01-04 8:34 ` Christoph Hellwig 2018-01-04 8:34 ` Christoph Hellwig 2018-01-04 8:33 ` Christoph Hellwig 2018-01-04 8:33 ` Christoph Hellwig 2018-01-04 8:17 ` [PATCH v4 00/18] dax: fix dma vs truncate/hole-punch Christoph Hellwig 2018-01-04 8:17 ` Christoph Hellwig 2018-01-04 8:17 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=151407700353.38751.17609507477918854876.stgit@dwillia2-desk3.amr.corp.intel.com \ --to=dan.j.williams@intel.com \ --cc=akpm@linux-foundation.org \ --cc=hch@lst.de \ --cc=jack@suse.cz \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=linux-xfs@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.