All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oscar Mateo <oscar.mateo@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 20/22] drm/i915/icl: Wa_1406838659
Date: Fri,  6 Apr 2018 15:25:16 -0700	[thread overview]
Message-ID: <1523053518-20827-20-git-send-email-oscar.mateo@intel.com> (raw)
In-Reply-To: <1523053518-20827-1-git-send-email-oscar.mateo@intel.com>

Disable CGPSF unit clock gating to prevent an issue.

Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h | 13 ++++++++-----
 drivers/gpu/drm/i915/intel_pm.c |  6 ++++++
 2 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 84e5a59..af4fee2 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -3823,15 +3823,18 @@ enum {
  * GEN10 clock gating regs
  */
 #define SLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x94d4)
-#define  SARBUNIT_CLKGATE_DIS		(1 << 5)
-#define  RCCUNIT_CLKGATE_DIS		(1 << 7)
-#define  MSCUNIT_CLKGATE_DIS		(1 << 10)
+#define   SARBUNIT_CLKGATE_DIS		(1 << 5)
+#define   RCCUNIT_CLKGATE_DIS		(1 << 7)
+#define   MSCUNIT_CLKGATE_DIS		(1 << 10)
 
 #define SUBSLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x9524)
-#define  GWUNIT_CLKGATE_DIS		(1 << 16)
+#define   GWUNIT_CLKGATE_DIS		(1 << 16)
 
 #define UNSLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x9434)
-#define  VFUNIT_CLKGATE_DIS		(1 << 20)
+#define   VFUNIT_CLKGATE_DIS		(1 << 20)
+
+#define INF_UNIT_LEVEL_CLKGATE		_MMIO(0x9560)
+#define   CGPSF_CLKGATE_DIS		(1 << 3)
 
 /*
  * Display engine regs
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 9771f56..1acc719 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -8575,6 +8575,12 @@ static void icl_init_clock_gating(struct drm_i915_private *dev_priv)
 	I915_WRITE(GEN10_L3_CHICKEN_MODE_REGISTER,
 		   (I915_READ(GEN10_L3_CHICKEN_MODE_REGISTER) |
 		    GEN11_I2M_WRITE_DISABLE));
+
+	/* Wa_1406838659:icl (pre-prod) */
+	if (IS_ICL_REVID(dev_priv, ICL_REVID_A0, ICL_REVID_C0))
+		I915_WRITE(INF_UNIT_LEVEL_CLKGATE,
+			   (I915_READ(INF_UNIT_LEVEL_CLKGATE) |
+			    CGPSF_CLKGATE_DIS));
 }
 
 static void cnl_init_clock_gating(struct drm_i915_private *dev_priv)
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-04-06 22:25 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06 22:24 [PATCH 01/22] drm/i915/icl: Introduce initial Icelake Workarounds Oscar Mateo
2018-04-06 22:24 ` [PATCH 02/22] drm/i915/icl: WaGAPZPriorityScheme Oscar Mateo
2018-04-06 22:24 ` [PATCH 03/22] drm/i915/icl: WaModifyGamTlbPartitioning Oscar Mateo
2018-04-06 22:25 ` [PATCH 04/22] drm/i915/icl: WaL3BankAddressHashing Oscar Mateo
2018-04-06 22:25 ` [PATCH 05/22] drm/i915/icl: WaDisableCleanEvicts Oscar Mateo
2018-04-06 22:25 ` [PATCH 06/22] drm/i915/icl: WaDisableImprovedTdlClkGating Oscar Mateo
2018-04-06 22:25 ` [PATCH 07/22] drm/i915/icl: WaCL2SFHalfMaxAlloc Oscar Mateo
2018-04-06 22:25 ` [PATCH 08/22] drm/i915/icl: WaDisCtxReload Oscar Mateo
2018-04-06 22:25 ` [PATCH 09/22] drm/i915/icl: WaSendPushConstantsFromMMIO Oscar Mateo
2018-04-06 22:25 ` [PATCH 10/22] drm/i915/icl: WaAllowUMDToModifyHalfSliceChicken2 Oscar Mateo
2018-04-06 22:25 ` [PATCH 11/22] drm/i915/icl: WaAllowUMDToModifyHalfSliceChicken7 Oscar Mateo
2018-04-06 22:25 ` [PATCH 12/22] drm/i915/icl: WaAllowUmdWriteTRTTRootTable Oscar Mateo
2018-04-06 22:25 ` [PATCH 13/22] drm/i915/icl: WaAllowUMDToModifySamplerMode Oscar Mateo
2018-04-06 22:25 ` [PATCH 14/22] drm/i915/icl: WaEnableStateCacheRedirectToCS Oscar Mateo
2018-04-06 22:25 ` [PATCH 15/22] drm/i915/icl: Enable Sampler DFR Oscar Mateo
2018-04-06 22:25 ` [PATCH 16/22] drm/i915/icl: Wa_1405779004 Oscar Mateo
2018-04-06 22:25 ` [PATCH 17/22] drm/i915/icl: Wa_1406680159 and Wa_2201832410 Oscar Mateo
2018-04-06 22:25 ` [PATCH 18/22] drm/i915/icl: Wa_1604302699 Oscar Mateo
2018-04-06 22:25 ` [PATCH 19/22] drm/i915/icl: Wa_2006665173 Oscar Mateo
2018-04-06 22:25 ` Oscar Mateo [this message]
2018-04-06 22:25 ` [PATCH 21/22] drm/i915/icl: WaForwardProgressSoftReset Oscar Mateo
2018-04-06 22:25 ` [PATCH 22/22] drm/i915/icl: WaEnableFloatBlendOptimization Oscar Mateo
2018-04-06 22:43 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/22] drm/i915/icl: Introduce initial Icelake Workarounds Patchwork
2018-04-06 22:58 ` ✓ Fi.CI.BAT: success " Patchwork
2018-04-07  4:34 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-04-09 19:53 ` [PATCH 01/22] " Chris Wilson
2018-04-09 21:33   ` Oscar Mateo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1523053518-20827-20-git-send-email-oscar.mateo@intel.com \
    --to=oscar.mateo@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.