From: Dan Williams <dan.j.williams@intel.com> To: akpm@linux-foundation.org Cc: "Christoph Hellwig" <hch@lst.de>, "Jérôme Glisse" <jglisse@redhat.com>, "Logan Gunthorpe" <logang@deltatee.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] mm, hmm: mark hmm_devmem_{add, add_resource} EXPORT_SYMBOL_GPL Date: Mon, 21 May 2018 15:35:40 -0700 [thread overview] Message-ID: <152694214044.5484.1081005408496303826.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) In-Reply-To: <152694211402.5484.2277538346144115181.stgit@dwillia2-desk3.amr.corp.intel.com> The routines hmm_devmem_add(), and hmm_devmem_add_resource() are small wrappers around devm_memremap_pages(). The devm_memremap_pages() interface is a subset of the hmm functionality which has more and deeper ties into the kernel memory management implementation. It was an oversight that these symbols were not marked EXPORT_SYMBOL_GPL from the outset due to how they originally copied (and now reuse) devm_memremap_pages(). Cc: Christoph Hellwig <hch@lst.de> Cc: "Jérôme Glisse" <jglisse@redhat.com> Cc: Logan Gunthorpe <logang@deltatee.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- mm/hmm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index a4162406067c..d9aef1266ed6 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -1072,7 +1072,7 @@ struct hmm_devmem *hmm_devmem_add(const struct hmm_devmem_ops *ops, return devmem; } -EXPORT_SYMBOL(hmm_devmem_add); +EXPORT_SYMBOL_GPL(hmm_devmem_add); struct hmm_devmem *hmm_devmem_add_resource(const struct hmm_devmem_ops *ops, struct device *device, @@ -1131,7 +1131,7 @@ struct hmm_devmem *hmm_devmem_add_resource(const struct hmm_devmem_ops *ops, return devmem; } -EXPORT_SYMBOL(hmm_devmem_add_resource); +EXPORT_SYMBOL_GPL(hmm_devmem_add_resource); /* * A device driver that wants to handle multiple devices memory through a
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com> To: akpm@linux-foundation.org Cc: "Christoph Hellwig" <hch@lst.de>, "Jérôme Glisse" <jglisse@redhat.com>, "Logan Gunthorpe" <logang@deltatee.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] mm, hmm: mark hmm_devmem_{add, add_resource} EXPORT_SYMBOL_GPL Date: Mon, 21 May 2018 15:35:40 -0700 [thread overview] Message-ID: <152694214044.5484.1081005408496303826.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) In-Reply-To: <152694211402.5484.2277538346144115181.stgit@dwillia2-desk3.amr.corp.intel.com> The routines hmm_devmem_add(), and hmm_devmem_add_resource() are small wrappers around devm_memremap_pages(). The devm_memremap_pages() interface is a subset of the hmm functionality which has more and deeper ties into the kernel memory management implementation. It was an oversight that these symbols were not marked EXPORT_SYMBOL_GPL from the outset due to how they originally copied (and now reuse) devm_memremap_pages(). Cc: Christoph Hellwig <hch@lst.de> Cc: "JA(C)rA'me Glisse" <jglisse@redhat.com> Cc: Logan Gunthorpe <logang@deltatee.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- mm/hmm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index a4162406067c..d9aef1266ed6 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -1072,7 +1072,7 @@ struct hmm_devmem *hmm_devmem_add(const struct hmm_devmem_ops *ops, return devmem; } -EXPORT_SYMBOL(hmm_devmem_add); +EXPORT_SYMBOL_GPL(hmm_devmem_add); struct hmm_devmem *hmm_devmem_add_resource(const struct hmm_devmem_ops *ops, struct device *device, @@ -1131,7 +1131,7 @@ struct hmm_devmem *hmm_devmem_add_resource(const struct hmm_devmem_ops *ops, return devmem; } -EXPORT_SYMBOL(hmm_devmem_add_resource); +EXPORT_SYMBOL_GPL(hmm_devmem_add_resource); /* * A device driver that wants to handle multiple devices memory through a
next prev parent reply other threads:[~2018-05-21 22:45 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-21 22:35 [PATCH 0/5] mm: rework hmm to use devm_memremap_pages Dan Williams 2018-05-21 22:35 ` [PATCH 1/5] mm, devm_memremap_pages: mark devm_memremap_pages() EXPORT_SYMBOL_GPL Dan Williams 2018-05-21 22:35 ` Dan Williams 2018-05-22 6:29 ` Christoph Hellwig 2018-05-21 22:35 ` [PATCH 2/5] mm, devm_memremap_pages: handle errors allocating final devres action Dan Williams 2018-05-21 22:35 ` Dan Williams 2018-05-21 23:10 ` Andrew Morton 2018-05-22 0:07 ` Dan Williams 2018-05-22 16:42 ` Logan Gunthorpe 2018-05-22 16:56 ` Dan Williams 2018-05-22 17:03 ` Logan Gunthorpe 2018-05-22 17:25 ` Dan Williams 2018-05-22 17:36 ` Logan Gunthorpe 2018-05-22 6:30 ` Christoph Hellwig 2018-05-21 22:35 ` [PATCH 3/5] mm, hmm: use devm semantics for hmm_devmem_{add, remove} Dan Williams 2018-05-21 22:35 ` Dan Williams 2018-05-22 6:30 ` Christoph Hellwig 2018-05-21 22:35 ` [PATCH 4/5] mm, hmm: replace hmm_devmem_pages_create() with devm_memremap_pages() Dan Williams 2018-05-21 22:35 ` Dan Williams 2018-05-22 6:31 ` Christoph Hellwig 2018-05-22 17:13 ` Logan Gunthorpe 2018-05-22 21:38 ` Dan Williams 2018-05-21 22:35 ` Dan Williams [this message] 2018-05-21 22:35 ` [PATCH 5/5] mm, hmm: mark hmm_devmem_{add, add_resource} EXPORT_SYMBOL_GPL Dan Williams 2018-05-22 6:32 ` Christoph Hellwig 2018-05-22 21:31 ` Andrew Morton 2018-06-05 18:24 ` Jerome Glisse 2018-06-05 18:24 ` Jerome Glisse 2018-05-24 0:10 ` [PATCH 0/5] mm: rework hmm to use devm_memremap_pages Jerome Glisse 2018-05-24 3:18 ` Dan Williams 2018-05-24 6:35 ` Christoph Hellwig 2018-05-29 22:22 ` Dave Airlie 2018-05-29 22:31 ` Dan Williams 2018-05-29 23:00 ` Dave Airlie 2018-05-29 23:33 ` Dan Williams 2018-06-05 18:48 ` Jerome Glisse 2018-06-05 18:48 ` Jerome Glisse 2018-06-05 22:19 ` Dave Airlie 2018-06-05 23:06 ` Dan Williams 2018-06-06 0:08 ` Jerome Glisse 2018-06-06 0:08 ` Jerome Glisse 2018-06-06 1:33 ` Dan Williams 2018-06-06 7:14 ` Christoph Hellwig 2018-06-07 14:16 ` Jerome Glisse 2018-06-07 14:16 ` Jerome Glisse 2018-06-07 18:39 ` Dan Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=152694214044.5484.1081005408496303826.stgit@dwillia2-desk3.amr.corp.intel.com \ --to=dan.j.williams@intel.com \ --cc=akpm@linux-foundation.org \ --cc=hch@lst.de \ --cc=jglisse@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=logang@deltatee.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.