From: "Michal Vokáč" <michal.vokac@ysoft.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Shawn Guo <shawnguo@kernel.org>
Cc: "Fabio Estevam" <fabio.estevam@nxp.com>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org,
"Michal Vokáč" <michal.vokac@ysoft.com>
Subject: [RESEND PATCH v2 2/3] video: ssd1307fb: Do not hard code active-low reset sequence
Date: Thu, 27 Sep 2018 11:24:40 +0200 [thread overview]
Message-ID: <1538040281-21319-2-git-send-email-michal.vokac@ysoft.com> (raw)
In-Reply-To: <1538040281-21319-1-git-send-email-michal.vokac@ysoft.com>
The SSD130x OLED display reset signal is active low. Now the reset
sequence is implemented in such a way that users are forced to
define reset-gpios as GPIO_ACTIVE_HIGH in DT to make the reset work.
Do not hard code the active-low sequence into the driver but instead
allow the user to specify the gpio as GPIO_ACTIVE_LOW to reflect
the real world.
Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
---
v2 changes: Split the DT changes into separate patch.
drivers/video/fbdev/ssd1307fb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index e7ae135..7b5bc42 100644
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -728,10 +728,10 @@ static int ssd1307fb_probe(struct i2c_client *client,
if (par->reset) {
/* Reset the screen */
- gpiod_set_value_cansleep(par->reset, 0);
- udelay(4);
gpiod_set_value_cansleep(par->reset, 1);
udelay(4);
+ gpiod_set_value_cansleep(par->reset, 0);
+ udelay(4);
}
if (par->vbat_reg) {
--
2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: "Michal Vokáč" <michal.vokac@ysoft.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Shawn Guo <shawnguo@kernel.org>
Cc: "Fabio Estevam" <fabio.estevam@nxp.com>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org,
"Michal Vokáč" <michal.vokac@ysoft.com>
Subject: [RESEND PATCH v2 2/3] video: ssd1307fb: Do not hard code active-low reset sequence
Date: Thu, 27 Sep 2018 09:24:40 +0000 [thread overview]
Message-ID: <1538040281-21319-2-git-send-email-michal.vokac@ysoft.com> (raw)
In-Reply-To: <1538040281-21319-1-git-send-email-michal.vokac@ysoft.com>
The SSD130x OLED display reset signal is active low. Now the reset
sequence is implemented in such a way that users are forced to
define reset-gpios as GPIO_ACTIVE_HIGH in DT to make the reset work.
Do not hard code the active-low sequence into the driver but instead
allow the user to specify the gpio as GPIO_ACTIVE_LOW to reflect
the real world.
Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
---
v2 changes: Split the DT changes into separate patch.
drivers/video/fbdev/ssd1307fb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index e7ae135..7b5bc42 100644
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -728,10 +728,10 @@ static int ssd1307fb_probe(struct i2c_client *client,
if (par->reset) {
/* Reset the screen */
- gpiod_set_value_cansleep(par->reset, 0);
- udelay(4);
gpiod_set_value_cansleep(par->reset, 1);
udelay(4);
+ gpiod_set_value_cansleep(par->reset, 0);
+ udelay(4);
}
if (par->vbat_reg) {
--
2.1.4
next prev parent reply other threads:[~2018-09-27 9:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180927092738epcas5p28c53516b73fe7747133914f40c84d6c4@epcas5p2.samsung.com>
2018-09-27 9:24 ` [RESEND PATCH v2 1/3] video: ssd1307fb: Use gpiod_set_value_cansleep() for reset Michal Vokáč
2018-09-27 9:24 ` Michal Vokáč
2018-09-27 9:24 ` Michal Vokáč [this message]
2018-09-27 9:24 ` [RESEND PATCH v2 2/3] video: ssd1307fb: Do not hard code active-low reset sequence Michal Vokáč
2018-10-08 10:53 ` Bartlomiej Zolnierkiewicz
2018-10-08 10:53 ` Bartlomiej Zolnierkiewicz
2018-09-27 9:24 ` [RESEND PATCH v2 3/3] ARM: dts: imx28-cfa10036: Fix the reset gpio signal polarity Michal Vokáč
2018-09-27 9:24 ` Michal Vokáč
2018-10-08 11:45 ` Vokáč Michal
2018-10-08 11:45 ` Vokáč Michal
2018-10-09 0:20 ` Shawn Guo
2018-10-09 0:20 ` Shawn Guo
2018-10-09 7:51 ` Bartlomiej Zolnierkiewicz
2018-10-09 7:51 ` Bartlomiej Zolnierkiewicz
2018-10-09 8:29 ` Vokáč Michal
2018-10-09 8:29 ` Vokáč Michal
2018-10-09 12:36 ` Fabio Estevam
2018-10-09 12:36 ` Fabio Estevam
2018-10-09 12:36 ` Fabio Estevam
2018-10-09 13:18 ` Vokáč Michal
2018-10-09 13:18 ` Vokáč Michal
2018-10-09 13:18 ` Vokáč Michal
2018-10-09 13:30 ` Bartlomiej Zolnierkiewicz
2018-10-09 13:30 ` Bartlomiej Zolnierkiewicz
2018-10-09 13:30 ` Bartlomiej Zolnierkiewicz
2018-10-08 10:53 ` [RESEND PATCH v2 1/3] video: ssd1307fb: Use gpiod_set_value_cansleep() for reset Bartlomiej Zolnierkiewicz
2018-10-08 10:53 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538040281-21319-2-git-send-email-michal.vokac@ysoft.com \
--to=michal.vokac@ysoft.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.