From: Alex Gonzalez <alex.gonzalez@digi.com> To: <hadess@hadess.net> Cc: <dmitry.torokhov@gmail.com>, <linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <alex.gonzalez@digi.com> Subject: [PATCH] Input: goodix - decouple irq and reset lines Date: Fri, 4 Jan 2019 17:00:48 +0100 [thread overview] Message-ID: <1546617648-23445-2-git-send-email-alex.gonzalez@digi.com> (raw) In-Reply-To: <1546617648-23445-1-git-send-email-alex.gonzalez@digi.com> The Goodix touch controller allows the use of two optional GPIOs (RESET and INT) to reset the touch controller, select the I2C address of the device and exit the device from sleep mode. The current implementation requires both GPIOs to be provided, however, it is possible to provide only the INT line and not to have the RESET line available but pulled-up. Designs that only provide the INT line are able to operate the touch on the default I2C address but will not be able to reset the touch via software or place the device in sleep mode. Signed-off-by: Alex Gonzalez <alex.gonzalez@digi.com> --- drivers/input/touchscreen/goodix.c | 59 ++++++++++++++++++++------------------ 1 file changed, 31 insertions(+), 28 deletions(-) diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index f2d9c2c41885..8d96b0b771b6 100644 --- a/drivers/input/touchscreen/goodix.c +++ b/drivers/input/touchscreen/goodix.c @@ -484,34 +484,39 @@ static int goodix_reset(struct goodix_ts_data *ts) { int error; - /* begin select I2C slave addr */ - error = gpiod_direction_output(ts->gpiod_rst, 0); - if (error) - return error; + if (ts->gpiod_rst) { + /* begin select I2C slave addr */ + error = gpiod_direction_output(ts->gpiod_rst, 0); + if (error) + return error; - msleep(20); /* T2: > 10ms */ + msleep(20); /* T2: > 10ms */ - /* HIGH: 0x28/0x29, LOW: 0xBA/0xBB */ - error = gpiod_direction_output(ts->gpiod_int, ts->client->addr == 0x14); - if (error) - return error; + /* HIGH: 0x28/0x29, LOW: 0xBA/0xBB */ + error = gpiod_direction_output(ts->gpiod_int, + ts->client->addr == 0x14); + if (error) + return error; - usleep_range(100, 2000); /* T3: > 100us */ + usleep_range(100, 2000); /* T3: > 100us */ - error = gpiod_direction_output(ts->gpiod_rst, 1); - if (error) - return error; + error = gpiod_direction_output(ts->gpiod_rst, 1); + if (error) + return error; - usleep_range(6000, 10000); /* T4: > 5ms */ + usleep_range(6000, 10000); /* T4: > 5ms */ - /* end select I2C slave addr */ - error = gpiod_direction_input(ts->gpiod_rst); - if (error) - return error; + /* end select I2C slave addr */ + error = gpiod_direction_input(ts->gpiod_rst); + if (error) + return error; + } - error = goodix_int_sync(ts); - if (error) - return error; + if (ts->gpiod_int) { + error = goodix_int_sync(ts); + if (error) + return error; + } return 0; } @@ -786,13 +791,11 @@ static int goodix_ts_probe(struct i2c_client *client, if (error) return error; - if (ts->gpiod_int && ts->gpiod_rst) { - /* reset the controller */ - error = goodix_reset(ts); - if (error) { - dev_err(&client->dev, "Controller reset failed.\n"); - return error; - } + /* reset the controller */ + error = goodix_reset(ts); + if (error) { + dev_err(&client->dev, "Controller reset failed.\n"); + return error; } error = goodix_i2c_test(client);
WARNING: multiple messages have this Message-ID (diff)
From: Alex Gonzalez <alex.gonzalez@digi.com> To: hadess@hadess.net Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, alex.gonzalez@digi.com Subject: [PATCH] Input: goodix - decouple irq and reset lines Date: Fri, 4 Jan 2019 17:00:48 +0100 [thread overview] Message-ID: <1546617648-23445-2-git-send-email-alex.gonzalez@digi.com> (raw) In-Reply-To: <1546617648-23445-1-git-send-email-alex.gonzalez@digi.com> The Goodix touch controller allows the use of two optional GPIOs (RESET and INT) to reset the touch controller, select the I2C address of the device and exit the device from sleep mode. The current implementation requires both GPIOs to be provided, however, it is possible to provide only the INT line and not to have the RESET line available but pulled-up. Designs that only provide the INT line are able to operate the touch on the default I2C address but will not be able to reset the touch via software or place the device in sleep mode. Signed-off-by: Alex Gonzalez <alex.gonzalez@digi.com> --- drivers/input/touchscreen/goodix.c | 59 ++++++++++++++++++++------------------ 1 file changed, 31 insertions(+), 28 deletions(-) diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index f2d9c2c41885..8d96b0b771b6 100644 --- a/drivers/input/touchscreen/goodix.c +++ b/drivers/input/touchscreen/goodix.c @@ -484,34 +484,39 @@ static int goodix_reset(struct goodix_ts_data *ts) { int error; - /* begin select I2C slave addr */ - error = gpiod_direction_output(ts->gpiod_rst, 0); - if (error) - return error; + if (ts->gpiod_rst) { + /* begin select I2C slave addr */ + error = gpiod_direction_output(ts->gpiod_rst, 0); + if (error) + return error; - msleep(20); /* T2: > 10ms */ + msleep(20); /* T2: > 10ms */ - /* HIGH: 0x28/0x29, LOW: 0xBA/0xBB */ - error = gpiod_direction_output(ts->gpiod_int, ts->client->addr == 0x14); - if (error) - return error; + /* HIGH: 0x28/0x29, LOW: 0xBA/0xBB */ + error = gpiod_direction_output(ts->gpiod_int, + ts->client->addr == 0x14); + if (error) + return error; - usleep_range(100, 2000); /* T3: > 100us */ + usleep_range(100, 2000); /* T3: > 100us */ - error = gpiod_direction_output(ts->gpiod_rst, 1); - if (error) - return error; + error = gpiod_direction_output(ts->gpiod_rst, 1); + if (error) + return error; - usleep_range(6000, 10000); /* T4: > 5ms */ + usleep_range(6000, 10000); /* T4: > 5ms */ - /* end select I2C slave addr */ - error = gpiod_direction_input(ts->gpiod_rst); - if (error) - return error; + /* end select I2C slave addr */ + error = gpiod_direction_input(ts->gpiod_rst); + if (error) + return error; + } - error = goodix_int_sync(ts); - if (error) - return error; + if (ts->gpiod_int) { + error = goodix_int_sync(ts); + if (error) + return error; + } return 0; } @@ -786,13 +791,11 @@ static int goodix_ts_probe(struct i2c_client *client, if (error) return error; - if (ts->gpiod_int && ts->gpiod_rst) { - /* reset the controller */ - error = goodix_reset(ts); - if (error) { - dev_err(&client->dev, "Controller reset failed.\n"); - return error; - } + /* reset the controller */ + error = goodix_reset(ts); + if (error) { + dev_err(&client->dev, "Controller reset failed.\n"); + return error; } error = goodix_i2c_test(client);
next prev parent reply other threads:[~2019-01-04 16:01 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-04 16:00 [PATCH] Input: goodix - decouple irq and reset lines Alex Gonzalez 2019-01-04 16:00 ` Alex Gonzalez 2019-01-04 16:00 ` Alex Gonzalez [this message] 2019-01-04 16:00 ` Alex Gonzalez 2019-01-04 22:31 ` Andreas Gohr 2019-01-05 22:51 ` Dmitry Torokhov 2019-01-07 10:13 ` Gonzalez, Alex 2019-01-07 15:56 ` Bastien Nocera 2019-01-07 16:01 ` Bastien Nocera 2019-01-07 16:44 ` Gonzalez, Alex 2019-01-07 16:42 ` Gonzalez, Alex 2019-01-07 18:56 ` Dmitry Torokhov 2019-01-08 17:20 ` Gonzalez, Alex
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1546617648-23445-2-git-send-email-alex.gonzalez@digi.com \ --to=alex.gonzalez@digi.com \ --cc=dmitry.torokhov@gmail.com \ --cc=hadess@hadess.net \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.