From: Andrew Murray <andrew.murray@arm.com> To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, Richard Henderson <rth@twiddle.net>, Ivan Kokshaysky <ink@jurassic.park.msu.ru>, Matt Turner <mattst88@gmail.com>, Will Deacon <will.deacon@arm.com>, Mark Rutland <mark.rutland@arm.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>, Russell King <linux@armlinux.org.uk>, suzuki.poulose@arm.com, robin.murphy@arm.com, Michael Ellerman <mpe@ellerman.id.au> Cc: x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org Subject: [PATCH v4 03/13] perf/core: add PERF_PMU_CAP_NO_EXCLUDE for exclusion incapable PMUs Date: Mon, 7 Jan 2019 16:27:20 +0000 [thread overview] Message-ID: <1546878450-20341-4-git-send-email-andrew.murray@arm.com> (raw) In-Reply-To: <1546878450-20341-1-git-send-email-andrew.murray@arm.com> Many PMU drivers do not have the capability to exclude counting events that occur in specific contexts such as idle, kernel, guest, etc. These drivers indicate this by returning an error in their event_init upon testing the events attribute flags. This approach is error prone and often inconsistent. Let's instead allow PMU drivers to advertise their inability to exclude based on context via a new capability: PERF_PMU_CAP_NO_EXCLUDE. This allows the perf core to reject requests for exclusion events where there is no support in the PMU. Signed-off-by: Andrew Murray <andrew.murray@arm.com> --- include/linux/perf_event.h | 1 + kernel/events/core.c | 9 +++++++++ 2 files changed, 10 insertions(+) diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 54a78d2..cec02dc 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -244,6 +244,7 @@ struct perf_event; #define PERF_PMU_CAP_EXCLUSIVE 0x10 #define PERF_PMU_CAP_ITRACE 0x20 #define PERF_PMU_CAP_HETEROGENEOUS_CPUS 0x40 +#define PERF_PMU_CAP_NO_EXCLUDE 0x80 /** * struct pmu - generic performance monitoring unit diff --git a/kernel/events/core.c b/kernel/events/core.c index 3cd13a3..fbe59b7 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -9772,6 +9772,15 @@ static int perf_try_init_event(struct pmu *pmu, struct perf_event *event) if (ctx) perf_event_ctx_unlock(event->group_leader, ctx); + if (!ret) { + if (pmu->capabilities & PERF_PMU_CAP_NO_EXCLUDE && + event_has_any_exclude_flag(event)) { + if (event->destroy) + event->destroy(event); + ret = -EINVAL; + } + } + if (ret) module_put(pmu->module); -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Murray <andrew.murray@arm.com> To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, Richard Henderson <rth@twiddle.net>, Ivan Kokshaysky <ink@jurassic.park.msu.ru>, Matt Turner <mattst88@gmail.com>, Will Deacon <will.deacon@arm.com>, Mark Rutland <mark.rutland@arm.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>, Russell King <linux@armlinux.org.uk>, suzuki.poulose@arm.com, robin.murphy@arm.com, Michael Ellerman <mpe@ellerman.id.au> Cc: x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org Subject: [PATCH v4 03/13] perf/core: add PERF_PMU_CAP_NO_EXCLUDE for exclusion incapable PMUs Date: Mon, 7 Jan 2019 16:27:20 +0000 [thread overview] Message-ID: <1546878450-20341-4-git-send-email-andrew.murray@arm.com> (raw) In-Reply-To: <1546878450-20341-1-git-send-email-andrew.murray@arm.com> Many PMU drivers do not have the capability to exclude counting events that occur in specific contexts such as idle, kernel, guest, etc. These drivers indicate this by returning an error in their event_init upon testing the events attribute flags. This approach is error prone and often inconsistent. Let's instead allow PMU drivers to advertise their inability to exclude based on context via a new capability: PERF_PMU_CAP_NO_EXCLUDE. This allows the perf core to reject requests for exclusion events where there is no support in the PMU. Signed-off-by: Andrew Murray <andrew.murray@arm.com> --- include/linux/perf_event.h | 1 + kernel/events/core.c | 9 +++++++++ 2 files changed, 10 insertions(+) diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 54a78d2..cec02dc 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -244,6 +244,7 @@ struct perf_event; #define PERF_PMU_CAP_EXCLUSIVE 0x10 #define PERF_PMU_CAP_ITRACE 0x20 #define PERF_PMU_CAP_HETEROGENEOUS_CPUS 0x40 +#define PERF_PMU_CAP_NO_EXCLUDE 0x80 /** * struct pmu - generic performance monitoring unit diff --git a/kernel/events/core.c b/kernel/events/core.c index 3cd13a3..fbe59b7 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -9772,6 +9772,15 @@ static int perf_try_init_event(struct pmu *pmu, struct perf_event *event) if (ctx) perf_event_ctx_unlock(event->group_leader, ctx); + if (!ret) { + if (pmu->capabilities & PERF_PMU_CAP_NO_EXCLUDE && + event_has_any_exclude_flag(event)) { + if (event->destroy) + event->destroy(event); + ret = -EINVAL; + } + } + if (ret) module_put(pmu->module); -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-07 16:27 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-07 16:27 [PATCH v4 00/13] perf/core: Generalise event exclusion checking Andrew Murray 2019-01-07 16:27 ` Andrew Murray 2019-01-07 16:27 ` [PATCH v4 01/13] perf/doc: update design.txt for exclude_{host|guest} flags Andrew Murray 2019-01-07 16:27 ` Andrew Murray 2019-01-07 16:27 ` [PATCH v4 02/13] perf/core: add function to test for event exclusion flags Andrew Murray 2019-01-07 16:27 ` Andrew Murray 2019-01-07 16:27 ` Andrew Murray [this message] 2019-01-07 16:27 ` [PATCH v4 03/13] perf/core: add PERF_PMU_CAP_NO_EXCLUDE for exclusion incapable PMUs Andrew Murray 2019-01-07 16:27 ` [PATCH v4 04/13] alpha: perf/core: use PERF_PMU_CAP_NO_EXCLUDE Andrew Murray 2019-01-07 16:27 ` Andrew Murray 2019-01-07 16:27 ` [PATCH v4 05/13] arm: perf: conditionally " Andrew Murray 2019-01-07 16:27 ` Andrew Murray 2019-01-08 10:28 ` Peter Zijlstra 2019-01-08 10:28 ` Peter Zijlstra 2019-01-08 10:28 ` Peter Zijlstra 2019-01-08 10:28 ` Peter Zijlstra 2019-01-08 13:07 ` Andrew Murray 2019-01-08 13:07 ` Andrew Murray 2019-01-08 13:07 ` Andrew Murray 2019-01-08 13:10 ` Peter Zijlstra 2019-01-08 13:10 ` Peter Zijlstra 2019-01-08 13:10 ` Peter Zijlstra 2019-01-08 13:10 ` Peter Zijlstra 2019-01-08 13:13 ` Andrew Murray 2019-01-08 13:13 ` Andrew Murray 2019-01-08 13:13 ` Andrew Murray 2019-01-08 14:43 ` Peter Zijlstra 2019-01-08 14:43 ` Peter Zijlstra 2019-01-08 14:43 ` Peter Zijlstra 2019-01-08 14:43 ` Peter Zijlstra 2019-01-07 16:27 ` [PATCH v4 06/13] arm: perf/core: use PERF_PMU_CAP_NO_EXCLUDE for exclude incapable PMUs Andrew Murray 2019-01-07 16:27 ` Andrew Murray 2019-01-07 16:27 ` [PATCH v4 07/13] drivers/perf: " Andrew Murray 2019-01-07 16:27 ` Andrew Murray 2019-01-07 16:27 ` [PATCH v4 08/13] " Andrew Murray 2019-01-07 16:27 ` Andrew Murray 2019-01-07 16:27 ` [PATCH v4 09/13] powerpc: " Andrew Murray 2019-01-07 16:27 ` Andrew Murray 2019-01-07 16:27 ` [PATCH v4 10/13] x86: " Andrew Murray 2019-01-07 16:27 ` Andrew Murray 2019-01-08 10:48 ` Peter Zijlstra 2019-01-08 10:48 ` Peter Zijlstra 2019-01-08 10:48 ` Peter Zijlstra 2019-01-08 10:48 ` Peter Zijlstra 2019-01-08 13:12 ` Andrew Murray 2019-01-08 13:12 ` Andrew Murray 2019-01-08 13:12 ` Andrew Murray 2019-01-08 13:12 ` Andrew Murray 2019-01-08 16:36 ` Boris Ostrovsky 2019-01-08 16:36 ` Boris Ostrovsky 2019-01-08 16:36 ` Boris Ostrovsky 2019-01-08 16:36 ` Boris Ostrovsky 2019-01-08 18:49 ` Peter Zijlstra 2019-01-08 18:49 ` Peter Zijlstra 2019-01-08 18:49 ` Peter Zijlstra 2019-01-08 18:49 ` Peter Zijlstra 2019-01-10 13:15 ` Michael Ellerman 2019-01-10 13:15 ` Michael Ellerman 2019-01-10 13:15 ` Michael Ellerman 2019-01-10 13:15 ` Michael Ellerman 2019-01-07 16:27 ` [PATCH v4 11/13] " Andrew Murray 2019-01-07 16:27 ` Andrew Murray 2019-01-08 10:49 ` Peter Zijlstra 2019-01-08 10:49 ` Peter Zijlstra 2019-01-08 10:49 ` Peter Zijlstra 2019-01-08 10:49 ` Peter Zijlstra 2019-01-08 13:08 ` Andrew Murray 2019-01-08 13:08 ` Andrew Murray 2019-01-08 13:08 ` Andrew Murray 2019-01-07 16:27 ` [PATCH v4 12/13] perf/core: remove unused perf_flags Andrew Murray 2019-01-07 16:27 ` Andrew Murray 2019-01-07 16:27 ` [PATCH v4 13/13] drivers/perf: use PERF_PMU_CAP_NO_EXCLUDE for Cavium TX2 PMU Andrew Murray 2019-01-07 16:27 ` Andrew Murray 2019-01-10 11:10 ` Will Deacon 2019-01-10 11:10 ` Will Deacon 2019-01-10 11:10 ` Will Deacon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1546878450-20341-4-git-send-email-andrew.murray@arm.com \ --to=andrew.murray@arm.com \ --cc=acme@kernel.org \ --cc=benh@kernel.crashing.org \ --cc=bp@alien8.de \ --cc=ink@jurassic.park.msu.ru \ --cc=linux-alpha@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mark.rutland@arm.com \ --cc=mattst88@gmail.com \ --cc=mingo@redhat.com \ --cc=mpe@ellerman.id.au \ --cc=paulus@samba.org \ --cc=peterz@infradead.org \ --cc=robin.murphy@arm.com \ --cc=rth@twiddle.net \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=suzuki.poulose@arm.com \ --cc=tglx@linutronix.de \ --cc=will.deacon@arm.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.