All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abel Vesa <abel.vesa@nxp.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Rob Herring <robh@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Aisheng Dong <aisheng.dong@nxp.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Abel Vesa <abel.vesa@nxp.com>
Subject: [RFC 2/7] cpuidle: Add cpu poke support
Date: Wed, 27 Mar 2019 13:21:09 +0000	[thread overview]
Message-ID: <1553692845-20983-3-git-send-email-abel.vesa@nxp.com> (raw)
In-Reply-To: <1553692845-20983-1-git-send-email-abel.vesa@nxp.com>

Having a poke operation per state, allows each cpuidle driver to
implement, for each state, different ways of waking up (poking) cores.

Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---
 drivers/cpuidle/cpuidle.c | 34 ++++++++++++++++++++++++++++++++++
 include/linux/cpuidle.h   |  6 ++++++
 2 files changed, 40 insertions(+)

diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 7f10830..fca5313 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -297,6 +297,29 @@ int cpuidle_enter_state(struct cpuidle_device *dev, struct cpuidle_driver *drv,
 }
 
 /**
+ * cpuidle_poke_single - poke the specified cpu to wake up from
+ *		         current idle state
+ *
+ * @dev: cpuidle device for this cpu
+ * @drv: cpuidle driver for this cpu
+ * @cpu: the index of the cpu
+ */
+int cpuidle_poke_single(struct cpuidle_driver *drv, struct cpuidle_device *dev,
+			int cpu)
+{
+	struct cpuidle_state *state;
+
+	if (cpuidle_disabled())
+		return 0;
+
+	state = sched_idle_get_state(cpu);
+	if (state && state->poke)
+		return state->poke(dev, drv, cpu);
+
+	return 0;
+}
+
+/**
  * cpuidle_select - ask the cpuidle framework to choose an idle state
  *
  * @drv: the cpuidle driver
@@ -414,6 +437,17 @@ void cpuidle_resume(void)
 	mutex_unlock(&cpuidle_lock);
 }
 
+void cpuidle_poke(const struct cpumask *mask)
+{
+	struct cpuidle_device *dev = cpuidle_get_device();
+	struct cpuidle_driver *drv = cpuidle_get_cpu_driver(dev);
+	int cpu;
+
+	for_each_cpu(cpu, mask) {
+		WARN_ON(cpuidle_poke_single(drv, dev, cpu));
+	}
+}
+
 /**
  * cpuidle_enable_device - enables idle PM for a CPU
  * @dev: the CPU
diff --git a/include/linux/cpuidle.h b/include/linux/cpuidle.h
index 88a9119..0270771 100644
--- a/include/linux/cpuidle.h
+++ b/include/linux/cpuidle.h
@@ -55,6 +55,10 @@ struct cpuidle_state {
 			struct cpuidle_driver *drv,
 			int index);
 
+	int (*poke)	(struct cpuidle_device *dev,
+			struct cpuidle_driver *drv,
+			int cpu);
+
 	int (*enter_dead) (struct cpuidle_device *dev, int index);
 
 	/*
@@ -145,6 +149,7 @@ extern void cpuidle_unregister(struct cpuidle_driver *drv);
 extern void cpuidle_pause_and_lock(void);
 extern void cpuidle_resume_and_unlock(void);
 extern void cpuidle_pause(void);
+extern void cpuidle_poke(const struct cpumask *mask);
 extern void cpuidle_resume(void);
 extern int cpuidle_enable_device(struct cpuidle_device *dev);
 extern void cpuidle_disable_device(struct cpuidle_device *dev);
@@ -181,6 +186,7 @@ static inline void cpuidle_unregister(struct cpuidle_driver *drv) { }
 static inline void cpuidle_pause_and_lock(void) { }
 static inline void cpuidle_resume_and_unlock(void) { }
 static inline void cpuidle_pause(void) { }
+static inline void cpuidle_poke(const struct cpumask *mask) { }
 static inline void cpuidle_resume(void) { }
 static inline int cpuidle_enable_device(struct cpuidle_device *dev)
 {return -ENODEV; }
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: Abel Vesa <abel.vesa@nxp.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	 Rob Herring <robh@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	 Lucas Stach <l.stach@pengutronix.de>,
	Aisheng Dong <aisheng.dong@nxp.com>
Cc: Abel Vesa <abel.vesa@nxp.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [RFC 2/7] cpuidle: Add cpu poke support
Date: Wed, 27 Mar 2019 13:21:09 +0000	[thread overview]
Message-ID: <1553692845-20983-3-git-send-email-abel.vesa@nxp.com> (raw)
In-Reply-To: <1553692845-20983-1-git-send-email-abel.vesa@nxp.com>

Having a poke operation per state, allows each cpuidle driver to
implement, for each state, different ways of waking up (poking) cores.

Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---
 drivers/cpuidle/cpuidle.c | 34 ++++++++++++++++++++++++++++++++++
 include/linux/cpuidle.h   |  6 ++++++
 2 files changed, 40 insertions(+)

diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 7f10830..fca5313 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -297,6 +297,29 @@ int cpuidle_enter_state(struct cpuidle_device *dev, struct cpuidle_driver *drv,
 }
 
 /**
+ * cpuidle_poke_single - poke the specified cpu to wake up from
+ *		         current idle state
+ *
+ * @dev: cpuidle device for this cpu
+ * @drv: cpuidle driver for this cpu
+ * @cpu: the index of the cpu
+ */
+int cpuidle_poke_single(struct cpuidle_driver *drv, struct cpuidle_device *dev,
+			int cpu)
+{
+	struct cpuidle_state *state;
+
+	if (cpuidle_disabled())
+		return 0;
+
+	state = sched_idle_get_state(cpu);
+	if (state && state->poke)
+		return state->poke(dev, drv, cpu);
+
+	return 0;
+}
+
+/**
  * cpuidle_select - ask the cpuidle framework to choose an idle state
  *
  * @drv: the cpuidle driver
@@ -414,6 +437,17 @@ void cpuidle_resume(void)
 	mutex_unlock(&cpuidle_lock);
 }
 
+void cpuidle_poke(const struct cpumask *mask)
+{
+	struct cpuidle_device *dev = cpuidle_get_device();
+	struct cpuidle_driver *drv = cpuidle_get_cpu_driver(dev);
+	int cpu;
+
+	for_each_cpu(cpu, mask) {
+		WARN_ON(cpuidle_poke_single(drv, dev, cpu));
+	}
+}
+
 /**
  * cpuidle_enable_device - enables idle PM for a CPU
  * @dev: the CPU
diff --git a/include/linux/cpuidle.h b/include/linux/cpuidle.h
index 88a9119..0270771 100644
--- a/include/linux/cpuidle.h
+++ b/include/linux/cpuidle.h
@@ -55,6 +55,10 @@ struct cpuidle_state {
 			struct cpuidle_driver *drv,
 			int index);
 
+	int (*poke)	(struct cpuidle_device *dev,
+			struct cpuidle_driver *drv,
+			int cpu);
+
 	int (*enter_dead) (struct cpuidle_device *dev, int index);
 
 	/*
@@ -145,6 +149,7 @@ extern void cpuidle_unregister(struct cpuidle_driver *drv);
 extern void cpuidle_pause_and_lock(void);
 extern void cpuidle_resume_and_unlock(void);
 extern void cpuidle_pause(void);
+extern void cpuidle_poke(const struct cpumask *mask);
 extern void cpuidle_resume(void);
 extern int cpuidle_enable_device(struct cpuidle_device *dev);
 extern void cpuidle_disable_device(struct cpuidle_device *dev);
@@ -181,6 +186,7 @@ static inline void cpuidle_unregister(struct cpuidle_driver *drv) { }
 static inline void cpuidle_pause_and_lock(void) { }
 static inline void cpuidle_resume_and_unlock(void) { }
 static inline void cpuidle_pause(void) { }
+static inline void cpuidle_poke(const struct cpumask *mask) { }
 static inline void cpuidle_resume(void) { }
 static inline int cpuidle_enable_device(struct cpuidle_device *dev)
 {return -ENODEV; }
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-03-27 13:21 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-27 13:21 [RFC 0/7] cpuidle: Add poking mechanism to support non-IPI wakeup Abel Vesa
2019-03-27 13:21 ` Abel Vesa
2019-03-27 13:21 ` Abel Vesa
2019-03-27 13:21 ` [RFC 1/7] sched: idle: Add sched get idle state helper Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21 ` Abel Vesa [this message]
2019-03-27 13:21   ` [RFC 2/7] cpuidle: Add cpu poke support Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21 ` [RFC 3/7] smp: Poke the cores before requesting IPI Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21 ` [RFC 4/7] psci: Add cpu_poke ops to support core poking Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21 ` [RFC 5/7] cpuidle-arm: Add ops to support poke alonside enter Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21 ` [RFC 6/7] cpuidle-arm: Add arm64 wake helper for cpu_poke op Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21 ` [RFC 7/7] arm64: dts: imx8mq: Add cpu-sleep state with poke wake-up enabled Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 13:21   ` Abel Vesa
2019-03-27 15:44 ` [RFC 0/7] cpuidle: Add poking mechanism to support non-IPI wakeup Lucas Stach
2019-03-27 15:44   ` Lucas Stach
2019-03-27 15:44   ` Lucas Stach
2019-03-27 15:57   ` Marc Zyngier
2019-03-27 15:57     ` Marc Zyngier
2019-03-27 15:57     ` Marc Zyngier
2019-03-27 16:06     ` Lucas Stach
2019-03-27 16:06       ` Lucas Stach
2019-03-27 16:06       ` Lucas Stach
2019-03-27 17:00       ` Leonard Crestez
2019-03-27 17:00         ` Leonard Crestez
2019-03-27 17:00         ` Leonard Crestez
2019-03-27 17:11         ` Lucas Stach
2019-03-27 17:11           ` Lucas Stach
2019-03-27 17:11           ` Lucas Stach
2019-03-27 18:13         ` Marc Zyngier
2019-03-27 18:13           ` Marc Zyngier
2019-03-27 18:13           ` Marc Zyngier
2019-03-28 11:21           ` Aisheng Dong
2019-03-28 11:21             ` Aisheng Dong
2019-03-28 11:21             ` Aisheng Dong
2019-03-29  9:11             ` Richard Zhu
2019-03-29  9:11               ` Richard Zhu
2019-03-29  9:11               ` Richard Zhu
2019-03-27 17:45       ` Marc Zyngier
2019-03-27 17:45         ` Marc Zyngier
2019-03-27 17:45         ` Marc Zyngier
2019-03-27 17:55         ` Lucas Stach
2019-03-27 17:55           ` Lucas Stach
2019-03-27 17:55           ` Lucas Stach
2019-03-28 11:27           ` Aisheng Dong
2019-03-28 11:27             ` Aisheng Dong
2019-03-28 11:27             ` Aisheng Dong
2019-03-27 18:40         ` Leonard Crestez
2019-03-27 18:40           ` Leonard Crestez
2019-03-27 18:40           ` Leonard Crestez
2019-03-28 10:35           ` Marc Zyngier
2019-03-28 10:35             ` Marc Zyngier
2019-03-28 10:35             ` Marc Zyngier
2019-03-28 10:36             ` Rafael J. Wysocki
2019-03-28 10:36               ` Rafael J. Wysocki
2019-03-28 10:36               ` Rafael J. Wysocki
2019-03-28 11:55             ` Aisheng Dong
2019-03-28 11:55               ` Aisheng Dong
2019-03-28 11:55               ` Aisheng Dong
2019-03-28 10:45           ` Lorenzo Pieralisi
2019-03-28 10:45             ` Lorenzo Pieralisi
2019-03-28 10:45             ` Lorenzo Pieralisi
2019-11-06 20:14             ` Florian Fainelli
2019-11-06 20:14               ` Florian Fainelli
2019-11-06 21:31               ` Leonard Crestez
2019-11-06 21:31                 ` Leonard Crestez
2019-11-06 22:10                 ` Florian Fainelli
2019-11-06 22:10                   ` Florian Fainelli
2019-11-06 22:47                   ` Leonard Crestez
2019-11-06 22:47                     ` Leonard Crestez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1553692845-20983-3-git-send-email-abel.vesa@nxp.com \
    --to=abel.vesa@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=catalin.marinas@arm.com \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.