From: John Garry <john.garry@huawei.com> To: <broonie@kernel.org>, <marek.vasut@gmail.com>, <tudor.ambarus@microchip.com> Cc: <linuxarm@huawei.com>, <linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>, <xuejiancheng@hisilicon.com>, <fengsheng5@huawei.com>, <chenxiang66@hisilicon.com>, John Garry <john.garry@huawei.com> Subject: [PATCH v2 1/3] mtd: spi-nor: hisi-sfc: Try to provide some clarity on which SFC we are Date: Mon, 9 Dec 2019 22:08:08 +0800 [thread overview] Message-ID: <1575900490-74467-2-git-send-email-john.garry@huawei.com> (raw) In-Reply-To: <1575900490-74467-1-git-send-email-john.garry@huawei.com> The driver is for the HiSilicon FMC (Flash Memory Controller), which supports SPI NOR in addition other memory technologies, like SPI NAND. Indeed, the naming in the driver is a little inappropriate, especially considering that there is already another HiSilicon SPI NOR flash controller (which I believe the FMC is derived from). Since we now want to provide software support for this other HiSilicon controller, update code comments to at least try to make it clear that this driver is for the FMC. Signed-off-by: John Garry <john.garry@huawei.com> --- drivers/mtd/spi-nor/Kconfig | 4 ++-- drivers/mtd/spi-nor/hisi-sfc.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig index f237fcdf7f86..c1eda67d1ad2 100644 --- a/drivers/mtd/spi-nor/Kconfig +++ b/drivers/mtd/spi-nor/Kconfig @@ -46,11 +46,11 @@ config SPI_CADENCE_QUADSPI Flash as an MTD device. config SPI_HISI_SFC - tristate "Hisilicon SPI-NOR Flash Controller(SFC)" + tristate "Hisilicon FMC SPI-NOR Flash Controller(SFC)" depends on ARCH_HISI || COMPILE_TEST depends on HAS_IOMEM help - This enables support for hisilicon SPI-NOR flash controller. + This enables support for HiSilicon FMC SPI-NOR flash controller. config SPI_MTK_QUADSPI tristate "MediaTek Quad SPI controller" diff --git a/drivers/mtd/spi-nor/hisi-sfc.c b/drivers/mtd/spi-nor/hisi-sfc.c index a1258216f89d..6db964bf3b0e 100644 --- a/drivers/mtd/spi-nor/hisi-sfc.c +++ b/drivers/mtd/spi-nor/hisi-sfc.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* - * HiSilicon SPI Nor Flash Controller Driver + * HiSilicon FMC SPI-NOR flash controller driver * * Copyright (c) 2015-2016 HiSilicon Technologies Co., Ltd. */ -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com> To: <broonie@kernel.org>, <marek.vasut@gmail.com>, <tudor.ambarus@microchip.com> Cc: chenxiang66@hisilicon.com, linux-kernel@vger.kernel.org, John Garry <john.garry@huawei.com>, linuxarm@huawei.com, fengsheng5@huawei.com, linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org, xuejiancheng@hisilicon.com Subject: [PATCH v2 1/3] mtd: spi-nor: hisi-sfc: Try to provide some clarity on which SFC we are Date: Mon, 9 Dec 2019 22:08:08 +0800 [thread overview] Message-ID: <1575900490-74467-2-git-send-email-john.garry@huawei.com> (raw) In-Reply-To: <1575900490-74467-1-git-send-email-john.garry@huawei.com> The driver is for the HiSilicon FMC (Flash Memory Controller), which supports SPI NOR in addition other memory technologies, like SPI NAND. Indeed, the naming in the driver is a little inappropriate, especially considering that there is already another HiSilicon SPI NOR flash controller (which I believe the FMC is derived from). Since we now want to provide software support for this other HiSilicon controller, update code comments to at least try to make it clear that this driver is for the FMC. Signed-off-by: John Garry <john.garry@huawei.com> --- drivers/mtd/spi-nor/Kconfig | 4 ++-- drivers/mtd/spi-nor/hisi-sfc.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig index f237fcdf7f86..c1eda67d1ad2 100644 --- a/drivers/mtd/spi-nor/Kconfig +++ b/drivers/mtd/spi-nor/Kconfig @@ -46,11 +46,11 @@ config SPI_CADENCE_QUADSPI Flash as an MTD device. config SPI_HISI_SFC - tristate "Hisilicon SPI-NOR Flash Controller(SFC)" + tristate "Hisilicon FMC SPI-NOR Flash Controller(SFC)" depends on ARCH_HISI || COMPILE_TEST depends on HAS_IOMEM help - This enables support for hisilicon SPI-NOR flash controller. + This enables support for HiSilicon FMC SPI-NOR flash controller. config SPI_MTK_QUADSPI tristate "MediaTek Quad SPI controller" diff --git a/drivers/mtd/spi-nor/hisi-sfc.c b/drivers/mtd/spi-nor/hisi-sfc.c index a1258216f89d..6db964bf3b0e 100644 --- a/drivers/mtd/spi-nor/hisi-sfc.c +++ b/drivers/mtd/spi-nor/hisi-sfc.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* - * HiSilicon SPI Nor Flash Controller Driver + * HiSilicon FMC SPI-NOR flash controller driver * * Copyright (c) 2015-2016 HiSilicon Technologies Co., Ltd. */ -- 2.17.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-12-09 14:12 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-09 14:08 [PATCH v2 0/3] HiSilicon v3xx SFC driver John Garry 2019-12-09 14:08 ` John Garry 2019-12-09 14:08 ` John Garry [this message] 2019-12-09 14:08 ` [PATCH v2 1/3] mtd: spi-nor: hisi-sfc: Try to provide some clarity on which SFC we are John Garry 2020-01-16 11:03 ` Tudor.Ambarus 2020-01-16 11:03 ` Tudor.Ambarus 2019-12-09 14:08 ` [PATCH v2 2/3] spi: Add HiSilicon v3xx SPI NOR flash controller driver John Garry 2019-12-09 14:08 ` John Garry 2020-01-09 15:54 ` John Garry 2020-01-09 15:54 ` John Garry 2020-01-09 21:28 ` Mark Brown 2020-01-09 21:28 ` Mark Brown 2020-01-10 11:55 ` John Garry 2020-01-10 11:55 ` John Garry 2020-01-10 11:55 ` John Garry 2020-01-10 14:07 ` Mark Brown 2020-01-10 14:07 ` Mark Brown 2020-01-10 14:07 ` Mark Brown 2020-01-10 14:58 ` John Garry 2020-01-10 14:58 ` John Garry 2020-01-10 15:12 ` Mark Brown 2020-01-10 15:12 ` Mark Brown 2020-01-10 16:09 ` John Garry 2020-01-10 16:09 ` John Garry 2020-01-10 19:31 ` Andy Shevchenko 2020-01-10 19:31 ` Andy Shevchenko 2020-01-10 19:31 ` Andy Shevchenko 2020-01-13 10:09 ` John Garry 2020-01-13 10:09 ` John Garry 2020-01-13 11:42 ` Mark Brown 2020-01-13 11:42 ` Mark Brown 2020-01-13 13:01 ` John Garry 2020-01-13 13:01 ` John Garry 2020-01-13 14:06 ` Mark Brown 2020-01-13 14:06 ` Mark Brown 2020-01-13 14:17 ` Andy Shevchenko 2020-01-13 14:17 ` Andy Shevchenko 2020-01-13 14:17 ` Andy Shevchenko 2020-01-13 14:27 ` Mark Brown 2020-01-13 14:27 ` Mark Brown 2020-01-13 14:27 ` Mark Brown 2020-01-13 14:34 ` Andy Shevchenko 2020-01-13 14:34 ` Andy Shevchenko 2020-01-13 14:34 ` Andy Shevchenko 2020-01-31 10:08 ` John Garry 2020-01-31 10:08 ` John Garry 2020-01-31 11:39 ` Andy Shevchenko 2020-01-31 11:39 ` Andy Shevchenko 2020-01-31 11:39 ` Andy Shevchenko 2020-01-31 12:03 ` John Garry 2020-01-31 12:03 ` John Garry 2020-01-31 12:03 ` John Garry 2020-01-31 15:46 ` Andy Shevchenko 2020-01-31 15:46 ` Andy Shevchenko 2020-01-31 15:46 ` Andy Shevchenko 2020-01-31 16:26 ` John Garry 2020-01-31 16:26 ` John Garry 2020-01-31 16:26 ` John Garry 2020-02-01 11:34 ` Mark Brown 2020-02-01 11:34 ` Mark Brown 2020-02-01 11:32 ` Mark Brown 2020-02-01 11:32 ` Mark Brown 2020-01-10 19:59 ` Applied "spi: Add HiSilicon v3xx SPI NOR flash controller driver" to the spi tree Mark Brown 2020-01-10 19:59 ` Mark Brown 2020-01-10 19:59 ` Mark Brown 2019-12-09 14:08 ` [PATCH v2 3/3] MAINTAINERS: Add a maintainer for the HiSilicon v3xx SFC driver John Garry 2019-12-09 14:08 ` John Garry 2020-01-10 19:59 ` Applied "MAINTAINERS: Add a maintainer for the HiSilicon v3xx SFC driver" to the spi tree Mark Brown 2020-01-10 19:59 ` Mark Brown 2020-01-10 19:59 ` Mark Brown 2019-12-16 14:52 ` [PATCH v2 0/3] HiSilicon v3xx SFC driver John Garry 2019-12-16 14:52 ` John Garry 2019-12-16 14:56 ` Mark Brown 2019-12-16 14:56 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1575900490-74467-2-git-send-email-john.garry@huawei.com \ --to=john.garry@huawei.com \ --cc=broonie@kernel.org \ --cc=chenxiang66@hisilicon.com \ --cc=fengsheng5@huawei.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=marek.vasut@gmail.com \ --cc=tudor.ambarus@microchip.com \ --cc=xuejiancheng@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.