All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	CK Hu <ck.hu@mediatek.com>,
	Bibby Hsieh <bibby.hsieh@mediatek.com>,
	Houlong Wei <houlong.wei@mediatek.com>
Cc: <dri-devel@lists.freedesktop.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <wsd_upstream@mediatek.com>,
	HS Liao <hs.liao@mediatek.com>,
	Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
Subject: [PATCH v3 1/9] soc: mediatek: cmdq: add address shift in jump
Date: Tue, 7 Jul 2020 23:45:06 +0800	[thread overview]
Message-ID: <1594136714-11650-2-git-send-email-dennis-yc.hsieh@mediatek.com> (raw)
In-Reply-To: <1594136714-11650-1-git-send-email-dennis-yc.hsieh@mediatek.com>

Add address shift when compose jump instruction
to compatible with 35bit format.

Change since v1:
- Rename cmdq_mbox_shift() to cmdq_get_shift_pa().

Signed-off-by: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
---
 drivers/soc/mediatek/mtk-cmdq-helper.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
index dc644cfb6419..9faf78fbed3a 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -329,7 +329,8 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
 
 	/* JUMP to end */
 	inst.op = CMDQ_CODE_JUMP;
-	inst.value = CMDQ_JUMP_PASS;
+	inst.value = CMDQ_JUMP_PASS >>
+		cmdq_get_shift_pa(((struct cmdq_client *)pkt->cl)->chan);
 	err = cmdq_pkt_append_command(pkt, inst);
 
 	return err;
-- 
1.7.9.5

WARNING: multiple messages have this Message-ID (diff)
From: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	CK Hu <ck.hu@mediatek.com>,
	Bibby Hsieh <bibby.hsieh@mediatek.com>,
	Houlong Wei <houlong.wei@mediatek.com>
Cc: wsd_upstream@mediatek.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, HS Liao <hs.liao@mediatek.com>,
	Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/9] soc: mediatek: cmdq: add address shift in jump
Date: Tue, 7 Jul 2020 23:45:06 +0800	[thread overview]
Message-ID: <1594136714-11650-2-git-send-email-dennis-yc.hsieh@mediatek.com> (raw)
In-Reply-To: <1594136714-11650-1-git-send-email-dennis-yc.hsieh@mediatek.com>

Add address shift when compose jump instruction
to compatible with 35bit format.

Change since v1:
- Rename cmdq_mbox_shift() to cmdq_get_shift_pa().

Signed-off-by: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
---
 drivers/soc/mediatek/mtk-cmdq-helper.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
index dc644cfb6419..9faf78fbed3a 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -329,7 +329,8 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
 
 	/* JUMP to end */
 	inst.op = CMDQ_CODE_JUMP;
-	inst.value = CMDQ_JUMP_PASS;
+	inst.value = CMDQ_JUMP_PASS >>
+		cmdq_get_shift_pa(((struct cmdq_client *)pkt->cl)->chan);
 	err = cmdq_pkt_append_command(pkt, inst);
 
 	return err;
-- 
1.7.9.5
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	CK Hu <ck.hu@mediatek.com>,
	Bibby Hsieh <bibby.hsieh@mediatek.com>,
	Houlong Wei <houlong.wei@mediatek.com>
Cc: wsd_upstream@mediatek.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, HS Liao <hs.liao@mediatek.com>,
	Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/9] soc: mediatek: cmdq: add address shift in jump
Date: Tue, 7 Jul 2020 23:45:06 +0800	[thread overview]
Message-ID: <1594136714-11650-2-git-send-email-dennis-yc.hsieh@mediatek.com> (raw)
In-Reply-To: <1594136714-11650-1-git-send-email-dennis-yc.hsieh@mediatek.com>

Add address shift when compose jump instruction
to compatible with 35bit format.

Change since v1:
- Rename cmdq_mbox_shift() to cmdq_get_shift_pa().

Signed-off-by: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
---
 drivers/soc/mediatek/mtk-cmdq-helper.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
index dc644cfb6419..9faf78fbed3a 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -329,7 +329,8 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
 
 	/* JUMP to end */
 	inst.op = CMDQ_CODE_JUMP;
-	inst.value = CMDQ_JUMP_PASS;
+	inst.value = CMDQ_JUMP_PASS >>
+		cmdq_get_shift_pa(((struct cmdq_client *)pkt->cl)->chan);
 	err = cmdq_pkt_append_command(pkt, inst);
 
 	return err;
-- 
1.7.9.5
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	CK Hu <ck.hu@mediatek.com>,
	Bibby Hsieh <bibby.hsieh@mediatek.com>,
	Houlong Wei <houlong.wei@mediatek.com>
Cc: wsd_upstream@mediatek.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, HS Liao <hs.liao@mediatek.com>,
	Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/9] soc: mediatek: cmdq: add address shift in jump
Date: Tue, 7 Jul 2020 23:45:06 +0800	[thread overview]
Message-ID: <1594136714-11650-2-git-send-email-dennis-yc.hsieh@mediatek.com> (raw)
In-Reply-To: <1594136714-11650-1-git-send-email-dennis-yc.hsieh@mediatek.com>

Add address shift when compose jump instruction
to compatible with 35bit format.

Change since v1:
- Rename cmdq_mbox_shift() to cmdq_get_shift_pa().

Signed-off-by: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
---
 drivers/soc/mediatek/mtk-cmdq-helper.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
index dc644cfb6419..9faf78fbed3a 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -329,7 +329,8 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
 
 	/* JUMP to end */
 	inst.op = CMDQ_CODE_JUMP;
-	inst.value = CMDQ_JUMP_PASS;
+	inst.value = CMDQ_JUMP_PASS >>
+		cmdq_get_shift_pa(((struct cmdq_client *)pkt->cl)->chan);
 	err = cmdq_pkt_append_command(pkt, inst);
 
 	return err;
-- 
1.7.9.5
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-07-07 15:46 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 15:45 [PATCH v3 0/9] support cmdq helper function on mt6779 platform Dennis YC Hsieh
2020-07-07 15:45 ` Dennis YC Hsieh
2020-07-07 15:45 ` Dennis YC Hsieh
2020-07-07 15:45 ` Dennis YC Hsieh
2020-07-07 15:45 ` Dennis YC Hsieh [this message]
2020-07-07 15:45   ` [PATCH v3 1/9] soc: mediatek: cmdq: add address shift in jump Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-08  7:27   ` Bibby Hsieh
2020-07-08  7:27     ` Bibby Hsieh
2020-07-08  7:27     ` Bibby Hsieh
2020-07-08  7:27     ` Bibby Hsieh
2020-09-21 16:15   ` Matthias Brugger
2020-09-21 16:15     ` Matthias Brugger
2020-09-21 16:15     ` Matthias Brugger
2020-09-21 16:15     ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 2/9] soc: mediatek: cmdq: add write_s function Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-09-21 16:15   ` Matthias Brugger
2020-09-21 16:15     ` Matthias Brugger
2020-09-21 16:15     ` Matthias Brugger
2020-09-21 16:15     ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 3/9] soc: mediatek: cmdq: add write_s_mask function Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-09-21 16:15   ` Matthias Brugger
2020-09-21 16:15     ` Matthias Brugger
2020-09-21 16:15     ` Matthias Brugger
2020-09-21 16:15     ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 4/9] soc: mediatek: cmdq: add read_s function Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-09-21 16:16   ` Matthias Brugger
2020-09-21 16:16     ` Matthias Brugger
2020-09-21 16:16     ` Matthias Brugger
2020-09-21 16:16     ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 5/9] soc: mediatek: cmdq: add write_s value function Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-09-21 16:16   ` Matthias Brugger
2020-09-21 16:16     ` Matthias Brugger
2020-09-21 16:16     ` Matthias Brugger
2020-09-21 16:16     ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 6/9] soc: mediatek: cmdq: add write_s_mask " Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-09-21 16:16   ` Matthias Brugger
2020-09-21 16:16     ` Matthias Brugger
2020-09-21 16:16     ` Matthias Brugger
2020-09-21 16:16     ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 7/9] soc: mediatek: cmdq: add jump function Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-09-21 16:18   ` Matthias Brugger
2020-09-21 16:18     ` Matthias Brugger
2020-09-21 16:18     ` Matthias Brugger
2020-09-21 16:18     ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 8/9] soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 23:04   ` Chun-Kuang Hu
2020-07-07 23:04     ` Chun-Kuang Hu
2020-07-07 23:04     ` Chun-Kuang Hu
2020-07-07 23:04     ` Chun-Kuang Hu
2020-09-21 16:19   ` Matthias Brugger
2020-09-21 16:19     ` Matthias Brugger
2020-09-21 16:19     ` Matthias Brugger
2020-09-21 16:19     ` Matthias Brugger
2020-09-21 16:25     ` Dennis-YC Hsieh
2020-09-21 16:25       ` Dennis-YC Hsieh
2020-09-21 16:25       ` Dennis-YC Hsieh
2020-09-21 16:25       ` Dennis-YC Hsieh
2020-07-07 15:45 ` [PATCH v3 9/9] drm/mediatek: reduce clear event Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 15:45   ` Dennis YC Hsieh
2020-07-07 23:01   ` Chun-Kuang Hu
2020-07-07 23:01     ` Chun-Kuang Hu
2020-07-07 23:01     ` Chun-Kuang Hu
2020-07-07 23:01     ` Chun-Kuang Hu
2020-09-21 16:37     ` Matthias Brugger
2020-09-21 16:37       ` Matthias Brugger
2020-09-21 16:37       ` Matthias Brugger
2020-09-21 16:37       ` Matthias Brugger
2020-07-09  2:39   ` Bibby Hsieh
2020-07-09  2:39     ` Bibby Hsieh
2020-07-09  2:39     ` Bibby Hsieh
2020-07-09  2:39     ` Bibby Hsieh
2020-09-21 16:36     ` Matthias Brugger
2020-09-21 16:36       ` Matthias Brugger
2020-09-21 16:36       ` Matthias Brugger
2020-09-21 16:36       ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1594136714-11650-2-git-send-email-dennis-yc.hsieh@mediatek.com \
    --to=dennis-yc.hsieh@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=bibby.hsieh@mediatek.com \
    --cc=ck.hu@mediatek.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=houlong.wei@mediatek.com \
    --cc=hs.liao@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.