All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Rob Herring <robh+dt@kernel.org>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Maxime Ripard <maxime@cerno.tech>,
	iivanov@suse.de, devicetree@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Stefan Wahren <stefan.wahren@i2se.com>
Subject: [PATCH V2 02/10] ARM: dts: bcm2711-rpi-4-b: fix sd_io_1v8_reg regulator states
Date: Sat,  7 Aug 2021 13:06:33 +0200	[thread overview]
Message-ID: <1628334401-6577-3-git-send-email-stefan.wahren@i2se.com> (raw)
In-Reply-To: <1628334401-6577-1-git-send-email-stefan.wahren@i2se.com>

DT schema check complains at sd_io_1v8_reg about the following:

 [1800000, 1, 3300000, 0] is too long
 Additional items are not allowed (3300000, 0 were unexpected)

So fix the states definition.

Fixes: 7dbe8c62ceeb ("ARM: dts: Add minimal Raspberry Pi 4 support")
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
index f24bdd0..abf8298 100644
--- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
+++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
@@ -40,8 +40,8 @@
 		regulator-always-on;
 		regulator-settling-time-us = <5000>;
 		gpios = <&expgpio 4 GPIO_ACTIVE_HIGH>;
-		states = <1800000 0x1
-			  3300000 0x0>;
+		states = <1800000 0x1>,
+			 <3300000 0x0>;
 		status = "okay";
 	};
 
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Rob Herring <robh+dt@kernel.org>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Maxime Ripard <maxime@cerno.tech>,
	iivanov@suse.de, devicetree@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Stefan Wahren <stefan.wahren@i2se.com>
Subject: [PATCH V2 02/10] ARM: dts: bcm2711-rpi-4-b: fix sd_io_1v8_reg regulator states
Date: Sat,  7 Aug 2021 13:06:33 +0200	[thread overview]
Message-ID: <1628334401-6577-3-git-send-email-stefan.wahren@i2se.com> (raw)
In-Reply-To: <1628334401-6577-1-git-send-email-stefan.wahren@i2se.com>

DT schema check complains at sd_io_1v8_reg about the following:

 [1800000, 1, 3300000, 0] is too long
 Additional items are not allowed (3300000, 0 were unexpected)

So fix the states definition.

Fixes: 7dbe8c62ceeb ("ARM: dts: Add minimal Raspberry Pi 4 support")
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
index f24bdd0..abf8298 100644
--- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
+++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
@@ -40,8 +40,8 @@
 		regulator-always-on;
 		regulator-settling-time-us = <5000>;
 		gpios = <&expgpio 4 GPIO_ACTIVE_HIGH>;
-		states = <1800000 0x1
-			  3300000 0x0>;
+		states = <1800000 0x1>,
+			 <3300000 0x0>;
 		status = "okay";
 	};
 
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-08-07 11:07 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-07 11:06 [PATCH V2 00/10] ARM: dts: Add Raspberry Pi CM4 & CM4 IO Board support Stefan Wahren
2021-08-07 11:06 ` Stefan Wahren
2021-08-07 11:06 ` [PATCH V2 01/10] ARM: dts: bcm2711: fix MDIO #address- and #size-cells Stefan Wahren
2021-08-07 11:06   ` Stefan Wahren
2021-08-07 11:06 ` Stefan Wahren [this message]
2021-08-07 11:06   ` [PATCH V2 02/10] ARM: dts: bcm2711-rpi-4-b: fix sd_io_1v8_reg regulator states Stefan Wahren
2021-08-07 11:06 ` [PATCH V2 03/10] dt-bindings: display: bcm2835: add optional property power-domains Stefan Wahren
2021-08-07 11:06   ` Stefan Wahren
2021-08-07 11:06 ` [PATCH V2 04/10] mmc: sdhci-iproc: Cap min clock frequency on BCM2711 Stefan Wahren
2021-08-07 11:06   ` Stefan Wahren
2021-08-16 13:59   ` Ulf Hansson
2021-08-16 13:59     ` Ulf Hansson
2021-08-07 11:06 ` [PATCH V2 05/10] mmc: sdhci-iproc: Set SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN " Stefan Wahren
2021-08-07 11:06   ` Stefan Wahren
2021-08-16 13:59   ` Ulf Hansson
2021-08-16 13:59     ` Ulf Hansson
2021-08-26  6:36   ` Jeremy Linton
2021-08-26  6:36     ` Jeremy Linton
2021-08-26  9:22     ` Ulf Hansson
2021-08-26  9:22       ` Ulf Hansson
2021-08-26 11:18       ` Stefan Wahren
2021-08-26 11:18         ` Stefan Wahren
2021-08-27 14:44         ` Ulf Hansson
2021-08-27 14:44           ` Ulf Hansson
2021-08-07 11:06 ` [PATCH V2 06/10] ARM: dts: bcm283x-rpi: Move Wifi/BT into separate dtsi Stefan Wahren
2021-08-07 11:06   ` Stefan Wahren
2021-08-07 11:06 ` [PATCH V2 07/10] dt-bindings: arm: bcm2835: Add Raspberry Pi Compute Module 4 Stefan Wahren
2021-08-07 11:06   ` Stefan Wahren
2021-08-07 11:06 ` [PATCH V2 08/10] ARM: dts: " Stefan Wahren
2021-08-07 11:06   ` Stefan Wahren
2021-08-07 11:06 ` [PATCH V2 09/10] ARM: dts: Add Raspberry Pi Compute Module 4 IO Board Stefan Wahren
2021-08-07 11:06   ` Stefan Wahren
2021-09-04 14:52   ` nicolas saenz julienne
2021-09-04 14:52     ` nicolas saenz julienne
2021-09-05 10:33     ` Stefan Wahren
2021-09-05 10:33       ` Stefan Wahren
2021-08-07 11:06 ` [PATCH V2 10/10] arm64: dts: broadcom: Add reference to RPi CM4 " Stefan Wahren
2021-08-07 11:06   ` Stefan Wahren
2021-08-22 10:31 ` [PATCH V2 00/10] ARM: dts: Add Raspberry Pi CM4 & CM4 IO Board support Florian Fainelli
2021-08-22 10:31   ` Florian Fainelli
2021-08-30  8:46   ` nicolas saenz julienne
2021-08-30  8:46     ` nicolas saenz julienne
2021-09-04 14:45 ` nicolas saenz julienne
2021-09-04 14:45   ` nicolas saenz julienne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1628334401-6577-3-git-send-email-stefan.wahren@i2se.com \
    --to=stefan.wahren@i2se.com \
    --cc=adrian.hunter@intel.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=iivanov@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=maxime@cerno.tech \
    --cc=nsaenz@kernel.org \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.