From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, guaneryu@gmail.com, zlang@redhat.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me
Subject: [PATCH 5/6] common/populate: don't metadump xfs filesystems twice
Date: Wed, 05 Oct 2022 15:31:01 -0700 [thread overview]
Message-ID: <166500906102.886939.861772249521756043.stgit@magnolia> (raw)
In-Reply-To: <166500903290.886939.12532028548655386973.stgit@magnolia>
From: Darrick J. Wong <djwong@kernel.org>
Due to some braino on my part, _scratch_populate_cached will metadump
the filesystem twice -- once with compression disabled, and again with
it enabled, maybe. Get rid of the first metadump.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
common/populate | 1 -
1 file changed, 1 deletion(-)
diff --git a/common/populate b/common/populate
index 9739ac99e0..4eee7e8c66 100644
--- a/common/populate
+++ b/common/populate
@@ -890,7 +890,6 @@ _scratch_populate_cached() {
"xfs")
_scratch_xfs_populate $@
_scratch_xfs_populate_check
- _scratch_xfs_metadump "${POPULATE_METADUMP}"
local logdev=
[ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_LOGDEV" ] && \
next prev parent reply other threads:[~2022-10-05 22:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 22:30 [PATCHSET v2 0/6] fstests: random fixes for v2022.09.25 Darrick J. Wong
2022-10-05 22:30 ` [PATCH 1/6] generic/092: skip test if file allocation unit isn't aligned Darrick J. Wong
2022-10-05 22:30 ` [PATCH 2/6] xfs/114: fix missing reflink requires Darrick J. Wong
2022-10-05 22:30 ` [PATCH 3/6] xfs/229: do not _xfs_force_bdev on TEST_DIR Darrick J. Wong
2022-10-05 22:30 ` [PATCH 4/6] xfs/128: try to force file allocation behavior Darrick J. Wong
2022-10-08 11:11 ` Zorro Lang
2022-10-08 17:54 ` Darrick J. Wong
2022-10-09 2:19 ` Zorro Lang
2022-10-09 17:09 ` Darrick J. Wong
2022-10-05 22:31 ` Darrick J. Wong [this message]
2022-10-08 11:12 ` [PATCH 5/6] common/populate: don't metadump xfs filesystems twice Zorro Lang
2022-10-05 22:31 ` [PATCH 6/6] common/populate: fix _xfs_metadump usage in _scratch_populate_cached Darrick J. Wong
2022-10-08 11:12 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166500906102.886939.861772249521756043.stgit@magnolia \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.