All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Beer <daniel.beer@igorinstitute.com>
To: alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org,
	Daniel Beer <daniel.beer@igorinstitute.com>,
	Andy Liu <andy-liu@ti.com>, Mark Brown <broonie@kernel.org>
Subject: [PATCH v3 2/2] ASoC: tas5805m: add missing page switch.
Date: Thu, 27 Oct 2022 21:38:38 +1300	[thread overview]
Message-ID: <1fea38a71ea6ab0225d19ab28d1fa12828d762d0.1675497326.git.daniel.beer@igorinstitute.com> (raw)
In-Reply-To: <cover.1675497326.git.daniel.beer@igorinstitute.com>

In tas5805m_refresh, we switch pages to update the DSP volume control,
but we need to switch back to page 0 before trying to alter the
soft-mute control. This latter page-switch was missing.

Fixes: ec45268467f4 ("ASoC: add support for TAS5805M digital amplifier")
Signed-off-by: Daniel Beer <daniel.beer@igorinstitute.com>
---
 sound/soc/codecs/tas5805m.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/soc/codecs/tas5805m.c b/sound/soc/codecs/tas5805m.c
index 6e2edf045446..4e38eb7acea1 100644
--- a/sound/soc/codecs/tas5805m.c
+++ b/sound/soc/codecs/tas5805m.c
@@ -203,6 +203,9 @@ static void tas5805m_refresh(struct tas5805m_priv *tas5805m)
 	set_dsp_scale(rm, 0x24, tas5805m->vol[0]);
 	set_dsp_scale(rm, 0x28, tas5805m->vol[1]);
 
+	regmap_write(rm, REG_PAGE, 0x00);
+	regmap_write(rm, REG_BOOK, 0x00);
+
 	/* Set/clear digital soft-mute */
 	regmap_write(rm, REG_DEVICE_CTRL_2,
 		(tas5805m->is_muted ? DCTRL2_MUTE : 0) |
-- 
2.38.1


WARNING: multiple messages have this Message-ID (diff)
From: Daniel Beer <daniel.beer@igorinstitute.com>
To: alsa-devel@alsa-project.org
Cc: Andy Liu <andy-liu@ti.com>, Mark Brown <broonie@kernel.org>,
	Daniel Beer <daniel.beer@igorinstitute.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 2/2] ASoC: tas5805m: add missing page switch.
Date: Thu, 27 Oct 2022 21:38:38 +1300	[thread overview]
Message-ID: <1fea38a71ea6ab0225d19ab28d1fa12828d762d0.1675497326.git.daniel.beer@igorinstitute.com> (raw)
In-Reply-To: <cover.1675497326.git.daniel.beer@igorinstitute.com>

In tas5805m_refresh, we switch pages to update the DSP volume control,
but we need to switch back to page 0 before trying to alter the
soft-mute control. This latter page-switch was missing.

Fixes: ec45268467f4 ("ASoC: add support for TAS5805M digital amplifier")
Signed-off-by: Daniel Beer <daniel.beer@igorinstitute.com>
---
 sound/soc/codecs/tas5805m.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/soc/codecs/tas5805m.c b/sound/soc/codecs/tas5805m.c
index 6e2edf045446..4e38eb7acea1 100644
--- a/sound/soc/codecs/tas5805m.c
+++ b/sound/soc/codecs/tas5805m.c
@@ -203,6 +203,9 @@ static void tas5805m_refresh(struct tas5805m_priv *tas5805m)
 	set_dsp_scale(rm, 0x24, tas5805m->vol[0]);
 	set_dsp_scale(rm, 0x28, tas5805m->vol[1]);
 
+	regmap_write(rm, REG_PAGE, 0x00);
+	regmap_write(rm, REG_BOOK, 0x00);
+
 	/* Set/clear digital soft-mute */
 	regmap_write(rm, REG_DEVICE_CTRL_2,
 		(tas5805m->is_muted ? DCTRL2_MUTE : 0) |
-- 
2.38.1


  parent reply	other threads:[~2023-02-04 21:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-04  7:55 [PATCH v3 0/2] Two bug fixes for tas5805m codec driver Daniel Beer
2023-02-04  7:55 ` Daniel Beer
2022-10-27  8:28 ` [PATCH v3 1/2] ASoC: tas5805m: rework to avoid scheduling while atomic Daniel Beer
2022-10-27  8:28   ` Daniel Beer
2022-10-27  8:38 ` Daniel Beer [this message]
2022-10-27  8:38   ` [PATCH v3 2/2] ASoC: tas5805m: add missing page switch Daniel Beer
2023-02-06 13:11   ` Mark Brown
2023-02-06 13:11     ` Mark Brown
2023-02-06 20:45     ` Daniel Beer
2023-02-06 20:45       ` Daniel Beer
2023-02-06 21:14       ` Mark Brown
2023-02-06 21:14         ` Mark Brown
2023-02-06 21:37 ` [PATCH v3 0/2] Two bug fixes for tas5805m codec driver Mark Brown
2023-02-06 21:37   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1fea38a71ea6ab0225d19ab28d1fa12828d762d0.1675497326.git.daniel.beer@igorinstitute.com \
    --to=daniel.beer@igorinstitute.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andy-liu@ti.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.