From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Fix select-induced Kconfig warning for ZBOOT_ROM
Date: Mon, 13 Jan 2014 16:20:12 +0100 [thread overview]
Message-ID: <20140113152011.GA15107@ulmo.nvidia.com> (raw)
In-Reply-To: <20140113134813.GX15937@n2100.arm.linux.org.uk>
On Mon, Jan 13, 2014 at 01:48:13PM +0000, Russell King - ARM Linux wrote:
> On Mon, Jan 13, 2014 at 12:52:10PM +0100, Thierry Reding wrote:
> > On Wed, Jan 08, 2014 at 09:20:10AM +0100, Arnd Bergmann wrote:
> > > --- a/arch/arm/mach-imx/Kconfig
> > > +++ b/arch/arm/mach-imx/Kconfig
> > > @@ -3,7 +3,7 @@ config ARCH_MXC
> > > select ARCH_REQUIRE_GPIOLIB
> > > select ARM_CPU_SUSPEND if PM
> > > select ARM_PATCH_PHYS_VIRT
> > > - select AUTO_ZRELADDR if !ZBOOT_ROM
> > > + select AUTO_ZRELADDR
> > > select CLKSRC_MMIO
> > > select COMMON_CLK
> > > select GENERIC_ALLOCATOR
> >
> > Hi Arnd,
> >
> > I haven't seen this go into linux-next yet. Do you plan on sending a
> > patch for this?
>
> Maybe someone should respond to this comment from Arnd:
>
> | On second thought, we should just remove the 'select AUTO_ZRELADDR' from
> | ARCH_MXC and everything that is multiplatform enabled, since it's already
> | selected by ARCH_MULTIPLATFORM.
>
> which I think is the right way to go here. The ARCH_MXC option is
> hidden when multiplatform is not enabled. When it is enabled,
> AUTO_ZRELADDR is selected by the multiplatform option. So having a
> "select AUTO_ZRELADDR" of any kind under ARCH_MXC is entirely
> redundant.
It looks like ARCH_MXC is the only one that matches Arnd's requirements.
All other platforms that select AUTO_ZRELADDR seem to not support multi-
platform.
Below is a patch to remove the line completely. Shall I post that to the
patch tracker?
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ARM-Remove-redundant-select-AUTO_ZRELADDR.patch
Type: text/x-diff
Size: 1302 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140113/82d5820b/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140113/82d5820b/attachment-0001.sig>
next prev parent reply other threads:[~2014-01-13 15:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 16:23 [PATCH] Fix select-induced Kconfig warning for ZBOOT_ROM Russell King
2014-01-08 8:02 ` Viresh Kumar
2014-01-08 8:20 ` Arnd Bergmann
2014-01-08 8:26 ` Viresh Kumar
2014-01-08 9:07 ` Arnd Bergmann
2014-01-08 9:12 ` Viresh Kumar
2014-01-13 11:52 ` Thierry Reding
2014-01-13 13:48 ` Russell King - ARM Linux
2014-01-13 15:20 ` Thierry Reding [this message]
2014-01-13 15:24 ` Arnd Bergmann
2014-01-15 8:56 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113152011.GA15107@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.