All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v4 02/10] xprtrdma: xprt_rdma_free() must not release backchannel reqs
Date: Wed, 16 Dec 2015 17:22:14 -0500	[thread overview]
Message-ID: <20151216222214.13110.23751.stgit@manet.1015granger.net> (raw)
In-Reply-To: <20151216221444.13110.43538.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>

Preserve any rpcrdma_req that is attached to rpc_rqst's allocated
for the backchannel. Otherwise, after all the pre-allocated
backchannel req's are consumed, incoming backward calls start
writing on freed memory.

Somehow this hunk got lost.

Fixes: f531a5dbc451 ('xprtrdma: Pre-allocate backward rpc_rqst')
Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Tested-by: Devesh Sharma <devesh.sharma-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org>
---
 net/sunrpc/xprtrdma/transport.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c
index 8c545f7..740bddc 100644
--- a/net/sunrpc/xprtrdma/transport.c
+++ b/net/sunrpc/xprtrdma/transport.c
@@ -576,6 +576,9 @@ xprt_rdma_free(void *buffer)
 
 	rb = container_of(buffer, struct rpcrdma_regbuf, rg_base[0]);
 	req = rb->rg_owner;
+	if (req->rl_backchannel)
+		return;
+
 	r_xprt = container_of(req->rl_buffer, struct rpcrdma_xprt, rx_buf);
 
 	dprintk("RPC:       %s: called on 0x%p\n", __func__, req->rl_reply);

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Chuck Lever <chuck.lever@oracle.com>
To: anna.schumaker@netapp.com
Cc: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [PATCH v4 02/10] xprtrdma: xprt_rdma_free() must not release backchannel reqs
Date: Wed, 16 Dec 2015 17:22:14 -0500	[thread overview]
Message-ID: <20151216222214.13110.23751.stgit@manet.1015granger.net> (raw)
In-Reply-To: <20151216221444.13110.43538.stgit@manet.1015granger.net>

Preserve any rpcrdma_req that is attached to rpc_rqst's allocated
for the backchannel. Otherwise, after all the pre-allocated
backchannel req's are consumed, incoming backward calls start
writing on freed memory.

Somehow this hunk got lost.

Fixes: f531a5dbc451 ('xprtrdma: Pre-allocate backward rpc_rqst')
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Tested-by: Devesh Sharma <devesh.sharma@avagotech.com>
---
 net/sunrpc/xprtrdma/transport.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c
index 8c545f7..740bddc 100644
--- a/net/sunrpc/xprtrdma/transport.c
+++ b/net/sunrpc/xprtrdma/transport.c
@@ -576,6 +576,9 @@ xprt_rdma_free(void *buffer)
 
 	rb = container_of(buffer, struct rpcrdma_regbuf, rg_base[0]);
 	req = rb->rg_owner;
+	if (req->rl_backchannel)
+		return;
+
 	r_xprt = container_of(req->rl_buffer, struct rpcrdma_xprt, rx_buf);
 
 	dprintk("RPC:       %s: called on 0x%p\n", __func__, req->rl_reply);


  parent reply	other threads:[~2015-12-16 22:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 22:21 [PATCH v4 00/10] NFS/RDMA client patches for 4.5 Chuck Lever
2015-12-16 22:21 ` Chuck Lever
     [not found] ` <20151216221444.13110.43538.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2015-12-16 22:22   ` [PATCH v4 01/10] xprtrdma: Fix additional uses of spin_lock_irqsave(rb_lock) Chuck Lever
2015-12-16 22:22     ` Chuck Lever
2015-12-16 22:22   ` Chuck Lever [this message]
2015-12-16 22:22     ` [PATCH v4 02/10] xprtrdma: xprt_rdma_free() must not release backchannel reqs Chuck Lever
2015-12-16 22:22   ` [PATCH v4 03/10] xprtrdma: Disable RPC/RDMA backchannel debugging messages Chuck Lever
2015-12-16 22:22     ` Chuck Lever
2015-12-16 22:22   ` [PATCH v4 04/10] xprtrdma: Move struct ib_send_wr off the stack Chuck Lever
2015-12-16 22:22     ` Chuck Lever
2015-12-16 22:22   ` [PATCH v4 05/10] xprtrdma: Introduce ro_unmap_sync method Chuck Lever
2015-12-16 22:22     ` Chuck Lever
2015-12-16 22:22   ` [PATCH v4 06/10] xprtrdma: Add ro_unmap_sync method for FRWR Chuck Lever
2015-12-16 22:22     ` Chuck Lever
2015-12-16 22:22   ` [PATCH v4 07/10] xprtrdma: Add ro_unmap_sync method for FMR Chuck Lever
2015-12-16 22:22     ` Chuck Lever
2015-12-16 22:23   ` [PATCH v4 08/10] xprtrdma: Add ro_unmap_sync method for all-physical registration Chuck Lever
2015-12-16 22:23     ` Chuck Lever
2015-12-16 22:23   ` [PATCH v4 09/10] xprtrdma: Invalidate in the RPC reply handler Chuck Lever
2015-12-16 22:23     ` Chuck Lever
2015-12-16 22:23   ` [PATCH v4 10/10] xprtrdma: Revert commit e7104a2a9606 ('xprtrdma: Cap req_cqinit') Chuck Lever
2015-12-16 22:23     ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151216222214.13110.23751.stgit@manet.1015granger.net \
    --to=chuck.lever-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.