All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v3 19/22] xprtrdma: Support larger inline thresholds
Date: Thu, 15 Sep 2016 10:57:32 -0400	[thread overview]
Message-ID: <20160915145732.11080.28375.stgit@manet.1015granger.net> (raw)
In-Reply-To: <20160915143440.11080.89241.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>

The Version One default inline threshold is still 1KB. But allow
testing with thresholds up to 64KB.

This maximum is somewhat arbitrary. There's no fundamental
architectural limit I'm aware of, but it's good to keep the size of
Receive buffers reasonable. Now that Send can use a s/g list, a
Send buffer is only as large as each RPC requires. Receive buffers
are always the size of the inline threshold, however.

Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
 include/linux/sunrpc/xprtrdma.h |    4 ++--
 net/sunrpc/xprtrdma/transport.c |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/sunrpc/xprtrdma.h b/include/linux/sunrpc/xprtrdma.h
index 39267dc..221b7a2 100644
--- a/include/linux/sunrpc/xprtrdma.h
+++ b/include/linux/sunrpc/xprtrdma.h
@@ -53,8 +53,8 @@
 #define RPCRDMA_MAX_SLOT_TABLE	(256U)
 
 #define RPCRDMA_MIN_INLINE  (1024)	/* min inline thresh */
-#define RPCRDMA_DEF_INLINE  (1024)	/* default inline thresh */
-#define RPCRDMA_MAX_INLINE  (3068)	/* max inline thresh */
+#define RPCRDMA_DEF_INLINE  (4096)	/* default inline thresh */
+#define RPCRDMA_MAX_INLINE  (65536)	/* max inline thresh */
 
 /* Memory registration strategies, by number.
  * This is part of a kernel / user space API. Do not remove. */
diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c
index 6a358ab..ed5e285 100644
--- a/net/sunrpc/xprtrdma/transport.c
+++ b/net/sunrpc/xprtrdma/transport.c
@@ -97,7 +97,7 @@ static struct ctl_table xr_tunables_table[] = {
 		.data		= &xprt_rdma_max_inline_read,
 		.maxlen		= sizeof(unsigned int),
 		.mode		= 0644,
-		.proc_handler	= proc_dointvec,
+		.proc_handler	= proc_dointvec_minmax,
 		.extra1		= &min_inline_size,
 		.extra2		= &max_inline_size,
 	},
@@ -106,7 +106,7 @@ static struct ctl_table xr_tunables_table[] = {
 		.data		= &xprt_rdma_max_inline_write,
 		.maxlen		= sizeof(unsigned int),
 		.mode		= 0644,
-		.proc_handler	= proc_dointvec,
+		.proc_handler	= proc_dointvec_minmax,
 		.extra1		= &min_inline_size,
 		.extra2		= &max_inline_size,
 	},

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Chuck Lever <chuck.lever@oracle.com>
To: anna.schumaker@netapp.com
Cc: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [PATCH v3 19/22] xprtrdma: Support larger inline thresholds
Date: Thu, 15 Sep 2016 10:57:32 -0400	[thread overview]
Message-ID: <20160915145732.11080.28375.stgit@manet.1015granger.net> (raw)
In-Reply-To: <20160915143440.11080.89241.stgit@manet.1015granger.net>

The Version One default inline threshold is still 1KB. But allow
testing with thresholds up to 64KB.

This maximum is somewhat arbitrary. There's no fundamental
architectural limit I'm aware of, but it's good to keep the size of
Receive buffers reasonable. Now that Send can use a s/g list, a
Send buffer is only as large as each RPC requires. Receive buffers
are always the size of the inline threshold, however.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 include/linux/sunrpc/xprtrdma.h |    4 ++--
 net/sunrpc/xprtrdma/transport.c |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/sunrpc/xprtrdma.h b/include/linux/sunrpc/xprtrdma.h
index 39267dc..221b7a2 100644
--- a/include/linux/sunrpc/xprtrdma.h
+++ b/include/linux/sunrpc/xprtrdma.h
@@ -53,8 +53,8 @@
 #define RPCRDMA_MAX_SLOT_TABLE	(256U)
 
 #define RPCRDMA_MIN_INLINE  (1024)	/* min inline thresh */
-#define RPCRDMA_DEF_INLINE  (1024)	/* default inline thresh */
-#define RPCRDMA_MAX_INLINE  (3068)	/* max inline thresh */
+#define RPCRDMA_DEF_INLINE  (4096)	/* default inline thresh */
+#define RPCRDMA_MAX_INLINE  (65536)	/* max inline thresh */
 
 /* Memory registration strategies, by number.
  * This is part of a kernel / user space API. Do not remove. */
diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c
index 6a358ab..ed5e285 100644
--- a/net/sunrpc/xprtrdma/transport.c
+++ b/net/sunrpc/xprtrdma/transport.c
@@ -97,7 +97,7 @@ static struct ctl_table xr_tunables_table[] = {
 		.data		= &xprt_rdma_max_inline_read,
 		.maxlen		= sizeof(unsigned int),
 		.mode		= 0644,
-		.proc_handler	= proc_dointvec,
+		.proc_handler	= proc_dointvec_minmax,
 		.extra1		= &min_inline_size,
 		.extra2		= &max_inline_size,
 	},
@@ -106,7 +106,7 @@ static struct ctl_table xr_tunables_table[] = {
 		.data		= &xprt_rdma_max_inline_write,
 		.maxlen		= sizeof(unsigned int),
 		.mode		= 0644,
-		.proc_handler	= proc_dointvec,
+		.proc_handler	= proc_dointvec_minmax,
 		.extra1		= &min_inline_size,
 		.extra2		= &max_inline_size,
 	},


  parent reply	other threads:[~2016-09-15 14:57 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 14:54 [PATCH v3 00/22] client-side NFS/RDMA patches ready for v4.9 Chuck Lever
2016-09-15 14:54 ` Chuck Lever
     [not found] ` <20160915143440.11080.89241.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2016-09-15 14:55   ` [PATCH v3 01/22] xprtrdma: Eliminate INLINE_THRESHOLD macros Chuck Lever
2016-09-15 14:55     ` Chuck Lever
2016-09-15 14:55   ` [PATCH v3 02/22] SUNRPC: Refactor rpc_xdr_buf_init() Chuck Lever
2016-09-15 14:55     ` Chuck Lever
2016-09-15 14:55   ` [PATCH v3 03/22] SUNRPC: Generalize the RPC buffer allocation API Chuck Lever
2016-09-15 14:55     ` Chuck Lever
2016-09-15 14:55   ` [PATCH v3 04/22] SUNRPC: Generalize the RPC buffer release API Chuck Lever
2016-09-15 14:55     ` Chuck Lever
2016-09-15 14:55   ` [PATCH v3 05/22] SUNRPC: Separate buffer pointers for RPC Call and Reply messages Chuck Lever
2016-09-15 14:55     ` Chuck Lever
2016-09-15 14:55   ` [PATCH v3 06/22] SUNRPC: Add a transport-specific private field in rpc_rqst Chuck Lever
2016-09-15 14:55     ` Chuck Lever
2016-09-15 14:55   ` [PATCH v3 07/22] xprtrdma: Initialize separate RPC call and reply buffers Chuck Lever
2016-09-15 14:55     ` Chuck Lever
2016-09-15 14:56   ` [PATCH v3 08/22] xprtrdma: Use smaller buffers for RPC-over-RDMA headers Chuck Lever
2016-09-15 14:56     ` Chuck Lever
2016-09-15 14:56   ` [PATCH v3 09/22] xprtrdma: Replace DMA_BIDIRECTIONAL Chuck Lever
2016-09-15 14:56     ` Chuck Lever
2016-09-15 14:56   ` [PATCH v3 10/22] xprtrdma: Delay DMA mapping Send and Receive buffers Chuck Lever
2016-09-15 14:56     ` Chuck Lever
2016-09-15 14:56   ` [PATCH v3 11/22] xprtrdma: Eliminate "ia" argument in rpcrdma_{alloc, free}_regbuf Chuck Lever
2016-09-15 14:56     ` Chuck Lever
2016-09-15 14:56   ` [PATCH v3 12/22] xprtrdma: Simplify rpcrdma_ep_post_recv() Chuck Lever
2016-09-15 14:56     ` Chuck Lever
2016-09-15 14:56   ` [PATCH v3 13/22] xprtrdma: Move send_wr to struct rpcrdma_req Chuck Lever
2016-09-15 14:56     ` Chuck Lever
2016-09-15 14:56   ` [PATCH v3 14/22] xprtrdma: Move recv_wr to struct rpcrdma_rep Chuck Lever
2016-09-15 14:56     ` Chuck Lever
2016-09-15 14:56   ` [PATCH v3 15/22] rpcrdma: RDMA/CM private message data structure Chuck Lever
2016-09-15 14:56     ` Chuck Lever
2016-09-15 14:57   ` [PATCH v3 16/22] xprtrdma: Client-side support for rpcrdma_connect_private Chuck Lever
2016-09-15 14:57     ` Chuck Lever
2016-09-15 14:57   ` [PATCH v3 17/22] xprtrdma: Basic support for Remote Invalidation Chuck Lever
2016-09-15 14:57     ` Chuck Lever
2016-09-15 14:57   ` [PATCH v3 18/22] xprtrdma: Use gathered Send for large inline messages Chuck Lever
2016-09-15 14:57     ` Chuck Lever
2016-09-15 14:57   ` Chuck Lever [this message]
2016-09-15 14:57     ` [PATCH v3 19/22] xprtrdma: Support larger inline thresholds Chuck Lever
2016-09-15 14:57   ` [PATCH v3 20/22] xprtrmda: Report address of frmr, not mw Chuck Lever
2016-09-15 14:57     ` Chuck Lever
2016-09-15 14:57   ` [PATCH v3 21/22] xprtrdma: Rename rpcrdma_receive_wc() Chuck Lever
2016-09-15 14:57     ` Chuck Lever
2016-09-15 14:57   ` [PATCH v3 22/22] xprtrdma: Eliminate rpcrdma_receive_worker() Chuck Lever
2016-09-15 14:57     ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160915145732.11080.28375.stgit@manet.1015granger.net \
    --to=chuck.lever-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.