From: "Uwe Kleine-König" <uwe-rXY34ruvC2xidJT2blvkqNi2O/JbrIOy@public.gmane.org> To: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>, Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>, Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>, Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Subject: [PATCH] ARM: dts: armada-{370,xp}: drop "marvell,orion-spi" from SPI controllers Date: Wed, 7 Dec 2016 16:21:09 +0100 [thread overview] Message-ID: <20161207152109.17545-1-uwe@kleine-koenig.org> (raw) From: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> The SPI controllers on Armada 370 and XP differ from the original Orion SPI controllers (at least) in the configuration of the baud rate. So it's wrong to claim compatibility which results in bogus baud rates. Signed-off-by: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> --- arch/arm/boot/dts/armada-370.dtsi | 4 ++-- arch/arm/boot/dts/armada-xp.dtsi | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi index b4258105e91f..b9377c11b379 100644 --- a/arch/arm/boot/dts/armada-370.dtsi +++ b/arch/arm/boot/dts/armada-370.dtsi @@ -435,13 +435,13 @@ * board level if a different configuration is used. */ &spi0 { - compatible = "marvell,armada-370-spi", "marvell,orion-spi"; + compatible = "marvell,armada-370-spi"; pinctrl-0 = <&spi0_pins1>; pinctrl-names = "default"; }; &spi1 { - compatible = "marvell,armada-370-spi", "marvell,orion-spi"; + compatible = "marvell,armada-370-spi"; pinctrl-0 = <&spi1_pins>; pinctrl-names = "default"; }; diff --git a/arch/arm/boot/dts/armada-xp.dtsi b/arch/arm/boot/dts/armada-xp.dtsi index 4a5f99e65b51..3a416834d80b 100644 --- a/arch/arm/boot/dts/armada-xp.dtsi +++ b/arch/arm/boot/dts/armada-xp.dtsi @@ -367,13 +367,13 @@ }; &spi0 { - compatible = "marvell,armada-xp-spi", "marvell,orion-spi"; + compatible = "marvell,armada-xp-spi"; pinctrl-0 = <&spi0_pins>; pinctrl-names = "default"; }; &spi1 { - compatible = "marvell,armada-xp-spi", "marvell,orion-spi"; + compatible = "marvell,armada-xp-spi"; pinctrl-0 = <&spi1_pins>; pinctrl-names = "default"; }; -- 2.10.2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: uwe@kleine-koenig.org (Uwe Kleine-König) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] ARM: dts: armada-{370, xp}: drop "marvell, orion-spi" from SPI controllers Date: Wed, 7 Dec 2016 16:21:09 +0100 [thread overview] Message-ID: <20161207152109.17545-1-uwe@kleine-koenig.org> (raw) From: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> The SPI controllers on Armada 370 and XP differ from the original Orion SPI controllers (at least) in the configuration of the baud rate. So it's wrong to claim compatibility which results in bogus baud rates. Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> --- arch/arm/boot/dts/armada-370.dtsi | 4 ++-- arch/arm/boot/dts/armada-xp.dtsi | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi index b4258105e91f..b9377c11b379 100644 --- a/arch/arm/boot/dts/armada-370.dtsi +++ b/arch/arm/boot/dts/armada-370.dtsi @@ -435,13 +435,13 @@ * board level if a different configuration is used. */ &spi0 { - compatible = "marvell,armada-370-spi", "marvell,orion-spi"; + compatible = "marvell,armada-370-spi"; pinctrl-0 = <&spi0_pins1>; pinctrl-names = "default"; }; &spi1 { - compatible = "marvell,armada-370-spi", "marvell,orion-spi"; + compatible = "marvell,armada-370-spi"; pinctrl-0 = <&spi1_pins>; pinctrl-names = "default"; }; diff --git a/arch/arm/boot/dts/armada-xp.dtsi b/arch/arm/boot/dts/armada-xp.dtsi index 4a5f99e65b51..3a416834d80b 100644 --- a/arch/arm/boot/dts/armada-xp.dtsi +++ b/arch/arm/boot/dts/armada-xp.dtsi @@ -367,13 +367,13 @@ }; &spi0 { - compatible = "marvell,armada-xp-spi", "marvell,orion-spi"; + compatible = "marvell,armada-xp-spi"; pinctrl-0 = <&spi0_pins>; pinctrl-names = "default"; }; &spi1 { - compatible = "marvell,armada-xp-spi", "marvell,orion-spi"; + compatible = "marvell,armada-xp-spi"; pinctrl-0 = <&spi1_pins>; pinctrl-names = "default"; }; -- 2.10.2
next reply other threads:[~2016-12-07 15:21 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-12-07 15:21 Uwe Kleine-König [this message] 2016-12-07 15:21 ` [PATCH] ARM: dts: armada-{370, xp}: drop "marvell, orion-spi" from SPI controllers Uwe Kleine-König [not found] ` <20161207152109.17545-1-uwe-rXY34ruvC2xidJT2blvkqNi2O/JbrIOy@public.gmane.org> 2016-12-07 15:30 ` [PATCH] ARM: dts: armada-{370,xp}: drop "marvell,orion-spi" " Gregory CLEMENT 2016-12-07 15:30 ` [PATCH] ARM: dts: armada-{370, xp}: drop "marvell, orion-spi" " Gregory CLEMENT [not found] ` <87eg1jhi4l.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2016-12-07 15:41 ` [PATCH] ARM: dts: armada-{370,xp}: drop "marvell,orion-spi" " Uwe Kleine-König 2016-12-07 15:41 ` [PATCH] ARM: dts: armada-{370, xp}: drop "marvell, orion-spi" " Uwe Kleine-König 2021-09-09 7:50 ` [PATCH] ARM: dts: armada-{370,xp}: drop "marvell,orion-spi" " Uwe Kleine-König 2021-09-09 7:50 ` [PATCH] ARM: dts: armada-{370, xp}: drop "marvell, orion-spi" " Uwe Kleine-König 2021-09-09 12:31 ` [PATCH] ARM: dts: armada-{370,xp}: drop "marvell,orion-spi" " Andrew Lunn 2021-09-09 12:31 ` [PATCH] ARM: dts: armada-{370, xp}: drop "marvell, orion-spi" " Andrew Lunn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161207152109.17545-1-uwe@kleine-koenig.org \ --to=uwe-rxy34ruvc2xidjt2blvkqni2o/jbrioy@public.gmane.org \ --cc=andrew-g2DYL2Zd6BY@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \ --cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.