All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Foss <robert.foss@collabora.com>
To: intel-gfx@lists.freedesktop.org,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	Maarten Lankhorst <maarten.lankhorst@intel.com>,
	Gustavo Padovan <gustavo.padovan@collabora.com>,
	Daniel Stone <daniels@collabora.com>,
	Mika Kahola <mika.kahola@intel.com>,
	Petri Latvala <petri.latvala@intel.com>
Subject: [PATCH i-g-t v3 05/33] tests/kms_atomic_transition: Add support for dynamic number of planes
Date: Mon, 30 Jan 2017 09:11:56 -0500	[thread overview]
Message-ID: <20170130141224.25063-6-robert.foss@collabora.com> (raw)
In-Reply-To: <20170130141224.25063-1-robert.foss@collabora.com>

Add changes reflecting the new support for dynamic number of planes per pipe.

Signed-off-by: Robert Foss <robert.foss@collabora.com>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
---
 tests/kms_atomic_transition.c | 27 +++++++++++++--------------
 1 file changed, 13 insertions(+), 14 deletions(-)

diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
index 851ffc95..5fdb6175 100644
--- a/tests/kms_atomic_transition.c
+++ b/tests/kms_atomic_transition.c
@@ -120,7 +120,8 @@ static void set_sprite_wh(igt_display_t *display, enum pipe pipe,
 	for_each_plane_on_pipe(display, pipe, plane) {
 		int i = plane->index;
 
-		if (plane->is_primary || plane->is_cursor)
+		if (plane->type == DRM_PLANE_TYPE_PRIMARY ||
+		    plane->type == DRM_PLANE_TYPE_CURSOR)
 			continue;
 
 		parms[i].width = w;
@@ -156,20 +157,16 @@ static void setup_parms(igt_display_t *display, enum pipe pipe,
 	for_each_plane_on_pipe(display, pipe, plane) {
 		int i = plane->index;
 
-		if (plane->is_primary)
+		if (plane->type == DRM_PLANE_TYPE_PRIMARY) {
 			parms[i].fb = plane->fb;
-		else if (plane->is_cursor)
-			parms[i].fb = argb_fb;
-		else
-			parms[i].fb = sprite_fb;
-
-		if (plane->is_primary) {
 			parms[i].width = mode->hdisplay;
 			parms[i].height = mode->vdisplay;
-		} else if (plane->is_cursor) {
+		} else if (plane->type == DRM_PLANE_TYPE_CURSOR) {
+			parms[i].fb = argb_fb;
 			parms[i].width = cursor_width;
 			parms[i].height = cursor_height;
-		}
+		} else
+			parms[i].fb = sprite_fb;
 	}
 
 	igt_create_fb(display->drm_fd, cursor_width, cursor_height,
@@ -273,7 +270,7 @@ run_transition_test(igt_display_t *display, enum pipe pipe, igt_output_t *output
 	drmModeModeInfo *mode, override_mode;
 	igt_plane_t *plane;
 	uint32_t iter_max = 1 << display->pipes[pipe].n_planes, i;
-	struct plane_parms parms[IGT_MAX_PLANES];
+	struct plane_parms parms[display->pipes[pipe].n_planes];
 	bool skip_test = false;
 	unsigned flags = DRM_MODE_PAGE_FLIP_EVENT;
 
@@ -421,7 +418,8 @@ static unsigned set_combinations(igt_display_t *display, unsigned mask, struct i
 		igt_output_set_pipe(output, PIPE_NONE);
 
 	for_each_pipe(display, pipe) {
-		igt_plane_t *plane = &display->pipes[pipe].planes[IGT_PLANE_PRIMARY];
+		igt_plane_t *plane = igt_pipe_get_plane_type(&display->pipes[pipe],
+			DRM_PLANE_TYPE_PRIMARY);
 		drmModeModeInfo *mode = NULL;
 
 		if (!(mask & (1 << pipe))) {
@@ -462,7 +460,7 @@ static void refresh_primaries(igt_display_t *display)
 
 	for_each_pipe(display, pipe)
 		for_each_plane_on_pipe(display, pipe, plane)
-			if (plane->is_primary && plane->fb)
+			if (plane->type == DRM_PLANE_TYPE_PRIMARY && plane->fb)
 				plane->fb_changed = true;
 }
 
@@ -506,7 +504,8 @@ static void run_modeset_tests(igt_display_t *display, int howmany, bool nonblock
 				    DRM_FORMAT_XRGB8888, 0, .5, .5, .5, &fbs[1]);
 
 	for_each_pipe(display, i) {
-		igt_plane_t *plane = &display->pipes[i].planes[IGT_PLANE_PRIMARY];
+		igt_pipe_t *pipe = &display->pipes[i];
+		igt_plane_t *plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
 		drmModeModeInfo *mode = NULL;
 
 		if (is_i915_device(display->drm_fd))
-- 
2.11.0.453.g787f75f05

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-01-30 14:12 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-30 14:11 [PATCH i-g-t v3 00/33] lib/igt_kms: Implement dynamic plane count support Robert Foss
2017-01-30 14:11 ` [PATCH i-g-t v3 01/33] lib/igt_kms: Add index property to kmstest_plane struct Robert Foss
2017-01-30 14:11 ` [PATCH i-g-t v3 02/33] lib/igt_kms: Avoid depencency on static plane count Robert Foss
2017-01-30 14:11 ` [PATCH i-g-t v3 03/33] lib/igt_kms: Rename kmstest properties nplanes and plane Robert Foss
2017-01-30 14:11 ` [PATCH i-g-t v3 04/33] lib/igt_kms: Implement dynamic plane count support Robert Foss
2017-01-30 14:11 ` Robert Foss [this message]
2017-01-30 14:11 ` [PATCH i-g-t v3 06/33] tests/kms_busy: Add support for dynamic number of planes Robert Foss
2017-01-30 14:11 ` [PATCH i-g-t v3 07/33] tests/kms_chv_cursor_fail: " Robert Foss
2017-01-30 14:11 ` [PATCH i-g-t v3 08/33] tests/kms_crtc_background_color: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 09/33] tests/kms_cursor_crc: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 10/33] tests/kms_cursor_legacy: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 11/33] tests/kms_fbc_crc: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 12/33] tests/kms_fence_pin_leak: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 13/33] tests/kms_flip_event_leak: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 14/33] tests/kms_legacy_colorkey: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 15/33] tests/kms_mmap_write_crc: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 16/33] tests/kms_mmio_vs_cs_flip: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 17/33] tests/kms_panel_fitting: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 18/33] tests/kms_pipe_color: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 19/33] tests/kms_plane: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 20/33] tests/kms_plane_multiple: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 21/33] tests/kms_plane_scaling: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 22/33] tests/kms_properties: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 23/33] tests/kms_psr_sink_crc: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 24/33] tests/kms_pwrite_crc: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 25/33] tests/kms_rmfb: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 26/33] tests/kms_rotation_crc: " Robert Foss
2017-03-28 22:06   ` Jordan Justen
2017-03-28 22:19     ` Robert Foss
2017-03-28 23:08       ` Jordan Justen
2017-01-30 14:12 ` [PATCH i-g-t v3 27/33] tests/kms_sink_crc_basic: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 28/33] tests/kms_universal_plane: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 29/33] tests/kms_vblank: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 30/33] tests/prime_mmap_kms: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 31/33] tests/kms_ccs: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 32/33] tests/kms_plane_lowres: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 33/33] lib/igt_kms: Remove code obsoleted by dyn n_planes implementation Robert Foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170130141224.25063-6-robert.foss@collabora.com \
    --to=robert.foss@collabora.com \
    --cc=daniels@collabora.com \
    --cc=gustavo.padovan@collabora.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maarten.lankhorst@intel.com \
    --cc=mika.kahola@intel.com \
    --cc=petri.latvala@intel.com \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.