From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Bart Van Assche <bart.vanassche@sandisk.com>, dm-devel@redhat.com
Subject: [PATCH v2 09/13] dm-mpath: Verify locking assumptions at runtime
Date: Thu, 27 Apr 2017 10:11:22 -0700 [thread overview]
Message-ID: <20170427171126.26814-10-bart.vanassche@sandisk.com> (raw)
In-Reply-To: <20170427171126.26814-1-bart.vanassche@sandisk.com>
Verify at runtime that __pg_init_all_paths() is called with
multipath.lock held if lockdep is enabled.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
---
drivers/md/dm-mpath.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index fc3e7f028110..4e4d53faf2d4 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -298,6 +298,8 @@ static int __pg_init_all_paths(struct multipath *m)
struct pgpath *pgpath;
unsigned long pg_init_delay = 0;
+ lockdep_assert_held(&m->lock);
+
if (atomic_read(&m->pg_init_in_progress) || test_bit(MPATHF_PG_INIT_DISABLED, &m->flags))
return 0;
--
2.12.2
next prev parent reply other threads:[~2017-04-27 17:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 17:11 [PATCH v2 00/13] Device mapper and dm-mpath patches Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 01/13] dm-mpath: Split activate_path() Bart Van Assche
2017-04-27 17:11 ` Bart Van Assche
2017-04-28 5:59 ` [dm-devel] " Hannes Reinecke
2017-04-28 5:59 ` Hannes Reinecke
2017-04-27 17:11 ` [PATCH v2 02/13] dm-mpath: Avoid that path removal can trigger an infinite loop Bart Van Assche
2017-04-27 17:11 ` Bart Van Assche
2017-04-28 5:59 ` [dm-devel] " Hannes Reinecke
2017-04-28 5:59 ` Hannes Reinecke
2017-04-27 17:11 ` [PATCH v2 03/13] dm-mpath: Delay requeuing while path initialization is in progress Bart Van Assche
2017-04-27 17:11 ` Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 04/13] dm-rq: Adjust requeuing delays Bart Van Assche
2017-04-27 19:16 ` Mike Snitzer
2017-04-27 19:52 ` Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 05/13] dm-mpath: Make it easier to analyze requeuing behavior Bart Van Assche
2017-04-27 19:29 ` Mike Snitzer
2017-04-27 19:57 ` Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 06/13] dm-rq: Check blk_mq_register_dev() return value Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 07/13] dm, persistence: Remove an unused argument from dm_block_manager_create() Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 08/13] dm: Verify suspend_locking assumptions at runtime Bart Van Assche
2017-04-27 17:11 ` Bart Van Assche [this message]
2017-04-27 17:11 ` [PATCH v2 10/13] dm: Introduce enum dm_queue_mode Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 11/13] dm-mpath: Micro-optimize the hot path Bart Van Assche
2017-04-27 20:39 ` Mike Snitzer
2017-04-27 17:11 ` [PATCH v2 12/13] dm-mpath: Introduce assign_bit() Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 13/13] dm, dm-mpath: Make it easier to detect unintended I/O request flushes Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170427171126.26814-10-bart.vanassche@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=dm-devel@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.