All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: <linux-btrfs@vger.kernel.org>
Cc: <dsterba@suse.cz>, <lakshmipathi.g@gmail.com>
Subject: [PATCH v4 14/20] btrfs-progs: scrub: Introduce function to verify parities
Date: Thu, 25 May 2017 14:21:59 +0800	[thread overview]
Message-ID: <20170525062205.11660-15-quwenruo@cn.fujitsu.com> (raw)
In-Reply-To: <20170525062205.11660-1-quwenruo@cn.fujitsu.com>

Introduce new function, verify_parities(), to check if parities matches
for full stripe which all data stripes matches with their csum.

Caller should fill the scrub_full_stripe structure properly before
calling this function.

Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
---
 scrub.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 69 insertions(+)

diff --git a/scrub.c b/scrub.c
index 1944f216..ef391ad1 100644
--- a/scrub.c
+++ b/scrub.c
@@ -26,6 +26,7 @@
 #include "disk-io.h"
 #include "utils.h"
 #include "kernel-lib/bitops.h"
+#include "kernel-lib/raid56.h"
 
 /*
  * For parity based profile(RAID56)
@@ -756,3 +757,71 @@ out:
 	btrfs_free_path(path);
 	return ret;
 }
+
+/*
+ * Verify parities for RAID56
+ * Caller must fill @fstripe before calling this function
+ *
+ * Return 0 for parities matches.
+ * Return >0 for P or Q mismatch
+ * Return <0 for fatal error
+ */
+static int verify_parities(struct btrfs_fs_info *fs_info,
+			   struct btrfs_scrub_progress *scrub_ctx,
+			   struct scrub_full_stripe *fstripe)
+{
+	void **ptrs;
+	void *ondisk_p = NULL;
+	void *ondisk_q = NULL;
+	void *buf_p;
+	void *buf_q;
+	int nr_stripes = fstripe->nr_stripes;
+	int stripe_len = BTRFS_STRIPE_LEN;
+	int i;
+	int ret = 0;
+
+	ptrs = malloc(sizeof(void *) * fstripe->nr_stripes);
+	buf_p = malloc(fstripe->stripe_len);
+	buf_q = malloc(fstripe->stripe_len);
+	if (!ptrs || !buf_p || !buf_q) {
+		ret = -ENOMEM;
+		goto out;
+	}
+
+	for (i = 0; i < fstripe->nr_stripes; i++) {
+		struct scrub_stripe *stripe = &fstripe->stripes[i];
+
+		if (stripe->logical == BTRFS_RAID5_P_STRIPE) {
+			ondisk_p = stripe->data;
+			ptrs[i] = buf_p;
+			continue;
+		} else if (stripe->logical == BTRFS_RAID6_Q_STRIPE) {
+			ondisk_q = stripe->data;
+			ptrs[i] = buf_q;
+			continue;
+		} else {
+			ptrs[i] = stripe->data;
+			continue;
+		}
+	}
+	/* RAID6 */
+	if (ondisk_q) {
+		raid6_gen_syndrome(nr_stripes, stripe_len, ptrs);
+
+		if (memcmp(ondisk_q, ptrs[nr_stripes - 1], stripe_len) != 0 ||
+		    memcmp(ondisk_p, ptrs[nr_stripes - 2], stripe_len))
+			ret = 1;
+	} else {
+		ret = raid5_gen_result(nr_stripes, stripe_len, nr_stripes - 1,
+					ptrs);
+		if (ret < 0)
+			goto out;
+		if (memcmp(ondisk_p, ptrs[nr_stripes - 1], stripe_len) != 0)
+			ret = 1;
+	}
+out:
+	free(buf_p);
+	free(buf_q);
+	free(ptrs);
+	return ret;
+}
-- 
2.13.0




  parent reply	other threads:[~2017-05-25  6:22 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25  6:21 [PATCH v4 00/20] Btrfs-progs offline scrub Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 01/20] btrfs-progs: raid56: Introduce raid56 header for later recovery usage Qu Wenruo
2017-05-31 13:25   ` David Sterba
2017-05-25  6:21 ` [PATCH v4 02/20] btrfs-progs: raid56: Introduce tables for RAID6 recovery Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 03/20] btrfs-progs: raid56: Allow raid6 to recover 2 data stripes Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 04/20] btrfs-progs: raid56: Allow raid6 to recover data and p Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 05/20] btrfs-progs: Introduce wrapper to recover raid56 data Qu Wenruo
2017-05-31 13:52   ` David Sterba
2017-06-01  1:04     ` Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 06/20] btrfs-progs: Introduce new btrfs_map_block function which returns more unified result Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 07/20] btrfs-progs: Allow __btrfs_map_block_v2 to remove unrelated stripes Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 08/20] btrfs-progs: csum: Introduce function to read out data csums Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 09/20] btrfs-progs: scrub: Introduce structures to support offline scrub for RAID56 Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 10/20] btrfs-progs: scrub: Introduce functions to scrub mirror based tree block Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 11/20] btrfs-progs: scrub: Introduce functions to scrub mirror based data blocks Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 12/20] btrfs-progs: scrub: Introduce function to scrub one mirror-based extent Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 13/20] btrfs-progs: scrub: Introduce function to scrub one data stripe Qu Wenruo
2017-05-25  6:21 ` Qu Wenruo [this message]
2017-05-25  6:22 ` [PATCH v4 15/20] btrfs-progs: extent-tree: Introduce function to check if there is any extent in given range Qu Wenruo
2017-05-25  6:22 ` [PATCH v4 16/20] btrfs-progs: scrub: Introduce function to recover data parity Qu Wenruo
2017-05-25  6:22 ` [PATCH v4 17/20] btrfs-progs: scrub: Introduce helper to write a full stripe Qu Wenruo
2017-05-25  6:22 ` [PATCH v4 18/20] btrfs-progs: scrub: Introduce a function to scrub one " Qu Wenruo
2017-05-25  6:22 ` [PATCH v4 19/20] btrfs-progs: scrub: Introduce function to check a whole block group Qu Wenruo
2017-05-25  6:22 ` [PATCH v4 20/20] btrfs-progs: scrub: Introduce offline scrub function Qu Wenruo
2017-05-26 18:37 ` [PATCH v4 00/20] Btrfs-progs offline scrub Goffredo Baroncelli
2017-05-29  0:21   ` Qu Wenruo
2017-05-29 16:52     ` Goffredo Baroncelli
2017-05-30 18:54 ` David Sterba
2017-05-31 14:07   ` David Sterba
2017-06-18  6:20 ` Lakshmipathi.G

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170525062205.11660-15-quwenruo@cn.fujitsu.com \
    --to=quwenruo@cn.fujitsu.com \
    --cc=dsterba@suse.cz \
    --cc=lakshmipathi.g@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.