Re: [PATCH v5 1/1] i2c: Add Omnivision OV5670 5M sensor support

[Sakari Ailus <sakari.ailus@iki.fi>]

Hi Chiranjeevi,

On Thu, Jul 13, 2017 at 06:51:27PM -0700, Chiranjeevi Rapolu wrote:
> Provides single source pad with up to 2592x1944 pixels at 10-bit raw
> bayer format over MIPI CSI2 two lanes at 840Mbps/lane.
> The driver supports following features:
> - up to  30fps at 5M pixels
> - manual exposure
> - digital/analog gain
> - V-blank/H-blank
> - test pattern
> - media controller
> - runtime pm
> 
> Signed-off-by: Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>

Thanks, applied with the following change:

diff --git a/drivers/media/i2c/ov5670.c b/drivers/media/i2c/ov5670.c
index 909095ac90a2..7de80645dd6f 100644
--- a/drivers/media/i2c/ov5670.c
+++ b/drivers/media/i2c/ov5670.c
@@ -2060,7 +2060,8 @@ static int ov5670_init_controls(struct ov5670 *ov5670)
 						   &ov5670_ctrl_ops,
 						   V4L2_CID_LINK_FREQ,
 						   0, 0, link_freq_menu_items);
-	ov5670->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
+	if (ov5670->link_freq)
+		ov5670->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
 
 	/* By default, V4L2_CID_PIXEL_RATE is read only */
 	ov5670->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &ov5670_ctrl_ops,

v4l2_ctrl_new_std() may return NULL, you always need to check for that if
you're using the returned result.

-- 
Regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk