All of lore.kernel.org
 help / color / mirror / Atom feed
From: Praveen Kumar <kpraveen.lkml@gmail.com>
To: xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
	konrad.wilk@oracle.com, George.Dunlap@eu.citrix.com,
	andrew.cooper3@citrix.com, dario.faggioli@citrix.com,
	ian.jackson@eu.citrix.com, tim@xen.org, kpraveen.lkml@gmail.com,
	jbeulich@suse.com
Subject: [PATCH v6 16/16 RESEND] rbtree: fix typo in comment of rb_insert_color
Date: Tue, 21 Nov 2017 20:50:09 +0530	[thread overview]
Message-ID: <20171121152009.15591-17-kpraveen.lkml@gmail.com> (raw)
In-Reply-To: <20171121152009.15591-1-kpraveen.lkml@gmail.com>

From: Wei Yang <weiyang@linux.vnet.ibm.com>

In case 1, it passes down the BLACK color from G to p and u, and maintains
the color of n.  By doing so, it maintains the black height of the sub-tree.

While in the comment, it marks the color of n to BLACK.  This is a typo
and not consistents with the code.

This patch fixs this typo in comment.

Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
Acked-by: Michel Lespinasse <walken@google.com>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[Linux commit 1b9c53e849aa65776d4f611d99aa09f856518dad]

Ported to Xen for rb_insert_color API.

Signed-off-by: Praveen Kumar <kpraveen.lkml@gmail.com>
---
 xen/common/rbtree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/common/rbtree.c b/xen/common/rbtree.c
index 5c4e239c24..8977aea487 100644
--- a/xen/common/rbtree.c
+++ b/xen/common/rbtree.c
@@ -135,7 +135,7 @@ void rb_insert_color(struct rb_node *node, struct rb_root *root)
 				 *      / \          / \
 				 *     p   u  -->   P   U
 				 *    /            /
-				 *   n            N
+				 *   n            n
 				 *
 				 * However, since g's parent might be red, and
 				 * 4) does not allow this, we need to recurse
-- 
2.13.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-11-21 15:20 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-21 15:19 [PATCH v6 00/16] xen: common: rbtree: ported updates from Linux tree Praveen Kumar
2017-11-21 15:19 ` [PATCH v6 01/16] rbtree: remove redundant if()-condition in rb_erase() Praveen Kumar
2017-12-20 16:39   ` Jan Beulich
2017-11-21 15:19 ` [PATCH v6 02/16 RESEND] rbtree: empty nodes have no color Praveen Kumar
2017-12-20 16:43   ` Jan Beulich
2017-11-21 15:19 ` [PATCH v6 03/16 RESEND] rbtree: move some implementation details from rbtree.h to rbtree.c Praveen Kumar
2017-12-20 16:46   ` Jan Beulich
2017-11-21 15:19 ` [PATCH v6 04/16 RESEND] rbtree: break out of rb_insert_color loop after tree rotation Praveen Kumar
2017-12-20 16:49   ` Jan Beulich
2017-11-21 15:19 ` [PATCH v6 05/16 RESEND] rbtree: adjust root color in rb_insert_color() only when necessary Praveen Kumar
2017-12-20 16:51   ` Jan Beulich
2017-11-21 15:19 ` [PATCH v6 06/16 RESEND] rbtree: low level optimizations in rb_insert_color() Praveen Kumar
2017-12-20 16:52   ` Jan Beulich
2017-11-21 15:20 ` [PATCH v6 07/16 RESEND] rbtree: adjust node color in __rb_erase_color() only when necessary Praveen Kumar
2017-12-20 16:55   ` Jan Beulich
2017-11-21 15:20 ` [PATCH v6 08/16 RESEND] rbtree: optimize case selection logic in __rb_erase_color() Praveen Kumar
2017-12-20 16:57   ` Jan Beulich
2017-11-21 15:20 ` [PATCH v6 09/16 RESEND] rbtree: low level optimizations " Praveen Kumar
2017-12-20 16:59   ` Jan Beulich
2017-11-21 15:20 ` [PATCH v6 10/16 RESEND] rbtree: coding style adjustments Praveen Kumar
2018-01-03 11:26   ` Jan Beulich
2017-11-21 15:20 ` [PATCH v6 11/16 RESEND] rbtree: optimize fetching of sibling node Praveen Kumar
2018-01-03 11:29   ` Jan Beulich
2017-11-21 15:20 ` [PATCH v6 12/16 RESEND] rbtree: add __rb_change_child() helper function Praveen Kumar
2018-01-03 11:30   ` Jan Beulich
2017-11-21 15:20 ` [PATCH v6 13/16 RESEND] rbtree: place easiest case first in rb_erase() Praveen Kumar
2018-01-03 11:32   ` Jan Beulich
2017-11-21 15:20 ` [PATCH v6 14/16] rbtree: handle 1-child recoloring in rb_erase() instead of rb_erase_color() Praveen Kumar
2018-01-03 11:35   ` Jan Beulich
2017-11-21 15:20 ` [PATCH v6 15/16 RESEND] rbtree: low level optimizations in rb_erase() Praveen Kumar
2018-01-03 11:37   ` Jan Beulich
2017-11-21 15:20 ` Praveen Kumar [this message]
2018-01-03 11:38   ` [PATCH v6 16/16 RESEND] rbtree: fix typo in comment of rb_insert_color Jan Beulich
2017-12-05 16:19 ` [PATCH v6 00/16] xen: common: rbtree: ported updates from Linux tree Praveen Kumar
2017-12-07 15:32   ` Dario Faggioli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171121152009.15591-17-kpraveen.lkml@gmail.com \
    --to=kpraveen.lkml@gmail.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=dario.faggioli@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.