All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: mjg59@srcf.ucam.org, pali.rohar@gmail.com, dvhart@infradead.org,
	andy@infradead.org, mario.limonciello@dell.com, tiwai@suse.com
Cc: platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Kai-Heng Feng <kai.heng.feng@canonical.com>
Subject: [PATCH v2 2/3] platform/x86: dell-*: Add interface for switchable graphics status query
Date: Thu,  8 Mar 2018 17:10:22 +0800	[thread overview]
Message-ID: <20180308091023.9061-2-kai.heng.feng@canonical.com> (raw)
In-Reply-To: <20180308091023.9061-1-kai.heng.feng@canonical.com>

On some Dell platforms, there's a BIOS option "Enable Switchable
Graphics". This information is useful if we want to do different things
based on this value, e.g. disable unused audio controller that comes
with the discrete graphics.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
v2: Mario suggested to squash the HDA part into the same series.
    Forgot to put dell_switchable_gfx_enabled() into header, so put it
    here.

 drivers/platform/x86/dell-laptop.c | 23 +++++++++++++++++++++++
 drivers/platform/x86/dell-smbios.c |  2 ++
 drivers/platform/x86/dell-smbios.h |  2 ++
 include/linux/dell-common.h        |  1 +
 4 files changed, 28 insertions(+)

diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index 8ba820e6c3d0..3f6fc07b8cf2 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -2116,6 +2116,29 @@ int dell_micmute_led_set(int state)
 }
 EXPORT_SYMBOL_GPL(dell_micmute_led_set);
 
+int dell_switchable_gfx_enabled(bool *enabled)
+{
+	struct calling_interface_buffer buffer;
+	struct calling_interface_token *token;
+	int ret;
+
+	*enabled = false;
+
+	token = dell_smbios_find_token(SWITCHABLE_GRAPHICS_ENABLE);
+	if (!token)
+		return -ENODEV;
+
+	dell_fill_request(&buffer, token->location, 0, 0, 0);
+	ret = dell_send_request(&buffer, CLASS_TOKEN_READ, SELECT_TOKEN_STD);
+	if (ret)
+		return ret;
+
+	*enabled = !!buffer.output[1];
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(dell_switchable_gfx_enabled);
+
 static int __init dell_init(void)
 {
 	struct calling_interface_token *token;
diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c
index 8541cde4cb7d..ca38b9d9dcf4 100644
--- a/drivers/platform/x86/dell-smbios.c
+++ b/drivers/platform/x86/dell-smbios.c
@@ -86,6 +86,8 @@ struct token_range {
 static struct token_range token_whitelist[] = {
 	/* used by userspace: fwupdate */
 	{CAP_SYS_ADMIN,	CAPSULE_EN_TOKEN,	CAPSULE_DIS_TOKEN},
+	/* can indicate to userspace Switchable Graphics enable status */
+	{CAP_SYS_ADMIN,	SWITCHABLE_GRAPHICS_ENABLE,	SWITCHABLE_GRAPHICS_DISABLE},
 	/* can indicate to userspace that WMI is needed */
 	{0x0000,	WSMT_EN_TOKEN,		WSMT_DIS_TOKEN}
 };
diff --git a/drivers/platform/x86/dell-smbios.h b/drivers/platform/x86/dell-smbios.h
index 138d478d9adc..b012d4abd239 100644
--- a/drivers/platform/x86/dell-smbios.h
+++ b/drivers/platform/x86/dell-smbios.h
@@ -37,6 +37,8 @@
 #define KBD_LED_AUTO_100_TOKEN	0x02F6
 #define GLOBAL_MIC_MUTE_ENABLE	0x0364
 #define GLOBAL_MIC_MUTE_DISABLE	0x0365
+#define SWITCHABLE_GRAPHICS_ENABLE	0x037A
+#define SWITCHABLE_GRAPHICS_DISABLE	0x037B
 
 struct notifier_block;
 
diff --git a/include/linux/dell-common.h b/include/linux/dell-common.h
index 37e4b614dd74..4435c5717388 100644
--- a/include/linux/dell-common.h
+++ b/include/linux/dell-common.h
@@ -3,5 +3,6 @@
 #define __DELL_COMMON_H__
 
 int dell_micmute_led_set(int on);
+int dell_switchable_gfx_enabled(bool *enabled);
 
 #endif
-- 
2.15.1

  reply	other threads:[~2018-03-08  9:10 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08  9:10 [PATCH v2 1/3] dell-led: Change dell-led.h to dell-common.h Kai-Heng Feng
2018-03-08  9:10 ` Kai-Heng Feng [this message]
2018-03-08 16:38   ` [PATCH v2 2/3] platform/x86: dell-*: Add interface for switchable graphics status query Pali Rohár
2018-03-08 16:38     ` Pali Rohár
2018-03-09  8:14     ` Kai Heng Feng
2018-03-08  9:10 ` [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics Kai-Heng Feng
2018-03-08  9:38   ` [alsa-devel] " Lukas Wunner
2018-03-08 10:38     ` Kai Heng Feng
2018-03-08 10:38       ` Kai Heng Feng
2018-03-08 11:30       ` [alsa-devel] " Lukas Wunner
2018-03-08 11:30         ` Lukas Wunner
2018-03-09  8:22         ` [alsa-devel] " Kai Heng Feng
2018-03-09  9:02   ` Pali Rohár
2018-03-09  9:02     ` Pali Rohár
2018-03-09  9:30     ` Kai Heng Feng
2018-03-09  9:34       ` Mario.Limonciello
2018-03-09  9:34         ` Mario.Limonciello
2018-03-09  9:46         ` Pali Rohár
2018-03-09  9:46           ` Pali Rohár
2018-03-09  9:59           ` Mario.Limonciello
2018-03-09  9:59             ` Mario.Limonciello
2018-03-10 10:38             ` Pali Rohár
2018-03-10 10:38               ` Pali Rohár
2018-03-11 14:03               ` Mario.Limonciello
2018-03-11 14:03                 ` Mario.Limonciello
2018-03-11 14:30                 ` Pali Rohár
2018-03-11 14:30                   ` Pali Rohár
2018-03-12  1:30                   ` Mario.Limonciello
2018-03-12  1:30                     ` Mario.Limonciello
2018-03-13  7:56                     ` Kai Heng Feng
2018-03-13  7:56                       ` Kai Heng Feng
2018-03-13  8:13                       ` Mario.Limonciello
2018-03-13  8:13                         ` Mario.Limonciello
2018-03-10  6:50       ` Lukas Wunner
2018-03-10  6:50         ` Lukas Wunner
2018-03-10 10:40         ` Pali Rohár
2018-03-10 10:40           ` Pali Rohár
2018-03-11 14:06         ` Mario.Limonciello
2018-03-11 14:06           ` Mario.Limonciello
2018-03-13  8:24         ` Kai Heng Feng
2018-04-07 16:44 ` [PATCH v2 1/3] dell-led: Change dell-led.h to dell-common.h Darren Hart
2018-04-07 16:44   ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180308091023.9061-2-kai.heng.feng@canonical.com \
    --to=kai.heng.feng@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andy@infradead.org \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@dell.com \
    --cc=mjg59@srcf.ucam.org \
    --cc=pali.rohar@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.