From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v6 04/12] drm/i915: Add i915_gem_fini_hw to i915_gem_suspend
Date: Wed, 4 Apr 2018 21:07:16 +0000 [thread overview]
Message-ID: <20180404210724.3416-4-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20180404210724.3416-1-michal.wajdeczko@intel.com>
By calling i915_gem_init_hw in i915_gem_resume and not calling
i915_gem_fini_hw in i915_gem_suspend we introduced asymmetry
in init_hw/fini_hw calls. Let's fix that.
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_gem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 701f137..f5ef02d 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -4986,6 +4986,7 @@ int i915_gem_suspend(struct drm_i915_private *dev_priv)
* machines is a good idea, we don't - just in case it leaves the
* machine in an unusable condition.
*/
+ i915_gem_fini_hw(dev_priv);
intel_uc_sanitize(dev_priv);
i915_gem_sanitize(dev_priv);
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-04-04 21:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 21:07 [PATCH v6 01/12] drm/i915: Correctly handle error path in i915_gem_init_hw Michal Wajdeczko
2018-04-04 21:07 ` [PATCH v6 02/12] drm/i915: Move i915_gem_fini to i915_gem.c Michal Wajdeczko
2018-04-04 21:07 ` [PATCH v6 03/12] drm/i915: Introduce i915_gem_fini_hw for symmetry with i915_gem_init_hw Michal Wajdeczko
2018-04-04 21:07 ` Michal Wajdeczko [this message]
2018-04-04 21:07 ` [PATCH v6 05/12] drm/i915: Add i915_gem_fini_hw to i915_reset Michal Wajdeczko
2018-04-04 21:07 ` [PATCH v6 06/12] drm/i915/guc: Ignore dev_priv->gt.awake while disabling submission Michal Wajdeczko
2018-04-04 21:07 ` [PATCH v6 07/12] drm/i915/guc: Restore symmetric doorbell cleanup Michal Wajdeczko
2018-04-04 21:07 ` [PATCH v6 08/12] drm/i915/uc: Fully sanitize uC within intel_uc_fini_hw Michal Wajdeczko
2018-04-04 21:07 ` [PATCH v6 09/12] drm/i915/uc: Use correct error code for GuC initialization failure Michal Wajdeczko
2018-04-04 21:07 ` [PATCH v6 10/12] drm/i915/uc: Use helper functions to detect fw load status Michal Wajdeczko
2018-04-04 21:07 ` [PATCH v6 11/12] drm/i915/uc: Trivial s/dev_priv/i915 in intel_uc.c Michal Wajdeczko
2018-04-04 21:07 ` [PATCH v6 12/12] HAX: Enable GuC for CI Michal Wajdeczko
2018-04-04 21:57 ` ✓ Fi.CI.BAT: success for series starting with [v6,01/12] drm/i915: Correctly handle error path in i915_gem_init_hw Patchwork
2018-04-05 0:33 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-04-05 10:02 ` Sagar Arun Kamble
2018-04-05 10:19 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180404210724.3416-4-michal.wajdeczko@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.