From: "Luis R. Rodriguez" <mcgrof@kernel.org> To: gregkh@linuxfoundation.org Cc: akpm@linux-foundation.org, keescook@chromium.org, josh@joshtriplett.org, maco@android.com, andy.gross@linaro.org, david.brown@linaro.org, bjorn.andersson@linaro.org, teg@jklm.no, wagi@monom.org, hdegoede@redhat.com, andresx7@gmail.com, zohar@linux.vnet.ibm.com, kubakici@wp.pl, shuah@kernel.org, mfuzzey@parkeon.com, dhowells@redhat.com, pali.rohar@gmail.com, tiwai@suse.de, kvalo@codeaurora.org, arend.vanspriel@broadcom.com, zajec5@gmail.com, nbroeking@me.com, markivx@codeaurora.org, broonie@kernel.org, dmitry.torokhov@gmail.com, dwmw2@infradead.org, torvalds@linux-foundation.org, Abhay_Salunke@dell.com, jewalt@lgsinnovations.com, oneukum@suse.com, cantabile.desu@gmail.com, ast@fb.com, hare@suse.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, khc@pm.waw.pl, davem@davemloft.net, arve@android.com, tkjos@android.com, corbet@lwn.net, mchehab+samsung@kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, "Luis R . Rodriguez" <mcgrof@kernel.org> Subject: [PATCH v6 10/13] ath10k: re-enable the firmware fallback mechanism for testmode Date: Tue, 8 May 2018 11:12:44 -0700 [thread overview] Message-ID: <20180508181247.19431-11-mcgrof@kernel.org> (raw) In-Reply-To: <20180508181247.19431-1-mcgrof@kernel.org> From: Andres Rodriguez <andresx7@gmail.com> The ath10k testmode uses request_firmware_direct() in order to avoid producing firmware load warnings. Disabling the fallback mechanism was a side effect of disabling warnings. We now have a new API that allows us to avoid warnings while keeping the fallback mechanism enabled. So use that instead. Signed-off-by: Andres Rodriguez <andresx7@gmail.com> Acked-by: Kalle Valo <kvalo@codeaurora.org> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> --- drivers/net/wireless/ath/ath10k/testmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/testmode.c b/drivers/net/wireless/ath/ath10k/testmode.c index 568810b41657..c24ee616833c 100644 --- a/drivers/net/wireless/ath/ath10k/testmode.c +++ b/drivers/net/wireless/ath/ath10k/testmode.c @@ -157,7 +157,7 @@ static int ath10k_tm_fetch_utf_firmware_api_1(struct ath10k *ar, ar->hw_params.fw.dir, ATH10K_FW_UTF_FILE); /* load utf firmware image */ - ret = request_firmware_direct(&fw_file->firmware, filename, ar->dev); + ret = firmware_request_nowarn(&fw_file->firmware, filename, ar->dev); ath10k_dbg(ar, ATH10K_DBG_TESTMODE, "testmode fw request '%s': %d\n", filename, ret); -- 2.17.0
WARNING: multiple messages have this Message-ID (diff)
From: "Luis R. Rodriguez" <mcgrof@kernel.org> To: gregkh@linuxfoundation.org Cc: akpm@linux-foundation.org, keescook@chromium.org, josh@joshtriplett.org, maco@android.com, andy.gross@linaro.org, david.brown@linaro.org, bjorn.andersson@linaro.org, teg@jklm.no, wagi@monom.org, hdegoede@redhat.com, andresx7@gmail.com, zohar@linux.vnet.ibm.com, kubakici@wp.pl, shuah@kernel.org, mfuzzey@parkeon.com, dhowells@redhat.com, pali.rohar@gmail.com, tiwai@suse.de, kvalo@codeaurora.org, arend.vanspriel@broadcom.com, zajec5@gmail.com, nbroeking@me.com, markivx@codeaurora.org, broonie@kernel.org, dmitry.torokhov@gmail.com, dwmw2@infradead.org, torvalds@linux-foundation.org, Abhay_Salunke@dell.com, jewalt@lgsinnovations.com, oneukum@suse.com, cantabile.desu@gmail.com, ast@fb.com, hare@suse.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, khc@pm.waw.pl, davem@davemloft. Subject: [PATCH v6 10/13] ath10k: re-enable the firmware fallback mechanism for testmode Date: Tue, 8 May 2018 11:12:44 -0700 [thread overview] Message-ID: <20180508181247.19431-11-mcgrof@kernel.org> (raw) In-Reply-To: <20180508181247.19431-1-mcgrof@kernel.org> From: Andres Rodriguez <andresx7@gmail.com> The ath10k testmode uses request_firmware_direct() in order to avoid producing firmware load warnings. Disabling the fallback mechanism was a side effect of disabling warnings. We now have a new API that allows us to avoid warnings while keeping the fallback mechanism enabled. So use that instead. Signed-off-by: Andres Rodriguez <andresx7@gmail.com> Acked-by: Kalle Valo <kvalo@codeaurora.org> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> --- drivers/net/wireless/ath/ath10k/testmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/testmode.c b/drivers/net/wireless/ath/ath10k/testmode.c index 568810b41657..c24ee616833c 100644 --- a/drivers/net/wireless/ath/ath10k/testmode.c +++ b/drivers/net/wireless/ath/ath10k/testmode.c @@ -157,7 +157,7 @@ static int ath10k_tm_fetch_utf_firmware_api_1(struct ath10k *ar, ar->hw_params.fw.dir, ATH10K_FW_UTF_FILE); /* load utf firmware image */ - ret = request_firmware_direct(&fw_file->firmware, filename, ar->dev); + ret = firmware_request_nowarn(&fw_file->firmware, filename, ar->dev); ath10k_dbg(ar, ATH10K_DBG_TESTMODE, "testmode fw request '%s': %d\n", filename, ret); -- 2.17.0
next prev parent reply other threads:[~2018-05-08 18:13 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-08 18:12 [PATCH v6 00/13] firmware_loader changes for v4.18 Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 01/13] firmware: wrap FW_OPT_* into an enum Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 02/13] firmware: use () to terminate kernel-doc function names Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 03/13] firmware: rename fw_sysfs_fallback to firmware_fallback_sysfs() Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 04/13] firmware_loader: document firmware_sysfs_fallback() Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 05/13] firmware_loader: enhance Kconfig documentation over FW_LOADER Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 22:42 ` Kees Cook 2018-05-08 22:42 ` Kees Cook 2018-05-09 20:55 ` Luis R. Rodriguez 2018-05-09 20:55 ` Luis R. Rodriguez 2018-05-09 23:01 ` Kees Cook 2018-05-09 23:01 ` Kees Cook 2018-05-08 18:12 ` [PATCH v6 06/13] firmware_loader: move kconfig FW_LOADER entries to its own file Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 07/13] firmware_loader: make firmware_fallback_sysfs() print more useful Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 08/13] firmware: add firmware_request_nowarn() - load firmware without warnings Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 09/13] ath10k: use firmware_request_nowarn() to load firmware Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez [this message] 2018-05-08 18:12 ` [PATCH v6 10/13] ath10k: re-enable the firmware fallback mechanism for testmode Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 11/13] Documentation: fix few typos and clarifications for the firmware loader Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 12/13] Documentation: remove stale firmware API reference Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-09 15:12 ` Mauro Carvalho Chehab 2018-05-09 15:12 ` Mauro Carvalho Chehab 2018-05-09 19:43 ` Luis R. Rodriguez 2018-05-09 19:43 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 13/13] Documentation: clarify firmware_class provenance and why we can't rename the module Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:53 ` Andres Rodriguez 2018-05-08 18:53 ` Andres Rodriguez 2018-05-09 13:21 ` Mauro Carvalho Chehab 2018-05-09 13:21 ` Mauro Carvalho Chehab 2018-05-08 22:45 ` [PATCH v6 00/13] firmware_loader changes for v4.18 Kees Cook 2018-05-08 22:45 ` Kees Cook
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180508181247.19431-11-mcgrof@kernel.org \ --to=mcgrof@kernel.org \ --cc=Abhay_Salunke@dell.com \ --cc=akpm@linux-foundation.org \ --cc=andresx7@gmail.com \ --cc=andy.gross@linaro.org \ --cc=arend.vanspriel@broadcom.com \ --cc=arve@android.com \ --cc=ast@fb.com \ --cc=bjorn.andersson@linaro.org \ --cc=broonie@kernel.org \ --cc=cantabile.desu@gmail.com \ --cc=corbet@lwn.net \ --cc=davem@davemloft.net \ --cc=david.brown@linaro.org \ --cc=dhowells@redhat.com \ --cc=dmitry.torokhov@gmail.com \ --cc=dwmw2@infradead.org \ --cc=gregkh@linuxfoundation.org \ --cc=hare@suse.com \ --cc=hdegoede@redhat.com \ --cc=jejb@linux.vnet.ibm.com \ --cc=jewalt@lgsinnovations.com \ --cc=josh@joshtriplett.org \ --cc=keescook@chromium.org \ --cc=khc@pm.waw.pl \ --cc=kubakici@wp.pl \ --cc=kvalo@codeaurora.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=maco@android.com \ --cc=markivx@codeaurora.org \ --cc=martin.petersen@oracle.com \ --cc=mchehab+samsung@kernel.org \ --cc=mfuzzey@parkeon.com \ --cc=nbroeking@me.com \ --cc=netdev@vger.kernel.org \ --cc=oneukum@suse.com \ --cc=pali.rohar@gmail.com \ --cc=shuah@kernel.org \ --cc=teg@jklm.no \ --cc=tiwai@suse.de \ --cc=tkjos@android.com \ --cc=torvalds@linux-foundation.org \ --cc=wagi@monom.org \ --cc=zajec5@gmail.com \ --cc=zohar@linux.vnet.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.