All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Toshi Kani <toshi.kani@hpe.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org
Subject: [PATCH v2 7/7] dm-error: remove unnecessary direct_access() stub
Date: Tue, 29 May 2018 13:51:06 -0600	[thread overview]
Message-ID: <20180529195106.14268-8-ross.zwisler@linux.intel.com> (raw)
In-Reply-To: <20180529195106.14268-1-ross.zwisler@linux.intel.com>

This stub was added so that we could use dm-error with
DM_TYPE_DAX_BIO_BASED mode devices.  That mode and the transition issues
associated with it no longer exist, so we can remove this dead code.

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
---
 drivers/md/dm-target.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/md/dm-target.c b/drivers/md/dm-target.c
index 314d17ca6466..c4dbc15f7862 100644
--- a/drivers/md/dm-target.c
+++ b/drivers/md/dm-target.c
@@ -140,12 +140,6 @@ static void io_err_release_clone_rq(struct request *clone)
 {
 }
 
-static long io_err_dax_direct_access(struct dm_target *ti, pgoff_t pgoff,
-		long nr_pages, void **kaddr, pfn_t *pfn)
-{
-	return -EIO;
-}
-
 static struct target_type error_target = {
 	.name = "error",
 	.version = {1, 5, 0},
@@ -155,7 +149,6 @@ static struct target_type error_target = {
 	.map  = io_err_map,
 	.clone_and_map_rq = io_err_clone_and_map_rq,
 	.release_clone_rq = io_err_release_clone_rq,
-	.direct_access = io_err_dax_direct_access,
 };
 
 int __init dm_target_init(void)
-- 
2.14.3

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Toshi Kani <toshi.kani@hpe.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org
Subject: [PATCH v2 7/7] dm-error: remove unnecessary direct_access() stub
Date: Tue, 29 May 2018 13:51:06 -0600	[thread overview]
Message-ID: <20180529195106.14268-8-ross.zwisler@linux.intel.com> (raw)
In-Reply-To: <20180529195106.14268-1-ross.zwisler@linux.intel.com>

This stub was added so that we could use dm-error with
DM_TYPE_DAX_BIO_BASED mode devices.  That mode and the transition issues
associated with it no longer exist, so we can remove this dead code.

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
---
 drivers/md/dm-target.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/md/dm-target.c b/drivers/md/dm-target.c
index 314d17ca6466..c4dbc15f7862 100644
--- a/drivers/md/dm-target.c
+++ b/drivers/md/dm-target.c
@@ -140,12 +140,6 @@ static void io_err_release_clone_rq(struct request *clone)
 {
 }
 
-static long io_err_dax_direct_access(struct dm_target *ti, pgoff_t pgoff,
-		long nr_pages, void **kaddr, pfn_t *pfn)
-{
-	return -EIO;
-}
-
 static struct target_type error_target = {
 	.name = "error",
 	.version = {1, 5, 0},
@@ -155,7 +149,6 @@ static struct target_type error_target = {
 	.map  = io_err_map,
 	.clone_and_map_rq = io_err_clone_and_map_rq,
 	.release_clone_rq = io_err_release_clone_rq,
-	.direct_access = io_err_dax_direct_access,
 };
 
 int __init dm_target_init(void)
-- 
2.14.3

WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Toshi Kani <toshi.kani-ZPxbGqLxI0U@public.gmane.org>,
	Mike Snitzer <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org
Subject: [PATCH v2 7/7] dm-error: remove unnecessary direct_access() stub
Date: Tue, 29 May 2018 13:51:06 -0600	[thread overview]
Message-ID: <20180529195106.14268-8-ross.zwisler@linux.intel.com> (raw)
In-Reply-To: <20180529195106.14268-1-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

This stub was added so that we could use dm-error with
DM_TYPE_DAX_BIO_BASED mode devices.  That mode and the transition issues
associated with it no longer exist, so we can remove this dead code.

Signed-off-by: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
 drivers/md/dm-target.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/md/dm-target.c b/drivers/md/dm-target.c
index 314d17ca6466..c4dbc15f7862 100644
--- a/drivers/md/dm-target.c
+++ b/drivers/md/dm-target.c
@@ -140,12 +140,6 @@ static void io_err_release_clone_rq(struct request *clone)
 {
 }
 
-static long io_err_dax_direct_access(struct dm_target *ti, pgoff_t pgoff,
-		long nr_pages, void **kaddr, pfn_t *pfn)
-{
-	return -EIO;
-}
-
 static struct target_type error_target = {
 	.name = "error",
 	.version = {1, 5, 0},
@@ -155,7 +149,6 @@ static struct target_type error_target = {
 	.map  = io_err_map,
 	.clone_and_map_rq = io_err_clone_and_map_rq,
 	.release_clone_rq = io_err_release_clone_rq,
-	.direct_access = io_err_dax_direct_access,
 };
 
 int __init dm_target_init(void)
-- 
2.14.3

  parent reply	other threads:[~2018-05-29 19:51 UTC|newest]

Thread overview: 119+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29 19:50 [PATCH v2 0/7] Fix DM DAX handling Ross Zwisler
2018-05-29 19:50 ` Ross Zwisler
2018-05-29 19:50 ` Ross Zwisler
2018-05-29 19:51 ` [PATCH v2 1/7] fs: allow per-device dax status checking for filesystems Ross Zwisler
2018-05-29 19:51   ` Ross Zwisler
2018-05-29 19:51   ` Ross Zwisler
2018-05-29 19:51 ` [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns Ross Zwisler
2018-05-29 19:51   ` Ross Zwisler
2018-05-29 19:51   ` Ross Zwisler
2018-05-29 21:25   ` Darrick J. Wong
2018-05-29 21:25     ` Darrick J. Wong
2018-05-29 21:25     ` Darrick J. Wong
2018-05-29 22:01     ` Ross Zwisler
2018-05-29 22:01       ` Ross Zwisler
2018-05-31 19:13       ` Darrick J. Wong
2018-05-31 19:13         ` Darrick J. Wong
2018-05-31 19:13         ` Darrick J. Wong
2018-05-31 20:34         ` Ross Zwisler
2018-05-31 20:34           ` Ross Zwisler
2018-05-31 20:34           ` Ross Zwisler
2018-05-31 20:35         ` Dan Williams
2018-05-31 20:35           ` Dan Williams
2018-05-31 20:35           ` Dan Williams
2018-05-31 20:41         ` Ross Zwisler
2018-05-31 20:41           ` Ross Zwisler
2018-05-31 20:41           ` Ross Zwisler
2018-05-31 20:52         ` Mike Snitzer
2018-05-31 20:52           ` Mike Snitzer
2018-05-31 20:52           ` Mike Snitzer
2018-05-31 22:26           ` [dm-devel] " Darrick J. Wong
2018-05-31 22:26             ` Darrick J. Wong
2018-05-31 22:26             ` Darrick J. Wong
2018-06-01 20:59             ` Ross Zwisler
2018-06-01 20:59               ` Ross Zwisler
2018-06-01 20:59               ` Ross Zwisler
2018-06-01  1:26         ` Dave Chinner
2018-06-01  1:26           ` Dave Chinner
2018-06-01  1:57           ` Dan Williams
2018-06-01  1:57             ` Dan Williams
2018-06-01  2:24             ` Dave Chinner
2018-06-01  2:24               ` Dave Chinner
2018-06-01  2:24               ` Dave Chinner
2018-06-01  4:02               ` Dan Williams
2018-06-01  4:02                 ` Dan Williams
2018-06-01  4:02                 ` Dan Williams
2018-06-03 22:20                 ` Dave Chinner
2018-06-03 22:20                   ` Dave Chinner
2018-06-04  0:25                   ` Dave Chinner
2018-06-04  0:25                     ` Dave Chinner
2018-06-04  0:25                     ` Dave Chinner
2018-06-04  1:48                     ` Dan Williams
2018-06-04  1:48                       ` Dan Williams
2018-06-04  1:48                       ` Dan Williams
2018-06-04 23:40                       ` Dan Williams
2018-06-04 23:40                         ` Dan Williams
2018-06-04 23:40                         ` Dan Williams
2018-06-05  0:33                         ` Mike Snitzer
2018-06-05  0:33                           ` Mike Snitzer
2018-06-05  0:33                           ` Mike Snitzer
2018-06-05  5:55                           ` Dave Chinner
2018-06-05  5:55                             ` Dave Chinner
2018-06-05  5:55                             ` Dave Chinner
2018-06-05  3:32                         ` Dan Williams
2018-06-05  3:32                           ` Dan Williams
2018-05-29 19:51 ` [PATCH v2 3/7] dm: fix test for DAX device support Ross Zwisler
2018-05-29 19:51   ` Ross Zwisler
2018-05-29 19:51   ` Ross Zwisler
2018-06-01 20:19   ` Mike Snitzer
2018-06-01 20:19     ` Mike Snitzer
2018-06-01 20:19     ` Mike Snitzer
2018-06-01 20:46     ` Mike Snitzer
2018-06-01 20:46       ` Mike Snitzer
2018-06-01 20:46       ` Mike Snitzer
2018-06-01 21:11       ` Ross Zwisler
2018-06-01 21:11         ` Ross Zwisler
2018-06-01 21:11         ` Ross Zwisler
2018-06-01 21:16       ` Dan Williams
2018-06-01 21:16         ` Dan Williams
2018-06-01 21:16         ` Dan Williams
2018-05-29 19:51 ` [PATCH v2 4/7] dm: prevent DAX mounts if not supported Ross Zwisler
2018-05-29 19:51   ` Ross Zwisler
2018-05-29 19:51   ` Ross Zwisler
2018-06-01 21:55   ` Mike Snitzer
2018-06-01 21:55     ` Mike Snitzer
2018-06-01 21:55     ` Mike Snitzer
2018-06-04 23:15     ` Ross Zwisler
2018-06-04 23:15       ` Ross Zwisler
2018-06-04 23:15       ` Ross Zwisler
2018-06-20 15:17       ` Mike Snitzer
2018-06-20 15:17         ` Mike Snitzer
2018-06-25 19:20         ` Ross Zwisler
2018-06-25 19:20           ` Ross Zwisler
2018-05-29 19:51 ` [PATCH v2 5/7] dm: remove DM_TYPE_DAX_BIO_BASED dm_queue_mode Ross Zwisler
2018-05-29 19:51   ` Ross Zwisler
2018-05-29 19:51   ` Ross Zwisler
2018-06-01 22:04   ` Mike Snitzer
2018-06-01 22:04     ` Mike Snitzer
2018-06-01 22:04     ` Mike Snitzer
2018-06-04 23:24     ` Ross Zwisler
2018-06-04 23:24       ` Ross Zwisler
2018-06-04 23:24       ` Ross Zwisler
2018-06-04 23:49       ` Kani, Toshi
2018-06-04 23:49         ` Kani, Toshi
2018-06-04 23:49         ` Kani, Toshi
2018-06-05  0:46       ` Mike Snitzer
2018-06-05  0:46         ` Mike Snitzer
2018-06-05  0:46         ` Mike Snitzer
2018-06-06 17:24         ` Ross Zwisler
2018-06-06 17:24           ` Ross Zwisler
2018-06-06 17:24           ` Ross Zwisler
2018-06-06 22:29           ` Mike Snitzer
2018-06-06 22:29             ` Mike Snitzer
2018-06-06 22:29             ` Mike Snitzer
2018-05-29 19:51 ` [PATCH v2 6/7] dm-snap: remove unnecessary direct_access() stub Ross Zwisler
2018-05-29 19:51   ` Ross Zwisler
2018-05-29 19:51   ` Ross Zwisler
2018-05-29 19:51 ` Ross Zwisler [this message]
2018-05-29 19:51   ` [PATCH v2 7/7] dm-error: " Ross Zwisler
2018-05-29 19:51   ` Ross Zwisler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180529195106.14268-8-ross.zwisler@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=snitzer@redhat.com \
    --cc=toshi.kani@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.