From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-usb@vger.kernel.org, tglx@linutronix.de,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Hans Verkuil <hverkuil@xs4all.nl>
Subject: [PATCH 25/27] media: usbvision: remove time_in_irq
Date: Wed, 20 Jun 2018 13:01:03 +0200 [thread overview]
Message-ID: <20180620110105.19955-26-bigeasy@linutronix.de> (raw)
In-Reply-To: <20180620110105.19955-1-bigeasy@linutronix.de>
Time "in interrupt" accounting with the help of `jiffies' is a pointless
exercise. This variable isn't even used.
Remove time_in_irq.
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/media/usb/usbvision/usbvision-core.c | 3 ---
drivers/media/usb/usbvision/usbvision.h | 1 -
2 files changed, 4 deletions(-)
diff --git a/drivers/media/usb/usbvision/usbvision-core.c b/drivers/media/usb/usbvision/usbvision-core.c
index 7138c2b606cc..31e0e98d6daf 100644
--- a/drivers/media/usb/usbvision/usbvision-core.c
+++ b/drivers/media/usb/usbvision/usbvision-core.c
@@ -1272,7 +1272,6 @@ static void usbvision_isoc_irq(struct urb *urb)
int len;
struct usb_usbvision *usbvision = urb->context;
int i;
- unsigned long start_time = jiffies;
struct usbvision_frame **f;
/* We don't want to do anything if we are about to be removed! */
@@ -1324,8 +1323,6 @@ static void usbvision_isoc_irq(struct urb *urb)
scratch_reset(usbvision);
}
- usbvision->time_in_irq += jiffies - start_time;
-
for (i = 0; i < USBVISION_URB_FRAMES; i++) {
urb->iso_frame_desc[i].status = 0;
urb->iso_frame_desc[i].actual_length = 0;
diff --git a/drivers/media/usb/usbvision/usbvision.h b/drivers/media/usb/usbvision/usbvision.h
index 6ecdcd58248f..017e7baf5747 100644
--- a/drivers/media/usb/usbvision/usbvision.h
+++ b/drivers/media/usb/usbvision/usbvision.h
@@ -447,7 +447,6 @@ struct usb_usbvision {
unsigned long isoc_skip_count; /* How many empty ISO packets received */
unsigned long isoc_err_count; /* How many bad ISO packets received */
unsigned long isoc_packet_count; /* How many packets we totally got */
- unsigned long time_in_irq; /* How long do we need for interrupt */
int isoc_measure_bandwidth_count;
int frame_num; /* How many video frames we send to user */
int max_strip_len; /* How big is the biggest strip */
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-usb@vger.kernel.org, tglx@linutronix.de,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Hans Verkuil <hverkuil@xs4all.nl>
Subject: [25/27] media: usbvision: remove time_in_irq
Date: Wed, 20 Jun 2018 13:01:03 +0200 [thread overview]
Message-ID: <20180620110105.19955-26-bigeasy@linutronix.de> (raw)
Time "in interrupt" accounting with the help of `jiffies' is a pointless
exercise. This variable isn't even used.
Remove time_in_irq.
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/media/usb/usbvision/usbvision-core.c | 3 ---
drivers/media/usb/usbvision/usbvision.h | 1 -
2 files changed, 4 deletions(-)
diff --git a/drivers/media/usb/usbvision/usbvision-core.c b/drivers/media/usb/usbvision/usbvision-core.c
index 7138c2b606cc..31e0e98d6daf 100644
--- a/drivers/media/usb/usbvision/usbvision-core.c
+++ b/drivers/media/usb/usbvision/usbvision-core.c
@@ -1272,7 +1272,6 @@ static void usbvision_isoc_irq(struct urb *urb)
int len;
struct usb_usbvision *usbvision = urb->context;
int i;
- unsigned long start_time = jiffies;
struct usbvision_frame **f;
/* We don't want to do anything if we are about to be removed! */
@@ -1324,8 +1323,6 @@ static void usbvision_isoc_irq(struct urb *urb)
scratch_reset(usbvision);
}
- usbvision->time_in_irq += jiffies - start_time;
-
for (i = 0; i < USBVISION_URB_FRAMES; i++) {
urb->iso_frame_desc[i].status = 0;
urb->iso_frame_desc[i].actual_length = 0;
diff --git a/drivers/media/usb/usbvision/usbvision.h b/drivers/media/usb/usbvision/usbvision.h
index 6ecdcd58248f..017e7baf5747 100644
--- a/drivers/media/usb/usbvision/usbvision.h
+++ b/drivers/media/usb/usbvision/usbvision.h
@@ -447,7 +447,6 @@ struct usb_usbvision {
unsigned long isoc_skip_count; /* How many empty ISO packets received */
unsigned long isoc_err_count; /* How many bad ISO packets received */
unsigned long isoc_packet_count; /* How many packets we totally got */
- unsigned long time_in_irq; /* How long do we need for interrupt */
int isoc_measure_bandwidth_count;
int frame_num; /* How many video frames we send to user */
int max_strip_len; /* How big is the biggest strip */
next prev parent reply other threads:[~2018-06-20 11:01 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 11:00 medial: use irqsave() in URB completion + usb_fill_int_urb Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 01/27] media: b2c2: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [01/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 02/27] media: cpia2_usb: " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [02/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 03/27] media: cx231xx: use usb_fill_XXX_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [03/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 04/27] media: cx231xx: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
2018-06-20 11:00 ` [04/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 05/27] media: dvb-usb: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [05/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 06/27] media: dvb_usb_v2: " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [06/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 07/27] media: em28xx-audio: use GFP_KERNEL for memory allocation during init Sebastian Andrzej Siewior
2018-06-20 11:00 ` [07/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 08/27] media: em28xx-audio: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
2018-06-20 11:00 ` [08/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 09/27] media: em28xx-audio: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [09/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 10/27] media: go7007: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
2018-06-20 11:00 ` [10/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 11/27] media: gspca: benq: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [11/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 12/27] media: gspca: gspca: use usb_fill_XXX_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [12/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 13/27] media: gspca: konica: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [13/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 14/27] media: gspca: sq930x: use GFP_KERNEL in sd_dq_callback() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [14/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 15/27] media: msi2500: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [15/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 16/27] media: pwc: " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [16/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 17/27] media: stk1160: " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [17/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 18/27] media: stkwebcam: " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [18/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 19/27] media: tm6000: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
2018-06-20 11:00 ` [19/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 20/27] media: ttusb-budget: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [20/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 21/27] media: ttusb-dec: " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [21/27] " Sebastian Andrzej Siewior
2018-06-20 11:01 ` [PATCH 22/27] media: ttusbir: " Sebastian Andrzej Siewior
2018-06-20 11:01 ` [22/27] " Sebastian Andrzej Siewior
2018-06-20 20:50 ` [PATCH 22/27] " Sean Young
2018-06-20 20:50 ` [22/27] " Sean Young
2018-06-21 7:37 ` [PATCH 22/27] " Sebastian Andrzej Siewior
2018-06-21 7:37 ` [22/27] " Sebastian Andrzej Siewior
2018-06-20 11:01 ` [PATCH 23/27] media: usbtv: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
2018-06-20 11:01 ` [23/27] " Sebastian Andrzej Siewior
2018-06-20 11:01 ` [PATCH 24/27] media: usbtv: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:01 ` [24/27] " Sebastian Andrzej Siewior
2018-06-20 11:01 ` Sebastian Andrzej Siewior [this message]
2018-06-20 11:01 ` [25/27] media: usbvision: remove time_in_irq Sebastian Andrzej Siewior
2018-06-20 11:01 ` [PATCH 26/27] media: usbvision: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:01 ` [26/27] " Sebastian Andrzej Siewior
2018-06-20 11:01 ` [PATCH 27/27] media: uvcvideo: " Sebastian Andrzej Siewior
2018-06-20 11:01 ` [27/27] " Sebastian Andrzej Siewior
2018-06-20 11:55 ` [PATCH 27/27] " Laurent Pinchart
2018-06-20 11:55 ` [27/27] " Laurent Pinchart
2018-06-20 13:21 ` [PATCH 27/27] " Sebastian Andrzej Siewior
2018-06-20 13:21 ` [27/27] " Sebastian Andrzej Siewior
2018-06-20 14:14 ` [PATCH 27/27] " Laurent Pinchart
2018-06-20 14:14 ` [27/27] " Laurent Pinchart
2018-06-20 15:20 ` [PATCH] USB: note that usb_fill_int_urb() can be used used for ISOC urbs Sebastian Andrzej Siewior
2018-06-20 15:20 ` Sebastian Andrzej Siewior
2018-06-20 15:35 ` [PATCH] " Alan Stern
2018-06-20 15:35 ` Alan Stern
2018-06-20 16:02 ` [PATCH] " Sebastian Andrzej Siewior
2018-06-20 16:02 ` Sebastian Andrzej Siewior
2018-06-20 16:21 ` [PATCH] " Alan Stern
2018-06-20 16:21 ` Alan Stern
2018-06-20 16:49 ` [PATCH] " Sebastian Andrzej Siewior
2018-06-20 16:49 ` Sebastian Andrzej Siewior
2018-06-20 17:23 ` [PATCH] " Alan Stern
2018-06-20 17:23 ` Alan Stern
2018-07-12 22:35 ` [PATCH RFC] usb: add usb_fill_iso_urb() Sebastian Andrzej Siewior
2018-07-12 22:35 ` [RFC] " Sebastian Andrzej Siewior
2018-07-13 7:29 ` [PATCH RFC] " Greg Kroah-Hartman
2018-07-13 7:29 ` [RFC] " Greg Kroah-Hartman
2018-07-13 7:47 ` [PATCH RFC] " Sebastian Andrzej Siewior
2018-07-13 7:47 ` [RFC] " Sebastian Andrzej Siewior
2018-07-16 22:53 ` [PATCH RFC] " Sebastian Andrzej Siewior
2018-07-16 22:53 ` [RFC] " Sebastian Andrzej Siewior
2018-07-17 6:54 ` [PATCH RFC] " Clemens Ladisch
2018-07-17 6:54 ` Clemens Ladisch
2018-07-17 6:54 ` [RFC] " Clemens Ladisch
2018-08-06 21:21 ` [PATCH RFC] " Laurent Pinchart
2018-08-06 21:21 ` [RFC] " Laurent Pinchart
2018-08-06 22:02 ` [PATCH RFC] " Sebastian Andrzej Siewior
2018-08-06 22:02 ` [RFC] " Sebastian Andrzej Siewior
2018-07-13 8:01 ` [PATCH RFC] " Laurent Pinchart
2018-07-13 8:01 ` [RFC] " Laurent Pinchart
2018-07-13 20:12 ` [PATCH RFC] " Alan Stern
2018-07-13 20:12 ` [RFC] " Alan Stern
2018-06-20 15:21 ` [PATCH 27/27 v2] media: uvcvideo: use usb_fill_int_urb() for the ->intarval value Sebastian Andrzej Siewior
2018-06-20 15:21 ` [27/27,v2] " Sebastian Andrzej Siewior
2018-06-20 15:40 ` [PATCH 27/27 v2] " Alan Stern
2018-06-20 15:40 ` [27/27,v2] " Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620110105.19955-26-bigeasy@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.