All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Toshi Kani <toshi.kani@hpe.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com
Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode
Date: Tue, 26 Jun 2018 11:59:30 -0600	[thread overview]
Message-ID: <20180626175932.8899-2-ross.zwisler@linux.intel.com> (raw)
In-Reply-To: <20180626175932.8899-1-ross.zwisler@linux.intel.com>

QUEUE_FLAG_DAX is an indication that a given block device supports
filesystem DAX and should not be set for PMEM namespaces which are in "raw"
or "sector" modes.  These namespaces lack struct page and are prevented
from participating in filesystem DAX.

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Suggested-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org
---
 drivers/nvdimm/pmem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
index 68940356cad3..8b1fd7f1a224 100644
--- a/drivers/nvdimm/pmem.c
+++ b/drivers/nvdimm/pmem.c
@@ -414,7 +414,8 @@ static int pmem_attach_disk(struct device *dev,
 	blk_queue_logical_block_size(q, pmem_sector_size(ndns));
 	blk_queue_max_hw_sectors(q, UINT_MAX);
 	blk_queue_flag_set(QUEUE_FLAG_NONROT, q);
-	blk_queue_flag_set(QUEUE_FLAG_DAX, q);
+	if (pmem->pfn_flags & PFN_MAP)
+		blk_queue_flag_set(QUEUE_FLAG_DAX, q);
 	q->queuedata = pmem;
 
 	disk = alloc_disk_node(0, nid);
-- 
2.14.4

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Toshi Kani <toshi.kani@hpe.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org,
	stable@vger.kernel.org
Subject: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode
Date: Tue, 26 Jun 2018 11:59:30 -0600	[thread overview]
Message-ID: <20180626175932.8899-2-ross.zwisler@linux.intel.com> (raw)
In-Reply-To: <20180626175932.8899-1-ross.zwisler@linux.intel.com>

QUEUE_FLAG_DAX is an indication that a given block device supports
filesystem DAX and should not be set for PMEM namespaces which are in "raw"
or "sector" modes.  These namespaces lack struct page and are prevented
from participating in filesystem DAX.

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Suggested-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org
---
 drivers/nvdimm/pmem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
index 68940356cad3..8b1fd7f1a224 100644
--- a/drivers/nvdimm/pmem.c
+++ b/drivers/nvdimm/pmem.c
@@ -414,7 +414,8 @@ static int pmem_attach_disk(struct device *dev,
 	blk_queue_logical_block_size(q, pmem_sector_size(ndns));
 	blk_queue_max_hw_sectors(q, UINT_MAX);
 	blk_queue_flag_set(QUEUE_FLAG_NONROT, q);
-	blk_queue_flag_set(QUEUE_FLAG_DAX, q);
+	if (pmem->pfn_flags & PFN_MAP)
+		blk_queue_flag_set(QUEUE_FLAG_DAX, q);
 	q->queuedata = pmem;
 
 	disk = alloc_disk_node(0, nid);
-- 
2.14.4


WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Toshi Kani <toshi.kani-ZPxbGqLxI0U@public.gmane.org>,
	Mike Snitzer <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode
Date: Tue, 26 Jun 2018 11:59:30 -0600	[thread overview]
Message-ID: <20180626175932.8899-2-ross.zwisler@linux.intel.com> (raw)
In-Reply-To: <20180626175932.8899-1-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

QUEUE_FLAG_DAX is an indication that a given block device supports
filesystem DAX and should not be set for PMEM namespaces which are in "raw"
or "sector" modes.  These namespaces lack struct page and are prevented
from participating in filesystem DAX.

Signed-off-by: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Suggested-by: Mike Snitzer <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
 drivers/nvdimm/pmem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
index 68940356cad3..8b1fd7f1a224 100644
--- a/drivers/nvdimm/pmem.c
+++ b/drivers/nvdimm/pmem.c
@@ -414,7 +414,8 @@ static int pmem_attach_disk(struct device *dev,
 	blk_queue_logical_block_size(q, pmem_sector_size(ndns));
 	blk_queue_max_hw_sectors(q, UINT_MAX);
 	blk_queue_flag_set(QUEUE_FLAG_NONROT, q);
-	blk_queue_flag_set(QUEUE_FLAG_DAX, q);
+	if (pmem->pfn_flags & PFN_MAP)
+		blk_queue_flag_set(QUEUE_FLAG_DAX, q);
 	q->queuedata = pmem;
 
 	disk = alloc_disk_node(0, nid);
-- 
2.14.4

  reply	other threads:[~2018-06-26 17:59 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-26 17:59 [PATCH v3 0/3] Fix DM DAX handling Ross Zwisler
2018-06-26 17:59 ` Ross Zwisler
2018-06-26 17:59 ` Ross Zwisler
2018-06-26 17:59 ` Ross Zwisler [this message]
2018-06-26 17:59   ` [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode Ross Zwisler
2018-06-26 17:59   ` Ross Zwisler
2018-06-26 18:52   ` Dan Williams
2018-06-26 18:52     ` Dan Williams
2018-06-26 18:52     ` Dan Williams
2018-06-26 18:58     ` Mike Snitzer
2018-06-26 18:58       ` Mike Snitzer
2018-06-26 19:07       ` Dan Williams
2018-06-26 19:07         ` Dan Williams
2018-06-26 19:07         ` Dan Williams
2018-06-26 19:12         ` Ross Zwisler
2018-06-26 19:12           ` Ross Zwisler
2018-06-26 19:12           ` Ross Zwisler
2018-06-26 19:13         ` Mike Snitzer
2018-06-26 19:13           ` Mike Snitzer
2018-06-26 19:13           ` Mike Snitzer
2018-06-26 19:19           ` Dan Williams
2018-06-26 19:19             ` Dan Williams
2018-06-26 19:19             ` Dan Williams
2018-06-26 20:54           ` Kani, Toshi
2018-06-26 20:54             ` Kani, Toshi
2018-06-26 20:54             ` Kani, Toshi
2018-06-26 21:02             ` Dan Williams
2018-06-26 21:02               ` Dan Williams
2018-06-26 21:02               ` Dan Williams
2018-06-26 21:23               ` Kani, Toshi
2018-06-26 21:23                 ` Kani, Toshi
2018-06-26 21:23                 ` Kani, Toshi
2018-06-26 21:28                 ` Dan Williams
2018-06-26 21:28                   ` Dan Williams
2018-06-26 21:28                   ` Dan Williams
2018-06-26 21:31                   ` Kani, Toshi
2018-06-26 21:31                     ` Kani, Toshi
2018-06-26 21:51                     ` Dan Williams
2018-06-26 21:51                       ` Dan Williams
2018-06-26 21:51                       ` Dan Williams
2018-06-26 22:04                       ` Ross Zwisler
2018-06-26 22:04                         ` Ross Zwisler
2018-06-28 17:42                         ` Kani, Toshi
2018-06-28 17:42                           ` Kani, Toshi
2018-06-28 17:42                           ` Kani, Toshi
2018-06-28 17:48                           ` Mike Snitzer
2018-06-28 17:48                             ` Mike Snitzer
2018-06-28 17:59                             ` Dan Williams
2018-06-28 17:59                               ` Dan Williams
2018-06-28 17:59                               ` Dan Williams
2018-06-28 18:01                             ` Kani, Toshi
2018-06-28 18:01                               ` Kani, Toshi
2018-06-28 18:01                               ` Kani, Toshi
2018-06-28 19:04                           ` Ross Zwisler
2018-06-28 19:04                             ` Ross Zwisler
2018-06-28 19:04                             ` Ross Zwisler
2018-06-28 19:40                             ` Kani, Toshi
2018-06-28 19:40                               ` Kani, Toshi
2018-06-28 19:40                               ` Kani, Toshi
2018-06-26 19:11       ` Ross Zwisler
2018-06-26 19:11         ` Ross Zwisler
2018-06-26 19:11         ` Ross Zwisler
2018-06-26 17:59 ` [PATCH v3 2/3] dax: bdev_dax_supported() check for QUEUE_FLAG_DAX Ross Zwisler
2018-06-26 17:59   ` Ross Zwisler
2018-06-26 17:59   ` Ross Zwisler
2018-06-26 17:59 ` [PATCH v3 3/3] dm: prevent DAX mounts if not supported Ross Zwisler
2018-06-26 17:59   ` Ross Zwisler
2018-06-26 17:59   ` Ross Zwisler
2018-06-26 18:17   ` Mike Snitzer
2018-06-26 18:17     ` Mike Snitzer
2018-06-26 18:17     ` Mike Snitzer
2018-06-26 19:01   ` [PATCH v4 " Ross Zwisler
2018-06-26 19:01     ` Ross Zwisler
2018-06-26 19:01     ` Ross Zwisler
2018-06-26 18:48 ` [PATCH v3 0/3] Fix DM DAX handling Mike Snitzer
2018-06-26 18:48   ` Mike Snitzer
2018-06-26 18:48   ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180626175932.8899-2-ross.zwisler@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=snitzer@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=toshi.kani@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.