From: Christoph Hellwig <hch@lst.de> To: Jens Axboe <axboe@fb.com>, Keith Busch <keith.busch@intel.com>, Sagi Grimberg <sagi@grimberg.me> Cc: Max Gurtovoy <maxg@mellanox.com>, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org Subject: [PATCH 03/13] nvme-pci: cleanup SQ allocation a bit Date: Sun, 2 Dec 2018 17:46:18 +0100 [thread overview] Message-ID: <20181202164628.1116-4-hch@lst.de> (raw) In-Reply-To: <20181202164628.1116-1-hch@lst.de> Use a bit flag to mark if the SQ was allocated from the CMB, and clean up the surrounding code a bit. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Keith Busch <keith.busch@intel.com> --- drivers/nvme/host/pci.c | 33 +++++++++++++++------------------ 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 022395a319f4..b820dd0351cb 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -186,7 +186,6 @@ struct nvme_queue { struct nvme_dev *dev; spinlock_t sq_lock; struct nvme_command *sq_cmds; - bool sq_cmds_is_io; spinlock_t cq_lock ____cacheline_aligned_in_smp; volatile struct nvme_completion *cqes; struct blk_mq_tags **tags; @@ -203,6 +202,7 @@ struct nvme_queue { u8 cq_phase; unsigned long flags; #define NVMEQ_ENABLED 0 +#define NVMEQ_SQ_CMB 1 u32 *dbbuf_sq_db; u32 *dbbuf_cq_db; u32 *dbbuf_sq_ei; @@ -1366,17 +1366,15 @@ static void nvme_free_queue(struct nvme_queue *nvmeq) { dma_free_coherent(nvmeq->q_dmadev, CQ_SIZE(nvmeq->q_depth), (void *)nvmeq->cqes, nvmeq->cq_dma_addr); + if (!nvmeq->sq_cmds) + return; - if (nvmeq->sq_cmds) { - if (nvmeq->sq_cmds_is_io) - pci_free_p2pmem(to_pci_dev(nvmeq->q_dmadev), - nvmeq->sq_cmds, - SQ_SIZE(nvmeq->q_depth)); - else - dma_free_coherent(nvmeq->q_dmadev, - SQ_SIZE(nvmeq->q_depth), - nvmeq->sq_cmds, - nvmeq->sq_dma_addr); + if (test_and_clear_bit(NVMEQ_SQ_CMB, &nvmeq->flags)) { + pci_free_p2pmem(to_pci_dev(nvmeq->q_dmadev), + nvmeq->sq_cmds, SQ_SIZE(nvmeq->q_depth)); + } else { + dma_free_coherent(nvmeq->q_dmadev, SQ_SIZE(nvmeq->q_depth), + nvmeq->sq_cmds, nvmeq->sq_dma_addr); } } @@ -1462,15 +1460,14 @@ static int nvme_alloc_sq_cmds(struct nvme_dev *dev, struct nvme_queue *nvmeq, nvmeq->sq_cmds = pci_alloc_p2pmem(pdev, SQ_SIZE(depth)); nvmeq->sq_dma_addr = pci_p2pmem_virt_to_bus(pdev, nvmeq->sq_cmds); - nvmeq->sq_cmds_is_io = true; - } - - if (!nvmeq->sq_cmds) { - nvmeq->sq_cmds = dma_alloc_coherent(dev->dev, SQ_SIZE(depth), - &nvmeq->sq_dma_addr, GFP_KERNEL); - nvmeq->sq_cmds_is_io = false; + if (nvmeq->sq_dma_addr) { + set_bit(NVMEQ_SQ_CMB, &nvmeq->flags); + return 0; + } } + nvmeq->sq_cmds = dma_alloc_coherent(dev->dev, SQ_SIZE(depth), + &nvmeq->sq_dma_addr, GFP_KERNEL); if (!nvmeq->sq_cmds) return -ENOMEM; return 0; -- 2.19.1
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig) Subject: [PATCH 03/13] nvme-pci: cleanup SQ allocation a bit Date: Sun, 2 Dec 2018 17:46:18 +0100 [thread overview] Message-ID: <20181202164628.1116-4-hch@lst.de> (raw) In-Reply-To: <20181202164628.1116-1-hch@lst.de> Use a bit flag to mark if the SQ was allocated from the CMB, and clean up the surrounding code a bit. Signed-off-by: Christoph Hellwig <hch at lst.de> Reviewed-by: Keith Busch <keith.busch at intel.com> --- drivers/nvme/host/pci.c | 33 +++++++++++++++------------------ 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 022395a319f4..b820dd0351cb 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -186,7 +186,6 @@ struct nvme_queue { struct nvme_dev *dev; spinlock_t sq_lock; struct nvme_command *sq_cmds; - bool sq_cmds_is_io; spinlock_t cq_lock ____cacheline_aligned_in_smp; volatile struct nvme_completion *cqes; struct blk_mq_tags **tags; @@ -203,6 +202,7 @@ struct nvme_queue { u8 cq_phase; unsigned long flags; #define NVMEQ_ENABLED 0 +#define NVMEQ_SQ_CMB 1 u32 *dbbuf_sq_db; u32 *dbbuf_cq_db; u32 *dbbuf_sq_ei; @@ -1366,17 +1366,15 @@ static void nvme_free_queue(struct nvme_queue *nvmeq) { dma_free_coherent(nvmeq->q_dmadev, CQ_SIZE(nvmeq->q_depth), (void *)nvmeq->cqes, nvmeq->cq_dma_addr); + if (!nvmeq->sq_cmds) + return; - if (nvmeq->sq_cmds) { - if (nvmeq->sq_cmds_is_io) - pci_free_p2pmem(to_pci_dev(nvmeq->q_dmadev), - nvmeq->sq_cmds, - SQ_SIZE(nvmeq->q_depth)); - else - dma_free_coherent(nvmeq->q_dmadev, - SQ_SIZE(nvmeq->q_depth), - nvmeq->sq_cmds, - nvmeq->sq_dma_addr); + if (test_and_clear_bit(NVMEQ_SQ_CMB, &nvmeq->flags)) { + pci_free_p2pmem(to_pci_dev(nvmeq->q_dmadev), + nvmeq->sq_cmds, SQ_SIZE(nvmeq->q_depth)); + } else { + dma_free_coherent(nvmeq->q_dmadev, SQ_SIZE(nvmeq->q_depth), + nvmeq->sq_cmds, nvmeq->sq_dma_addr); } } @@ -1462,15 +1460,14 @@ static int nvme_alloc_sq_cmds(struct nvme_dev *dev, struct nvme_queue *nvmeq, nvmeq->sq_cmds = pci_alloc_p2pmem(pdev, SQ_SIZE(depth)); nvmeq->sq_dma_addr = pci_p2pmem_virt_to_bus(pdev, nvmeq->sq_cmds); - nvmeq->sq_cmds_is_io = true; - } - - if (!nvmeq->sq_cmds) { - nvmeq->sq_cmds = dma_alloc_coherent(dev->dev, SQ_SIZE(depth), - &nvmeq->sq_dma_addr, GFP_KERNEL); - nvmeq->sq_cmds_is_io = false; + if (nvmeq->sq_dma_addr) { + set_bit(NVMEQ_SQ_CMB, &nvmeq->flags); + return 0; + } } + nvmeq->sq_cmds = dma_alloc_coherent(dev->dev, SQ_SIZE(depth), + &nvmeq->sq_dma_addr, GFP_KERNEL); if (!nvmeq->sq_cmds) return -ENOMEM; return 0; -- 2.19.1
next prev parent reply other threads:[~2018-12-02 16:47 UTC|newest] Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-02 16:46 block and nvme polling improvements V3 Christoph Hellwig 2018-12-02 16:46 ` Christoph Hellwig 2018-12-02 16:46 ` [PATCH 01/13] block: move queues types to the block layer Christoph Hellwig 2018-12-02 16:46 ` Christoph Hellwig 2018-12-04 0:49 ` Sagi Grimberg 2018-12-04 0:49 ` Sagi Grimberg 2018-12-04 15:00 ` Christoph Hellwig 2018-12-04 15:00 ` Christoph Hellwig 2018-12-04 17:08 ` Sagi Grimberg 2018-12-04 17:08 ` Sagi Grimberg 2018-12-02 16:46 ` [PATCH 02/13] nvme-pci: use atomic bitops to mark a queue enabled Christoph Hellwig 2018-12-02 16:46 ` Christoph Hellwig 2018-12-04 0:54 ` Sagi Grimberg 2018-12-04 0:54 ` Sagi Grimberg 2018-12-04 15:04 ` Christoph Hellwig 2018-12-04 15:04 ` Christoph Hellwig 2018-12-04 17:11 ` Sagi Grimberg 2018-12-04 17:11 ` Sagi Grimberg 2018-12-02 16:46 ` Christoph Hellwig [this message] 2018-12-02 16:46 ` [PATCH 03/13] nvme-pci: cleanup SQ allocation a bit Christoph Hellwig 2018-12-04 0:55 ` Sagi Grimberg 2018-12-04 0:55 ` Sagi Grimberg 2018-12-02 16:46 ` [PATCH 04/13] nvme-pci: only allow polling with separate poll queues Christoph Hellwig 2018-12-02 16:46 ` Christoph Hellwig 2018-12-03 18:23 ` Keith Busch 2018-12-03 18:23 ` Keith Busch 2018-12-04 0:56 ` Sagi Grimberg 2018-12-04 0:56 ` Sagi Grimberg 2018-12-02 16:46 ` [PATCH 05/13] nvme-pci: consolidate code for polling non-dedicated queues Christoph Hellwig 2018-12-02 16:46 ` Christoph Hellwig 2018-12-04 0:58 ` Sagi Grimberg 2018-12-04 0:58 ` Sagi Grimberg 2018-12-04 15:04 ` Christoph Hellwig 2018-12-04 15:04 ` Christoph Hellwig 2018-12-04 17:13 ` Sagi Grimberg 2018-12-04 17:13 ` Sagi Grimberg 2018-12-04 18:19 ` Jens Axboe 2018-12-04 18:19 ` Jens Axboe 2018-12-02 16:46 ` [PATCH 06/13] nvme-pci: refactor nvme_disable_io_queues Christoph Hellwig 2018-12-02 16:46 ` Christoph Hellwig 2018-12-04 1:00 ` Sagi Grimberg 2018-12-04 1:00 ` Sagi Grimberg 2018-12-04 15:05 ` Christoph Hellwig 2018-12-04 15:05 ` Christoph Hellwig 2018-12-04 18:19 ` Jens Axboe 2018-12-04 18:19 ` Jens Axboe 2018-12-02 16:46 ` [PATCH 07/13] nvme-pci: don't poll from irq context when deleting queues Christoph Hellwig 2018-12-02 16:46 ` Christoph Hellwig 2018-12-03 18:15 ` Keith Busch 2018-12-03 18:15 ` Keith Busch 2018-12-04 1:05 ` Sagi Grimberg 2018-12-04 1:05 ` Sagi Grimberg 2018-12-02 16:46 ` [PATCH 08/13] nvme-pci: remove the CQ lock for interrupt driven queues Christoph Hellwig 2018-12-02 16:46 ` Christoph Hellwig 2018-12-04 1:08 ` Sagi Grimberg 2018-12-04 1:08 ` Sagi Grimberg 2018-12-02 16:46 ` [PATCH 09/13] nvme-rdma: remove I/O polling support Christoph Hellwig 2018-12-02 16:46 ` Christoph Hellwig 2018-12-02 16:46 ` [PATCH 10/13] nvme-mpath: " Christoph Hellwig 2018-12-02 16:46 ` Christoph Hellwig 2018-12-03 18:22 ` Keith Busch 2018-12-03 18:22 ` Keith Busch 2018-12-04 1:11 ` Sagi Grimberg 2018-12-04 1:11 ` Sagi Grimberg 2018-12-04 15:07 ` Christoph Hellwig 2018-12-04 15:07 ` Christoph Hellwig 2018-12-04 17:18 ` Sagi Grimberg 2018-12-04 17:18 ` Sagi Grimberg 2018-12-02 16:46 ` [PATCH 11/13] block: remove ->poll_fn Christoph Hellwig 2018-12-02 16:46 ` Christoph Hellwig 2018-12-04 1:11 ` Sagi Grimberg 2018-12-04 1:11 ` Sagi Grimberg 2018-12-02 16:46 ` [PATCH 12/13] block: only allow polling if a poll queue_map exists Christoph Hellwig 2018-12-02 16:46 ` Christoph Hellwig 2018-12-04 1:14 ` Sagi Grimberg 2018-12-04 1:14 ` Sagi Grimberg 2018-12-02 16:46 ` [PATCH 13/13] block: enable polling by default if a poll map is initalized Christoph Hellwig 2018-12-02 16:46 ` Christoph Hellwig 2018-12-04 1:14 ` Sagi Grimberg 2018-12-04 1:14 ` Sagi Grimberg 2018-12-04 18:40 ` block and nvme polling improvements V3 Jens Axboe 2018-12-04 18:40 ` Jens Axboe -- strict thread matches above, loose matches on Subject: below -- 2018-11-29 19:12 block and nvme polling improvements V2 Christoph Hellwig 2018-11-29 19:13 ` [PATCH 03/13] nvme-pci: cleanup SQ allocation a bit Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 20:22 ` Keith Busch 2018-11-29 20:22 ` Keith Busch 2018-11-21 16:23 block and nvme polling improvements Christoph Hellwig 2018-11-21 16:23 ` [PATCH 03/13] nvme-pci: cleanup SQ allocation a bit Christoph Hellwig 2018-11-21 16:23 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181202164628.1116-4-hch@lst.de \ --to=hch@lst.de \ --cc=axboe@fb.com \ --cc=keith.busch@intel.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=maxg@mellanox.com \ --cc=sagi@grimberg.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.