All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-i2c@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
	Hans de Goede <hdegoede@redhat.com>,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-kernel@vger.kernel.org
Subject: [RFC/RFT 01/10] i2c: add 'is_suspended' flag for i2c adapters
Date: Mon, 10 Dec 2018 22:02:59 +0100	[thread overview]
Message-ID: <20181210210310.12677-2-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20181210210310.12677-1-wsa+renesas@sang-engineering.com>

Some drivers open code handling of suspended adapters. It should be
handled by the core, though, to ensure generic handling. This patch adds
the flag and an accessor function.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/i2c/i2c-core-base.c | 1 +
 include/linux/i2c.h         | 9 +++++++++
 2 files changed, 10 insertions(+)

diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 28460f6a60cc..9f89e258c8ff 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -1232,6 +1232,7 @@ static int i2c_register_adapter(struct i2c_adapter *adap)
 	if (!adap->lock_ops)
 		adap->lock_ops = &i2c_adapter_lock_ops;
 
+	adap->is_suspended = false;
 	rt_mutex_init(&adap->bus_lock);
 	rt_mutex_init(&adap->mux_lock);
 	mutex_init(&adap->userspace_clients_lock);
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 65b4eaed1d96..9852038ee3a7 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -680,6 +680,7 @@ struct i2c_adapter {
 	int timeout;			/* in jiffies */
 	int retries;
 	struct device dev;		/* the adapter device */
+	unsigned int is_suspended:1;	/* owned by the I2C core */
 
 	int nr;
 	char name[48];
@@ -762,6 +763,14 @@ i2c_unlock_bus(struct i2c_adapter *adapter, unsigned int flags)
 	adapter->lock_ops->unlock_bus(adapter, flags);
 }
 
+static inline void i2c_mark_adapter_suspended(struct i2c_adapter *adap,
+					      bool suspended)
+{
+	i2c_lock_bus(adap, I2C_LOCK_ROOT_ADAPTER);
+	adap->is_suspended = suspended;
+	i2c_unlock_bus(adap, I2C_LOCK_ROOT_ADAPTER);
+}
+
 /*flags for the client struct: */
 #define I2C_CLIENT_PEC		0x04	/* Use Packet Error Checking */
 #define I2C_CLIENT_TEN		0x10	/* we have a ten bit chip address */
-- 
2.11.0


WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-i2c@vger.kernel.org
Cc: Wolfram Sang <wsa@the-dreams.de>,
	linux-pm@vger.kernel.org,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Hans de Goede <hdegoede@redhat.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [RFC/RFT 01/10] i2c: add 'is_suspended' flag for i2c adapters
Date: Mon, 10 Dec 2018 22:02:59 +0100	[thread overview]
Message-ID: <20181210210310.12677-2-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20181210210310.12677-1-wsa+renesas@sang-engineering.com>

Some drivers open code handling of suspended adapters. It should be
handled by the core, though, to ensure generic handling. This patch adds
the flag and an accessor function.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/i2c/i2c-core-base.c | 1 +
 include/linux/i2c.h         | 9 +++++++++
 2 files changed, 10 insertions(+)

diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 28460f6a60cc..9f89e258c8ff 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -1232,6 +1232,7 @@ static int i2c_register_adapter(struct i2c_adapter *adap)
 	if (!adap->lock_ops)
 		adap->lock_ops = &i2c_adapter_lock_ops;
 
+	adap->is_suspended = false;
 	rt_mutex_init(&adap->bus_lock);
 	rt_mutex_init(&adap->mux_lock);
 	mutex_init(&adap->userspace_clients_lock);
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 65b4eaed1d96..9852038ee3a7 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -680,6 +680,7 @@ struct i2c_adapter {
 	int timeout;			/* in jiffies */
 	int retries;
 	struct device dev;		/* the adapter device */
+	unsigned int is_suspended:1;	/* owned by the I2C core */
 
 	int nr;
 	char name[48];
@@ -762,6 +763,14 @@ i2c_unlock_bus(struct i2c_adapter *adapter, unsigned int flags)
 	adapter->lock_ops->unlock_bus(adapter, flags);
 }
 
+static inline void i2c_mark_adapter_suspended(struct i2c_adapter *adap,
+					      bool suspended)
+{
+	i2c_lock_bus(adap, I2C_LOCK_ROOT_ADAPTER);
+	adap->is_suspended = suspended;
+	i2c_unlock_bus(adap, I2C_LOCK_ROOT_ADAPTER);
+}
+
 /*flags for the client struct: */
 #define I2C_CLIENT_PEC		0x04	/* Use Packet Error Checking */
 #define I2C_CLIENT_TEN		0x10	/* we have a ten bit chip address */
-- 
2.11.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2018-12-10 21:03 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-10 21:02 [RFC/RFT 00/10] i2c: move handling of suspended adapters to the core Wolfram Sang
2018-12-10 21:02 ` Wolfram Sang
2018-12-10 21:02 ` Wolfram Sang
2018-12-10 21:02 ` Wolfram Sang [this message]
2018-12-10 21:02   ` [RFC/RFT 01/10] i2c: add 'is_suspended' flag for i2c adapters Wolfram Sang
2018-12-10 22:03   ` Peter Rosin
2018-12-10 22:03     ` Peter Rosin
2018-12-10 22:03     ` Peter Rosin
2018-12-18 23:33     ` Wolfram Sang
2018-12-18 23:33       ` Wolfram Sang
2018-12-18 23:33       ` Wolfram Sang
2018-12-19  9:39       ` Geert Uytterhoeven
2018-12-19  9:39         ` Geert Uytterhoeven
2018-12-19  9:39         ` Geert Uytterhoeven
2018-12-19 16:31         ` Wolfram Sang
2018-12-19 16:31           ` Wolfram Sang
2018-12-10 21:03 ` [RFC/RFT 02/10] i2c: reject new transfers when adapters are suspended Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-10 21:03 ` [RFC/RFT 03/10] i2c: synquacer: remove unused is_suspended flag Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-10 21:04   ` Ard Biesheuvel
2018-12-10 21:04     ` Ard Biesheuvel
2018-12-10 21:03 ` [RFC/RFT 04/10] i2c: brcmstb: use core helper to mark adapter suspended Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-11 16:44   ` Kamal Dasu
2018-12-11 16:44     ` Kamal Dasu
2018-12-10 21:03 ` [RFC/RFT 05/10] i2c: zx2967: " Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-11  2:12   ` Shawn Guo
2018-12-11  2:12     ` Shawn Guo
2018-12-10 21:03 ` [RFC/RFT 06/10] i2c: sprd: don't use pdev as variable name for struct device * Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-10 21:03 ` [RFC/RFT 07/10] i2c: sprd: use core helper to mark adapter suspended Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-10 21:03 ` [RFC/RFT 08/10] i2c: exynos5: " Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-18 11:23   ` Marek Szyprowski
2018-12-18 11:23     ` Marek Szyprowski
2018-12-18 19:52     ` Wolfram Sang
2018-12-18 19:52       ` Wolfram Sang
2018-12-10 21:03 ` [RFC/RFT 09/10] i2c: s3c2410: " Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-18 11:24   ` Marek Szyprowski
2018-12-18 11:24     ` Marek Szyprowski
2018-12-10 21:03 ` [RFC/RFT 10/10] i2c: rcar: add suspend/resume support Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-10 21:52   ` Peter Rosin
2018-12-10 21:52     ` Peter Rosin
2018-12-10 21:52     ` Peter Rosin
2018-12-18 23:47     ` Wolfram Sang
2018-12-18 23:47       ` Wolfram Sang
2018-12-18 23:47       ` Wolfram Sang
2018-12-11 19:24 ` [RFC/RFT 00/10] i2c: move handling of suspended adapters to the core Hans de Goede
2018-12-11 19:24   ` Hans de Goede
2018-12-11 19:24   ` Hans de Goede
2018-12-11 23:41   ` Wolfram Sang
2018-12-11 23:41     ` Wolfram Sang
2018-12-12 10:09     ` Hans de Goede
2018-12-12 10:09       ` Hans de Goede
2018-12-18 20:17       ` Wolfram Sang
2018-12-18 20:17         ` Wolfram Sang
2018-12-18 21:44         ` Hans de Goede
2018-12-18 21:44           ` Hans de Goede
2018-12-18 23:32           ` Wolfram Sang
2018-12-18 23:32             ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181210210310.12677-2-wsa+renesas@sang-engineering.com \
    --to=wsa+renesas@sang-engineering.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.