All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
	"Joel Stanley" <joel@jms.id.au>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Andrzej Zaborowski" <balrogg@gmail.com>,
	"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
	"Beniamino Galvani" <b.galvani@gmail.com>,
	"Michael Walle" <michael@walle.cc>,
	"Richard Henderson" <rth@twiddle.net>,
	"Jan Kiszka" <jan.kiszka@web.de>,
	"Jason Wang" <jasowang@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Peter Chubb" <peter.chubb@nicta.com.au>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Rob Herring" <robh@kernel.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [Qemu-devel] [PATCH 14/16] hw/net/lan9118: Export TYPE_LAN9118 and use it instead of hardcoded string
Date: Fri,  4 Jan 2019 18:58:45 +0100	[thread overview]
Message-ID: <20190104175847.6290-15-philmd@redhat.com> (raw)
In-Reply-To: <20190104175847.6290-1-philmd@redhat.com>

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/arm/exynos4_boards.c  | 3 ++-
 hw/arm/mps2-tz.c         | 3 ++-
 hw/net/lan9118.c         | 1 -
 include/hw/net/lan9118.h | 2 ++
 4 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c
index 750162cc95..ea8100f65a 100644
--- a/hw/arm/exynos4_boards.c
+++ b/hw/arm/exynos4_boards.c
@@ -32,6 +32,7 @@
 #include "hw/arm/arm.h"
 #include "exec/address-spaces.h"
 #include "hw/arm/exynos4210.h"
+#include "hw/net/lan9118.h"
 #include "hw/boards.h"
 
 #undef DEBUG
@@ -92,7 +93,7 @@ static void lan9215_init(uint32_t base, qemu_irq irq)
     /* This should be a 9215 but the 9118 is close enough */
     if (nd_table[0].used) {
         qemu_check_nic_model(&nd_table[0], "lan9118");
-        dev = qdev_create(NULL, "lan9118");
+        dev = qdev_create(NULL, TYPE_LAN9118);
         qdev_set_nic_properties(dev, &nd_table[0]);
         qdev_prop_set_uint32(dev, "mode_16bit", 1);
         qdev_init_nofail(dev);
diff --git a/hw/arm/mps2-tz.c b/hw/arm/mps2-tz.c
index 1232d6ff95..b6a8693d7c 100644
--- a/hw/arm/mps2-tz.c
+++ b/hw/arm/mps2-tz.c
@@ -49,6 +49,7 @@
 #include "hw/arm/iotkit.h"
 #include "hw/dma/pl080.h"
 #include "hw/ssi/pl022.h"
+#include "hw/net/lan9118.h"
 #include "net/net.h"
 #include "hw/core/split-irq.h"
 
@@ -219,7 +220,7 @@ static MemoryRegion *make_eth_dev(MPS2TZMachineState *mms, void *opaque,
      * except that it doesn't support the checksum-offload feature.
      */
     qemu_check_nic_model(nd, "lan9118");
-    mms->lan9118 = qdev_create(NULL, "lan9118");
+    mms->lan9118 = qdev_create(NULL, TYPE_LAN9118);
     qdev_set_nic_properties(mms->lan9118, nd);
     qdev_init_nofail(mms->lan9118);
 
diff --git a/hw/net/lan9118.c b/hw/net/lan9118.c
index a428b16eda..b29e3fee49 100644
--- a/hw/net/lan9118.c
+++ b/hw/net/lan9118.c
@@ -175,7 +175,6 @@ static const VMStateDescription vmstate_lan9118_packet = {
     }
 };
 
-#define TYPE_LAN9118 "lan9118"
 #define LAN9118(obj) OBJECT_CHECK(lan9118_state, (obj), TYPE_LAN9118)
 
 typedef struct {
diff --git a/include/hw/net/lan9118.h b/include/hw/net/lan9118.h
index 340d6681b7..2a3e2b0dea 100644
--- a/include/hw/net/lan9118.h
+++ b/include/hw/net/lan9118.h
@@ -16,6 +16,8 @@
 #include "hw/irq.h"
 #include "net/net.h"
 
+#define TYPE_LAN9118 "lan9118"
+
 void lan9118_init(NICInfo *, uint32_t, qemu_irq);
 
 #endif
-- 
2.17.2

  parent reply	other threads:[~2019-01-04 18:02 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-04 17:58 [Qemu-devel] [PATCH 00/16] hw: Remove "hw/devices.h" Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 01/16] hw/arm/aspeed: Use TYPE_TMP105/TYPE_PCA9552 instead of hardcoded string Philippe Mathieu-Daudé
2019-01-04 19:40   ` Thomas Huth
2019-01-07  6:48   ` Cédric Le Goater
2019-01-04 17:58 ` [Qemu-devel] [PATCH 02/16] hw: Remove unused 'hw/devices.h' include Philippe Mathieu-Daudé
2019-01-04 22:24   ` [Qemu-devel] [Qemu-ppc] " BALATON Zoltan
2019-01-07  9:56   ` [Qemu-devel] " Thomas Huth
2019-01-04 17:58 ` [Qemu-devel] [PATCH 03/16] hw/devices: Remove unused TC6393XB_RAM definition Philippe Mathieu-Daudé
2019-01-07  6:32   ` Thomas Huth
2019-01-07  7:56     ` Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 04/16] hw/devices: Move TC6393XB declarations into a new header Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 05/16] hw/devices: Move Blizzard " Philippe Mathieu-Daudé
2019-01-07  6:39   ` Thomas Huth
2019-01-07  7:58     ` Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 06/16] hw/devices: Move CBus " Philippe Mathieu-Daudé
2019-01-07  7:00   ` Thomas Huth
2019-01-04 17:58 ` [Qemu-devel] [PATCH 07/16] hw/devices: Move Gamepad " Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 08/16] MAINTAINERS: Add missing entries for the TI touchscreen devices Philippe Mathieu-Daudé
2019-01-07  7:18   ` Thomas Huth
2019-01-07  8:02     ` Philippe Mathieu-Daudé
2019-01-07  8:05       ` Thomas Huth
2019-01-07 11:44         ` Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 09/16] hw/devices: Move TI touchscreen declarations into a new header Philippe Mathieu-Daudé
2019-01-07  7:22   ` Thomas Huth
2019-01-07  8:02     ` Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 10/16] typedefs: Remove MouseTransformInfo Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 11/16] typedefs: Remove PS2State Philippe Mathieu-Daudé
2019-01-07  7:26   ` Thomas Huth
2019-01-04 17:58 ` [Qemu-devel] [PATCH 12/16] hw/devices: Move LAN9118 declarations into a new header Philippe Mathieu-Daudé
2019-01-07  7:29   ` Thomas Huth
2019-01-07  8:04     ` Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 13/16] hw/net/ne2000-isa: Add guards to the header Philippe Mathieu-Daudé
2019-01-07  7:34   ` Thomas Huth
2019-01-04 17:58 ` Philippe Mathieu-Daudé [this message]
2019-01-04 17:58 ` [Qemu-devel] [PATCH 15/16] hw/devices: Move SMSC 91C111 declaration into a new header Philippe Mathieu-Daudé
2019-01-07  7:38   ` Thomas Huth
2019-01-04 17:58 ` [Qemu-devel] [PATCH 16/16] RFC hw/net/smc91c111: Convert init helper into an inline function Philippe Mathieu-Daudé
2019-01-04 19:35   ` Thomas Huth
2019-02-04 23:11     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190104175847.6290-15-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=andrew@aj.id.au \
    --cc=aurelien@aurel32.net \
    --cc=b.galvani@gmail.com \
    --cc=balrogg@gmail.com \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=edgar.iglesias@gmail.com \
    --cc=f4bug@amsat.org \
    --cc=i.mitsyanko@gmail.com \
    --cc=jan.kiszka@web.de \
    --cc=jasowang@redhat.com \
    --cc=joel@jms.id.au \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=kraxel@redhat.com \
    --cc=magnus.damm@gmail.com \
    --cc=michael@walle.cc \
    --cc=peter.chubb@nicta.com.au \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=robh@kernel.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.