All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yu Zhao <yuzhao@google.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>
Cc: "Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Nick Piggin <npiggin@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Joel Fernandes <joel@joelfernandes.org>,
	"Kirill A . Shutemov" <kirill@shutemov.name>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-mm@kvack.org, Yu Zhao <yuzhao@google.com>
Subject: [PATCH] arm64: mm: enable per pmd page table lock
Date: Thu, 14 Feb 2019 14:16:42 -0700	[thread overview]
Message-ID: <20190214211642.2200-1-yuzhao@google.com> (raw)

Switch from per mm_struct to per pmd page table lock by enabling
ARCH_ENABLE_SPLIT_PMD_PTLOCK. This provides better granularity for
large system.

I'm not sure if there is contention on mm->page_table_lock. Given
the option comes at no cost (apart from initializing more spin
locks), why not enable it now.

Signed-off-by: Yu Zhao <yuzhao@google.com>
---
 arch/arm64/Kconfig               |  3 +++
 arch/arm64/include/asm/pgalloc.h | 12 +++++++++++-
 arch/arm64/include/asm/tlb.h     |  5 ++++-
 3 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index a4168d366127..104325a1ffc3 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -872,6 +872,9 @@ config ARCH_WANT_HUGE_PMD_SHARE
 config ARCH_HAS_CACHE_LINE_SIZE
 	def_bool y
 
+config ARCH_ENABLE_SPLIT_PMD_PTLOCK
+	def_bool y
+
 config SECCOMP
 	bool "Enable seccomp to safely compute untrusted bytecode"
 	---help---
diff --git a/arch/arm64/include/asm/pgalloc.h b/arch/arm64/include/asm/pgalloc.h
index 52fa47c73bf0..dabba4b2c61f 100644
--- a/arch/arm64/include/asm/pgalloc.h
+++ b/arch/arm64/include/asm/pgalloc.h
@@ -33,12 +33,22 @@
 
 static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long addr)
 {
-	return (pmd_t *)__get_free_page(PGALLOC_GFP);
+	struct page *page;
+
+	page = alloc_page(PGALLOC_GFP);
+	if (!page)
+		return NULL;
+	if (!pgtable_pmd_page_ctor(page)) {
+		__free_page(page);
+		return NULL;
+	}
+	return page_address(page);
 }
 
 static inline void pmd_free(struct mm_struct *mm, pmd_t *pmdp)
 {
 	BUG_ON((unsigned long)pmdp & (PAGE_SIZE-1));
+	pgtable_pmd_page_dtor(virt_to_page(pmdp));
 	free_page((unsigned long)pmdp);
 }
 
diff --git a/arch/arm64/include/asm/tlb.h b/arch/arm64/include/asm/tlb.h
index 106fdc951b6e..4e3becfed387 100644
--- a/arch/arm64/include/asm/tlb.h
+++ b/arch/arm64/include/asm/tlb.h
@@ -62,7 +62,10 @@ static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte,
 static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmdp,
 				  unsigned long addr)
 {
-	tlb_remove_table(tlb, virt_to_page(pmdp));
+	struct page *page = virt_to_page(pmdp);
+
+	pgtable_pmd_page_dtor(page);
+	tlb_remove_table(tlb, page);
 }
 #endif
 
-- 
2.21.0.rc0.258.g878e2cd30e-goog


WARNING: multiple messages have this Message-ID (diff)
From: Yu Zhao <yuzhao@google.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>
Cc: linux-arch@vger.kernel.org, Yu Zhao <yuzhao@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org, Nick Piggin <npiggin@gmail.com>,
	linux-mm@kvack.org,
	"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	"Kirill A . Shutemov" <kirill@shutemov.name>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: mm: enable per pmd page table lock
Date: Thu, 14 Feb 2019 14:16:42 -0700	[thread overview]
Message-ID: <20190214211642.2200-1-yuzhao@google.com> (raw)

Switch from per mm_struct to per pmd page table lock by enabling
ARCH_ENABLE_SPLIT_PMD_PTLOCK. This provides better granularity for
large system.

I'm not sure if there is contention on mm->page_table_lock. Given
the option comes at no cost (apart from initializing more spin
locks), why not enable it now.

Signed-off-by: Yu Zhao <yuzhao@google.com>
---
 arch/arm64/Kconfig               |  3 +++
 arch/arm64/include/asm/pgalloc.h | 12 +++++++++++-
 arch/arm64/include/asm/tlb.h     |  5 ++++-
 3 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index a4168d366127..104325a1ffc3 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -872,6 +872,9 @@ config ARCH_WANT_HUGE_PMD_SHARE
 config ARCH_HAS_CACHE_LINE_SIZE
 	def_bool y
 
+config ARCH_ENABLE_SPLIT_PMD_PTLOCK
+	def_bool y
+
 config SECCOMP
 	bool "Enable seccomp to safely compute untrusted bytecode"
 	---help---
diff --git a/arch/arm64/include/asm/pgalloc.h b/arch/arm64/include/asm/pgalloc.h
index 52fa47c73bf0..dabba4b2c61f 100644
--- a/arch/arm64/include/asm/pgalloc.h
+++ b/arch/arm64/include/asm/pgalloc.h
@@ -33,12 +33,22 @@
 
 static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long addr)
 {
-	return (pmd_t *)__get_free_page(PGALLOC_GFP);
+	struct page *page;
+
+	page = alloc_page(PGALLOC_GFP);
+	if (!page)
+		return NULL;
+	if (!pgtable_pmd_page_ctor(page)) {
+		__free_page(page);
+		return NULL;
+	}
+	return page_address(page);
 }
 
 static inline void pmd_free(struct mm_struct *mm, pmd_t *pmdp)
 {
 	BUG_ON((unsigned long)pmdp & (PAGE_SIZE-1));
+	pgtable_pmd_page_dtor(virt_to_page(pmdp));
 	free_page((unsigned long)pmdp);
 }
 
diff --git a/arch/arm64/include/asm/tlb.h b/arch/arm64/include/asm/tlb.h
index 106fdc951b6e..4e3becfed387 100644
--- a/arch/arm64/include/asm/tlb.h
+++ b/arch/arm64/include/asm/tlb.h
@@ -62,7 +62,10 @@ static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte,
 static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmdp,
 				  unsigned long addr)
 {
-	tlb_remove_table(tlb, virt_to_page(pmdp));
+	struct page *page = virt_to_page(pmdp);
+
+	pgtable_pmd_page_dtor(page);
+	tlb_remove_table(tlb, page);
 }
 #endif
 
-- 
2.21.0.rc0.258.g878e2cd30e-goog


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2019-02-14 21:16 UTC|newest]

Thread overview: 120+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14 21:16 Yu Zhao [this message]
2019-02-14 21:16 ` [PATCH] arm64: mm: enable per pmd page table lock Yu Zhao
2019-02-18 15:12 ` Will Deacon
2019-02-18 15:12   ` Will Deacon
2019-02-18 19:49   ` Yu Zhao
2019-02-18 19:49     ` Yu Zhao
2019-02-18 20:48     ` Yu Zhao
2019-02-18 20:48       ` Yu Zhao
2019-02-19  4:09     ` Anshuman Khandual
2019-02-19  4:09       ` Anshuman Khandual
2019-02-18 23:13 ` [PATCH v2 1/3] arm64: mm: use appropriate ctors for page tables Yu Zhao
2019-02-18 23:13   ` Yu Zhao
2019-02-18 23:13   ` [PATCH v2 2/3] arm64: mm: don't call page table ctors for init_mm Yu Zhao
2019-02-18 23:13     ` Yu Zhao
2019-02-26 15:13     ` Mark Rutland
2019-02-26 15:13       ` Mark Rutland
2019-03-09  3:52       ` Yu Zhao
2019-03-09  3:52         ` Yu Zhao
2019-02-18 23:13   ` [PATCH v2 3/3] arm64: mm: enable per pmd page table lock Yu Zhao
2019-02-18 23:13     ` Yu Zhao
2019-02-19  4:21   ` [PATCH v2 1/3] arm64: mm: use appropriate ctors for page tables Anshuman Khandual
2019-02-19  4:21     ` Anshuman Khandual
2019-02-19  5:32     ` Yu Zhao
2019-02-19  5:32       ` Yu Zhao
2019-02-19  6:17       ` Anshuman Khandual
2019-02-19  6:17         ` Anshuman Khandual
2019-02-19 22:28         ` Yu Zhao
2019-02-19 22:28           ` Yu Zhao
2019-02-20 10:27           ` Anshuman Khandual
2019-02-20 10:27             ` Anshuman Khandual
2019-02-20 12:24             ` Matthew Wilcox
2019-02-20 12:24               ` Matthew Wilcox
2019-02-20 20:22             ` Yu Zhao
2019-02-20 20:22               ` Yu Zhao
2019-02-20 20:59               ` Matthew Wilcox
2019-02-20 20:59                 ` Matthew Wilcox
2019-02-20 20:59                 ` Matthew Wilcox
2019-02-20  1:34         ` Matthew Wilcox
2019-02-20  1:34           ` Matthew Wilcox
2019-02-20  1:34           ` Matthew Wilcox
2019-02-20  3:20           ` Anshuman Khandual
2019-02-20  3:20             ` Anshuman Khandual
2019-02-20 21:03       ` Matthew Wilcox
2019-02-20 21:03         ` Matthew Wilcox
2019-02-20 21:03         ` Matthew Wilcox
2019-02-26 15:12   ` Mark Rutland
2019-02-26 15:12     ` Mark Rutland
2019-03-09  4:01     ` Yu Zhao
2019-03-09  4:01       ` Yu Zhao
2019-03-09  4:01       ` Yu Zhao
2019-03-10  1:19   ` [PATCH v3 " Yu Zhao
2019-03-10  1:19     ` Yu Zhao
2019-03-10  1:19     ` Yu Zhao
2019-03-10  1:19     ` [PATCH v3 2/3] arm64: mm: don't call page table ctors for init_mm Yu Zhao
2019-03-10  1:19       ` Yu Zhao
2019-03-10  1:19       ` Yu Zhao
2019-03-10  1:19     ` [PATCH v3 3/3] arm64: mm: enable per pmd page table lock Yu Zhao
2019-03-10  1:19       ` Yu Zhao
2019-03-10  1:19       ` Yu Zhao
2019-03-11  8:28       ` Anshuman Khandual
2019-03-11  8:28         ` Anshuman Khandual
2019-03-11 23:10         ` Yu Zhao
2019-03-11 23:10           ` Yu Zhao
2019-03-11 12:12       ` Mark Rutland
2019-03-11 12:12         ` Mark Rutland
2019-03-11 12:57         ` Anshuman Khandual
2019-03-11 12:57           ` Anshuman Khandual
2019-03-11 23:11         ` Yu Zhao
2019-03-11 23:11           ` Yu Zhao
2019-03-11 23:11           ` Yu Zhao
2019-03-11  7:45     ` [PATCH v3 1/3] arm64: mm: use appropriate ctors for page tables Anshuman Khandual
2019-03-11  7:45       ` Anshuman Khandual
2019-03-11 23:23       ` Yu Zhao
2019-03-11 23:23         ` Yu Zhao
2019-03-12  0:57     ` [PATCH v4 1/4] " Yu Zhao
2019-03-12  0:57       ` Yu Zhao
2019-03-12  0:57       ` Yu Zhao
2019-03-12  0:57       ` [PATCH v4 2/4] arm64: mm: don't call page table ctors for init_mm Yu Zhao
2019-03-12  0:57         ` Yu Zhao
2019-03-12  0:57         ` Yu Zhao
2019-03-12  0:57       ` [PATCH v4 3/4] arm64: mm: call ctor for stage2 pmd page Yu Zhao
2019-03-12  0:57         ` Yu Zhao
2019-03-12  0:57         ` Yu Zhao
2019-03-12  2:19         ` [PATCH] KVM: ARM: Remove pgtable page standard functions from stage-2 page tables Anshuman Khandual
2019-03-12  2:19           ` Anshuman Khandual
2019-03-12  2:40           ` Yu Zhao
2019-03-12  2:40             ` Yu Zhao
2019-03-12 10:37           ` Suzuki K Poulose
2019-03-12 10:37             ` Suzuki K Poulose
2019-03-12 11:31             ` Anshuman Khandual
2019-03-12 11:31               ` Anshuman Khandual
2019-03-12 11:43               ` Suzuki K Poulose
2019-03-12 11:43                 ` Suzuki K Poulose
2019-03-12 13:25                 ` [PATCH V2] " Anshuman Khandual
2019-03-12 13:25                   ` Anshuman Khandual
2019-04-01 16:16                   ` Will Deacon
2019-04-01 16:16                     ` Will Deacon
2019-04-01 16:16                     ` Will Deacon
2019-04-01 18:34                     ` Yu Zhao
2019-04-01 18:34                       ` Yu Zhao
2019-04-01 18:34                       ` Yu Zhao
2019-04-02  9:03                       ` Will Deacon
2019-04-02  9:03                         ` Will Deacon
2019-04-02  9:03                         ` Will Deacon
2019-04-08 14:22                         ` Will Deacon
2019-04-08 14:22                           ` Will Deacon
2019-04-08 14:22                           ` Will Deacon
2019-04-08 14:22                           ` Will Deacon
2019-04-08 17:18                           ` Yu Zhao
2019-04-08 17:18                             ` Yu Zhao
2019-04-08 17:18                             ` Yu Zhao
2019-04-08  9:09                     ` Marc Zyngier
2019-04-08  9:09                       ` Marc Zyngier
2019-04-08  9:09                       ` Marc Zyngier
2019-04-08  9:09                       ` Marc Zyngier
2019-03-12  0:57       ` [PATCH v4 4/4] arm64: mm: enable per pmd page table lock Yu Zhao
2019-03-12  0:57         ` Yu Zhao
2019-03-12  0:57         ` Yu Zhao
2019-02-19  3:08 ` [PATCH] " Anshuman Khandual
2019-02-19  3:08   ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190214211642.2200-1-yuzhao@google.com \
    --to=yuzhao@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=catalin.marinas@arm.com \
    --cc=joel@joelfernandes.org \
    --cc=kirill@shutemov.name \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@gmail.com \
    --cc=peterz@infradead.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.