All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Muellner <christoph.muellner@theobroma-systems.com>
To: robh+dt@kernel.org, mark.rutland@arm.com, heiko@sntech.de,
	shawn.lin@rock-chips.com, ulf.hansson@linaro.org,
	adrian.hunter@intel.com
Cc: Christoph Muellner <christoph.muellner@theobroma-systems.com>,
	Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Douglas Anderson <dianders@chromium.org>,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Emil Renner Berthing <kernel@esmil.dk>,
	Lin Huang <hl@rock-chips.com>, Tony Xie <tony.xie@rock-chips.com>,
	Randy Li <ayaka@soulik.info>, Vicente Bergas <vicencb@gmail.com>,
	Ezequiel Garcia <ezequiel@collabora.com>,
	Klaus Goger <klaus.goger@theobroma-systems.com>,
	linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: [PATCH v2 1/3] mmc: sdhci-of-arasan: Add DTS property to disable DCMDs.
Date: Thu,  7 Mar 2019 09:43:26 +0100	[thread overview]
Message-ID: <20190307084329.25416-1-christoph.muellner@theobroma-systems.com> (raw)

Direct commands (DCMDs) are an optional feature of eMMC 5.1's command
queue engine (CQE). The Arasan eMMC 5.1 controller uses the CQHCI,
which exposes a control register bit to enable the feature.
The current implementation sets this bit unconditionally.

This patch allows to suppress the feature activation,
by specifying the property disable-cqe-dcmd.

Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>
Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---
 drivers/mmc/host/sdhci-of-arasan.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index c9e3e050ccc8..88dc3f00a5be 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -832,7 +832,10 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
 		host->mmc_host_ops.start_signal_voltage_switch =
 					sdhci_arasan_voltage_switch;
 		sdhci_arasan->has_cqe = true;
-		host->mmc->caps2 |= MMC_CAP2_CQE | MMC_CAP2_CQE_DCMD;
+		host->mmc->caps2 |= MMC_CAP2_CQE;
+
+		if (!of_property_read_bool(np, "disable-cqe-dcmd"))
+			host->mmc->caps2 |= MMC_CAP2_CQE_DCMD;
 	}
 
 	ret = sdhci_arasan_add_host(sdhci_arasan);
-- 
2.11.0


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Muellner <christoph.muellner@theobroma-systems.com>
To: robh+dt@kernel.org, mark.rutland@arm.com, heiko@sntech.de,
	shawn.lin@rock-chips.com, ulf.hansson@linaro.org,
	adrian.hunter@intel.com
Cc: devicetree@vger.kernel.org,
	Emil Renner Berthing <kernel@esmil.dk>,
	Tony Xie <tony.xie@rock-chips.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Randy Li <ayaka@soulik.info>,
	linux-mmc@vger.kernel.org,
	Douglas Anderson <dianders@chromium.org>,
	Vicente Bergas <vicencb@gmail.com>,
	Michal Simek <michal.simek@xilinx.com>,
	linux-rockchip@lists.infradead.org, Lin Huang <hl@rock-chips.com>,
	Klaus Goger <klaus.goger@theobroma-systems.com>,
	linux-arm-kernel@lists.infradead.org,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
	Ezequiel Garcia <ezequiel@collabora.com>,
	linux-kernel@vger.kernel.org,
	Christoph Muellner <christoph.muellner@theobroma-systems.com>
Subject: [PATCH v2 1/3] mmc: sdhci-of-arasan: Add DTS property to disable DCMDs.
Date: Thu,  7 Mar 2019 09:43:26 +0100	[thread overview]
Message-ID: <20190307084329.25416-1-christoph.muellner@theobroma-systems.com> (raw)

Direct commands (DCMDs) are an optional feature of eMMC 5.1's command
queue engine (CQE). The Arasan eMMC 5.1 controller uses the CQHCI,
which exposes a control register bit to enable the feature.
The current implementation sets this bit unconditionally.

This patch allows to suppress the feature activation,
by specifying the property disable-cqe-dcmd.

Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>
Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---
 drivers/mmc/host/sdhci-of-arasan.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index c9e3e050ccc8..88dc3f00a5be 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -832,7 +832,10 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
 		host->mmc_host_ops.start_signal_voltage_switch =
 					sdhci_arasan_voltage_switch;
 		sdhci_arasan->has_cqe = true;
-		host->mmc->caps2 |= MMC_CAP2_CQE | MMC_CAP2_CQE_DCMD;
+		host->mmc->caps2 |= MMC_CAP2_CQE;
+
+		if (!of_property_read_bool(np, "disable-cqe-dcmd"))
+			host->mmc->caps2 |= MMC_CAP2_CQE_DCMD;
 	}
 
 	ret = sdhci_arasan_add_host(sdhci_arasan);
-- 
2.11.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2019-03-07  8:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07  8:43 Christoph Muellner [this message]
2019-03-07  8:43 ` [PATCH v2 1/3] mmc: sdhci-of-arasan: Add DTS property to disable DCMDs Christoph Muellner
2019-03-07  8:43 ` [PATCH v2 2/3] dt-bindings: mmc: Add a new property disable-cqe-dcmd Christoph Muellner
2019-03-07  8:43   ` Christoph Muellner
2019-03-08 12:46   ` Adrian Hunter
2019-03-08 12:46     ` Adrian Hunter
2019-03-08 13:10     ` Christoph Müllner
2019-03-08 13:10       ` Christoph Müllner
2019-03-08 13:10       ` Christoph Müllner
2019-03-12 13:17       ` Heiko Stuebner
2019-03-12 13:17         ` Heiko Stuebner
2019-03-12 13:17         ` Heiko Stuebner
2019-03-12 14:46         ` Christoph Müllner
2019-03-12 14:46           ` Christoph Müllner
2019-03-12 14:46           ` Christoph Müllner
2019-03-12 17:10           ` Heiko Stübner
2019-03-12 17:10             ` Heiko Stübner
2019-03-12 17:10             ` Heiko Stübner
2019-03-12 17:16             ` Christoph Müllner
2019-03-12 17:16               ` Christoph Müllner
2019-03-12 19:28   ` Rob Herring
2019-03-12 19:28     ` Rob Herring
2019-03-12 19:28     ` Rob Herring
2019-03-07  8:43 ` [PATCH v2 3/3] arm64: dts: rockchip: Disable DCMDs on RK3399's eMMC controller Christoph Muellner
2019-03-07  8:43   ` Christoph Muellner
2019-03-08 12:47 ` [PATCH v2 1/3] mmc: sdhci-of-arasan: Add DTS property to disable DCMDs Adrian Hunter
2019-03-08 12:47   ` Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190307084329.25416-1-christoph.muellner@theobroma-systems.com \
    --to=christoph.muellner@theobroma-systems.com \
    --cc=adrian.hunter@intel.com \
    --cc=ayaka@soulik.info \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=enric.balletbo@collabora.com \
    --cc=ezequiel@collabora.com \
    --cc=heiko@sntech.de \
    --cc=hl@rock-chips.com \
    --cc=kernel@esmil.dk \
    --cc=klaus.goger@theobroma-systems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=michal.simek@xilinx.com \
    --cc=philipp.tomsich@theobroma-systems.com \
    --cc=robh+dt@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=tony.xie@rock-chips.com \
    --cc=ulf.hansson@linaro.org \
    --cc=vicencb@gmail.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.